Christopher Felegy ac389f5f68 fix: DefaultWebSocket can now correctly close This resolves a bug where disconnecting the socket client would not actually close the websocket. Bots would appear to remain online in the discord client until their connection to discord eventually timed out. The underlying cause of this issue sourced from the cancellation token passed into the websocket's ReceiveAsync method - when entering the disconnect process, the first step is to cancel out all of the connection tokens. Unfortunately, the standard ClientWebSocket handles a token cancellation by aborting the socket, rendering it inoperable for a safe closure. This change removes the inner cancellation token passed into ReceiveAsync. The cancellation token is still retained for use in the receive loop, so the receive task should gracefully complete once some event satisfies the ClientWebSocket's blocking receive. To ensure that all clients succesfully close, regardless of their traffic, the disconnect procedure was rearranged such that awaiting the receive task now occurs last, after the socket has been closed. Closing the socket will propagate an event up to the ClientWebSocket's receive method, which will allow the loop to iterate and gracefully complete. So far, I have validated this change against basic connection opening and closing, for both the gateway and voice clients. I have not yet validated against unplanned connection interruptions, though I believe that this change might actually improve some of those connection bugs, since the ClientWebSocket should never find itself in an aborted state.		6 years ago
.github	meta: add pull request template	6 years ago

docs	Got rid of use of undefined variables	6 years ago

experiment	Documentation Overhaul (#1161)	6 years ago

samples	docs: add example of custom error message to sample	6 years ago

src	fix: DefaultWebSocket can now correctly close	6 years ago

test/Discord.Net.Tests	fix: Improve validation of Bot Tokens (#1206)	6 years ago

.editorconfig	Add EditorConfig (#876)	7 years ago

.gitattributes	Added gitattributes	9 years ago

.gitignore	Documentation Overhaul (#1161)	6 years ago

CHANGELOG.md	meta: add changelog	6 years ago

CONTRIBUTING.md	Documentation Overhaul (#1161)	6 years ago

Discord.Net.code-workspace	Documentation Overhaul (#1161)	6 years ago

Discord.Net.sln	Add DiscordShardedClient sample project & Client FAQ entry. (#1177)	6 years ago

Discord.Net.sln.DotSettings	Documentation Overhaul (#1161)	6 years ago

Discord.Net.targets	Update Dependencies and support NS2.0 builds (#1046)	7 years ago

LICENSE	Update LICENSE	7 years ago

README.md	Update README.md (#1117)	6 years ago

appveyor.yml	Fix deploy conditions in CI script (#1157)	6 years ago

README.md

Discord.Net

Discord.Net

An unofficial .NET API Wrapper for the Discord client (http://discordapp.com).

Check out the documentation or join the Discord API Chat.

Installation

Stable (NuGet)

Our stable builds available from NuGet through the Discord.Net metapackage:

Discord.Net

The individual components may also be installed from NuGet:

Unstable (MyGet)

Nightly builds are available through our MyGet feed (https://www.myget.org/F/discord-net/api/v3/index.json).

Compiling

In order to compile Discord.Net, you require the following:

Using Visual Studio

The .NET Core workload must be selected during Visual Studio installation.

Using Command Line

.NET Core SDK

Known Issues

WebSockets (Win7 and earlier)

.NET Core 1.1 does not support WebSockets on Win7 and earlier. This issue has been fixed since the release of .NET Core 2.1. It is recommended to target .NET Core 2.1 or above for your project if you wish to run your bot on legacy platforms; alternatively, you may choose to install the Discord.Net.Providers.WS4Net package.

No Description

C#

rogueexception@gmail.com brandon.smith@ironboots.net foxbot@protonmail.com foxbot@users.noreply.github.com jii.geugten@gmail.com FiniteReality@users.noreply.github.com tcbskater@hotmail.com DigiTechs@users.noreply.github.com james.siqi.liu@gmail.com computerizedtaco@gmail.com 341464@gmail.com chris@thejohnstons.net voltagei@ironboots.net sindre_langhus@msn.com Flamanis@users.noreply.github.com gc2149@gmail.com abstractkitty@iamtrue.net helpfulstranger999@gmail.com marcel.p99@gmx.de khionu@users.noreply.github.com digpoealternate@gmail.com sindre.g.langhus@gmail.com 13098994+foxbot@users.noreply.github.com 420foxbot@users.noreply.github.com MonkeyzFtw@gmail.com

How to access data resources in code