Browse Source

Removing constructs to close streams that catch Throwable -> FileUtils.close.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@278328 13f79535-47bb-0310-9956-ffa450edef68
master
Jacobus Martinus Kruithof 20 years ago
parent
commit
fa038427c2
9 changed files with 14 additions and 44 deletions
  1. +3
    -14
      src/main/org/apache/tools/ant/taskdefs/Concat.java
  2. +3
    -7
      src/main/org/apache/tools/ant/taskdefs/Jikes.java
  3. +2
    -7
      src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java
  4. +1
    -1
      src/testcases/org/apache/tools/ant/filters/DynamicFilterTest.java
  5. +1
    -1
      src/testcases/org/apache/tools/ant/filters/TokenFilterTest.java
  6. +1
    -1
      src/testcases/org/apache/tools/ant/taskdefs/ConcatTest.java
  7. +1
    -6
      src/testcases/org/apache/tools/ant/taskdefs/ExecTaskTest.java
  8. +1
    -6
      src/testcases/org/apache/tools/ant/taskdefs/ExecuteOnTest.java
  9. +1
    -1
      src/testcases/org/apache/tools/ant/taskdefs/StyleTest.java

+ 3
- 14
src/main/org/apache/tools/ant/taskdefs/Concat.java View File

@@ -523,13 +523,8 @@ public class Concat extends Task {
in = null;
}
} finally {
if (in != null) {
try {
in.close();
} catch (Throwable t) {
// Ignore
}
}
FileUtils.close(in);

if (out != null) {
try {
out.close();
@@ -730,13 +725,7 @@ public class Concat extends Task {
} catch (IOException ex) {
throw new BuildException(ex);
} finally {
if (reader != null) {
try {
reader.close();
} catch (Throwable t) {
// ignore
}
}
FileUtils.close(reader);
}
}



+ 3
- 7
src/main/org/apache/tools/ant/taskdefs/Jikes.java View File

@@ -21,8 +21,10 @@ import java.io.FileWriter;
import java.io.IOException;
import java.io.PrintWriter;
import java.util.Random;

import org.apache.tools.ant.BuildException;
import org.apache.tools.ant.Project;
import org.apache.tools.ant.util.FileUtils;

/**
* Encapsulates a Jikes compiler, by directly executing an external
@@ -94,13 +96,7 @@ public class Jikes {
throw new BuildException("Error creating temporary file",
e);
} finally {
if (out != null) {
try {
out.close();
} catch (Throwable t) {
// ignore
}
}
FileUtils.close(out);
}
} else {
commandArray = new String[args.length + 1];


+ 2
- 7
src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java View File

@@ -37,6 +37,7 @@ import org.apache.tools.ant.types.EnumeratedAttribute;
import org.apache.tools.ant.types.Path;
import org.apache.tools.ant.types.PatternSet;
import org.apache.tools.ant.types.Reference;
import org.apache.tools.ant.util.FileUtils;
import org.apache.tools.ant.util.LoaderUtils;

/**
@@ -551,13 +552,7 @@ public class JDependTask extends Task {

jdepend.analyze();
} finally {
if (fw != null) {
try {
fw.close();
} catch (Throwable t) {
// Ignore
}
}
FileUtils.close(fw);
}
return SUCCESS;
}


+ 1
- 1
src/testcases/org/apache/tools/ant/filters/DynamicFilterTest.java View File

@@ -71,7 +71,7 @@ public class DynamicFilterTest extends BuildFileTest {
return FileUtils.readFully(r);
}
finally {
try {r.close();} catch (Throwable ignore) {}
FileUtils.close(r);
}

}


+ 1
- 1
src/testcases/org/apache/tools/ant/filters/TokenFilterTest.java View File

@@ -251,7 +251,7 @@ public class TokenFilterTest extends BuildFileTest {
return FileUtils.readFully(r);
}
finally {
try {r.close();} catch (Throwable ignore) {}
FileUtils.close(r);
}

}


+ 1
- 1
src/testcases/org/apache/tools/ant/taskdefs/ConcatTest.java View File

@@ -246,7 +246,7 @@ public class ConcatTest
return FileUtils.readFully(r);
}
finally {
try {r.close();} catch (Throwable ignore) {}
FileUtils.close(r);
}

}


+ 1
- 6
src/testcases/org/apache/tools/ant/taskdefs/ExecTaskTest.java View File

@@ -482,12 +482,7 @@ public class ExecTaskTest extends BuildFileTest {
result = FileUtils.readFully(reader);
} catch (IOException eyeOhEx) {
} finally {
if (reader != null) {
try {
reader.close();
} catch (Throwable ignore) {
}
}
FileUtils.close(reader);
}
return result;
}


+ 1
- 6
src/testcases/org/apache/tools/ant/taskdefs/ExecuteOnTest.java View File

@@ -570,12 +570,7 @@ public class ExecuteOnTest extends BuildFileTest {
reader = new FileReader(getProject().resolveFile(filename));
result = FileUtils.readFully(reader);
} finally {
if (reader != null) {
try {
reader.close();
} catch (Throwable ignore) {
}
}
FileUtils.close(reader);
}
return result;
}


+ 1
- 1
src/testcases/org/apache/tools/ant/taskdefs/StyleTest.java View File

@@ -124,7 +124,7 @@ public class StyleTest extends BuildFileTest {
return FileUtils.readFully(r);
}
finally {
try {r.close();} catch (Throwable ignore) {}
FileUtils.close(r);
}

}


Loading…
Cancel
Save