diff --git a/src/main/org/apache/tools/ant/taskdefs/Concat.java b/src/main/org/apache/tools/ant/taskdefs/Concat.java index c7cf62197..d7a50113c 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Concat.java +++ b/src/main/org/apache/tools/ant/taskdefs/Concat.java @@ -523,13 +523,8 @@ public class Concat extends Task { in = null; } } finally { - if (in != null) { - try { - in.close(); - } catch (Throwable t) { - // Ignore - } - } + FileUtils.close(in); + if (out != null) { try { out.close(); @@ -730,13 +725,7 @@ public class Concat extends Task { } catch (IOException ex) { throw new BuildException(ex); } finally { - if (reader != null) { - try { - reader.close(); - } catch (Throwable t) { - // ignore - } - } + FileUtils.close(reader); } } diff --git a/src/main/org/apache/tools/ant/taskdefs/Jikes.java b/src/main/org/apache/tools/ant/taskdefs/Jikes.java index 8c1f6fc5c..ed5422f54 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Jikes.java +++ b/src/main/org/apache/tools/ant/taskdefs/Jikes.java @@ -21,8 +21,10 @@ import java.io.FileWriter; import java.io.IOException; import java.io.PrintWriter; import java.util.Random; + import org.apache.tools.ant.BuildException; import org.apache.tools.ant.Project; +import org.apache.tools.ant.util.FileUtils; /** * Encapsulates a Jikes compiler, by directly executing an external @@ -94,13 +96,7 @@ public class Jikes { throw new BuildException("Error creating temporary file", e); } finally { - if (out != null) { - try { - out.close(); - } catch (Throwable t) { - // ignore - } - } + FileUtils.close(out); } } else { commandArray = new String[args.length + 1]; diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java index 6e784684f..369911020 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java @@ -37,6 +37,7 @@ import org.apache.tools.ant.types.EnumeratedAttribute; import org.apache.tools.ant.types.Path; import org.apache.tools.ant.types.PatternSet; import org.apache.tools.ant.types.Reference; +import org.apache.tools.ant.util.FileUtils; import org.apache.tools.ant.util.LoaderUtils; /** @@ -551,13 +552,7 @@ public class JDependTask extends Task { jdepend.analyze(); } finally { - if (fw != null) { - try { - fw.close(); - } catch (Throwable t) { - // Ignore - } - } + FileUtils.close(fw); } return SUCCESS; } diff --git a/src/testcases/org/apache/tools/ant/filters/DynamicFilterTest.java b/src/testcases/org/apache/tools/ant/filters/DynamicFilterTest.java index 2c8ba9a49..0aa546fd8 100644 --- a/src/testcases/org/apache/tools/ant/filters/DynamicFilterTest.java +++ b/src/testcases/org/apache/tools/ant/filters/DynamicFilterTest.java @@ -71,7 +71,7 @@ public class DynamicFilterTest extends BuildFileTest { return FileUtils.readFully(r); } finally { - try {r.close();} catch (Throwable ignore) {} + FileUtils.close(r); } } diff --git a/src/testcases/org/apache/tools/ant/filters/TokenFilterTest.java b/src/testcases/org/apache/tools/ant/filters/TokenFilterTest.java index 1c5ebb14a..0fbf270d5 100644 --- a/src/testcases/org/apache/tools/ant/filters/TokenFilterTest.java +++ b/src/testcases/org/apache/tools/ant/filters/TokenFilterTest.java @@ -251,7 +251,7 @@ public class TokenFilterTest extends BuildFileTest { return FileUtils.readFully(r); } finally { - try {r.close();} catch (Throwable ignore) {} + FileUtils.close(r); } } diff --git a/src/testcases/org/apache/tools/ant/taskdefs/ConcatTest.java b/src/testcases/org/apache/tools/ant/taskdefs/ConcatTest.java index 562b4d5aa..5d8b5a6e7 100644 --- a/src/testcases/org/apache/tools/ant/taskdefs/ConcatTest.java +++ b/src/testcases/org/apache/tools/ant/taskdefs/ConcatTest.java @@ -246,7 +246,7 @@ public class ConcatTest return FileUtils.readFully(r); } finally { - try {r.close();} catch (Throwable ignore) {} + FileUtils.close(r); } } diff --git a/src/testcases/org/apache/tools/ant/taskdefs/ExecTaskTest.java b/src/testcases/org/apache/tools/ant/taskdefs/ExecTaskTest.java index ef384e5c8..890526678 100644 --- a/src/testcases/org/apache/tools/ant/taskdefs/ExecTaskTest.java +++ b/src/testcases/org/apache/tools/ant/taskdefs/ExecTaskTest.java @@ -482,12 +482,7 @@ public class ExecTaskTest extends BuildFileTest { result = FileUtils.readFully(reader); } catch (IOException eyeOhEx) { } finally { - if (reader != null) { - try { - reader.close(); - } catch (Throwable ignore) { - } - } + FileUtils.close(reader); } return result; } diff --git a/src/testcases/org/apache/tools/ant/taskdefs/ExecuteOnTest.java b/src/testcases/org/apache/tools/ant/taskdefs/ExecuteOnTest.java index 0105e42d0..30cc7f6bf 100755 --- a/src/testcases/org/apache/tools/ant/taskdefs/ExecuteOnTest.java +++ b/src/testcases/org/apache/tools/ant/taskdefs/ExecuteOnTest.java @@ -570,12 +570,7 @@ public class ExecuteOnTest extends BuildFileTest { reader = new FileReader(getProject().resolveFile(filename)); result = FileUtils.readFully(reader); } finally { - if (reader != null) { - try { - reader.close(); - } catch (Throwable ignore) { - } - } + FileUtils.close(reader); } return result; } diff --git a/src/testcases/org/apache/tools/ant/taskdefs/StyleTest.java b/src/testcases/org/apache/tools/ant/taskdefs/StyleTest.java index 3862a5f11..b9ba7fa59 100644 --- a/src/testcases/org/apache/tools/ant/taskdefs/StyleTest.java +++ b/src/testcases/org/apache/tools/ant/taskdefs/StyleTest.java @@ -124,7 +124,7 @@ public class StyleTest extends BuildFileTest { return FileUtils.readFully(r); } finally { - try {r.close();} catch (Throwable ignore) {} + FileUtils.close(r); } }