Browse Source

Ant disallowed manifest attributes that contained the character 8. PR 45675.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@688105 13f79535-47bb-0310-9956-ffa450edef68
master
Stefan Bodewig 17 years ago
parent
commit
ab5fb066bd
3 changed files with 41 additions and 1 deletions
  1. +4
    -0
      WHATSNEW
  2. +1
    -1
      src/main/org/apache/tools/ant/taskdefs/ManifestTask.java
  3. +36
    -0
      src/tests/antunit/taskdefs/manifest-test.xml

+ 4
- 0
WHATSNEW View File

@@ -162,6 +162,10 @@ Fixed bugs:
was used.
Bugzilla Report 43892.

* <jar> and <manifest> disallowed manifest attributes whose name
contained the character '8'.
Bugzilla Report 45675.

Other changes:
--------------



+ 1
- 1
src/main/org/apache/tools/ant/taskdefs/ManifestTask.java View File

@@ -50,7 +50,7 @@ public class ManifestTask extends Task {
* {@value}
*/
public static final String VALID_ATTRIBUTE_CHARS =
"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345679-_";
"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_";

/**
* Holds the real data.


+ 36
- 0
src/tests/antunit/taskdefs/manifest-test.xml View File

@@ -0,0 +1,36 @@
<?xml version="1.0"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<project default="antunit"
xmlns:au="antlib:org.apache.ant.antunit">

<import file="../antunit-base.xml" />

<property name="file" location="test.mf"/>

<target name="tearDown">
<delete file="${file}"/>
</target>

<target name="test8IsAllowed"
description="https://issues.apache.org/bugzilla/show_bug.cgi?id=45675"
>
<manifest file="${file}">
<attribute name="attrib8" value="test attribute"/>
</manifest>
</target>
</project>

Loading…
Cancel
Save