From ab5fb066bd93c7713f4628ba564ab6e91890f811 Mon Sep 17 00:00:00 2001
From: Stefan Bodewig <bodewig@apache.org>
Date: Fri, 22 Aug 2008 15:50:29 +0000
Subject: [PATCH] Ant disallowed manifest attributes that contained the
 character 8.  PR 45675.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@688105 13f79535-47bb-0310-9956-ffa450edef68
---
 WHATSNEW                                      |  4 +++
 .../tools/ant/taskdefs/ManifestTask.java      |  2 +-
 src/tests/antunit/taskdefs/manifest-test.xml  | 36 +++++++++++++++++++
 3 files changed, 41 insertions(+), 1 deletion(-)
 create mode 100644 src/tests/antunit/taskdefs/manifest-test.xml

diff --git a/WHATSNEW b/WHATSNEW
index e78abae3d..6938e986a 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -162,6 +162,10 @@ Fixed bugs:
    was used.
    Bugzilla Report 43892.
 
+ * <jar> and <manifest> disallowed manifest attributes whose name
+   contained the character '8'.
+   Bugzilla Report 45675.
+
 Other changes:
 --------------
 
diff --git a/src/main/org/apache/tools/ant/taskdefs/ManifestTask.java b/src/main/org/apache/tools/ant/taskdefs/ManifestTask.java
index 9948056bc..1247eccdb 100644
--- a/src/main/org/apache/tools/ant/taskdefs/ManifestTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/ManifestTask.java
@@ -50,7 +50,7 @@ public class ManifestTask extends Task {
      * {@value}
      */
     public static final String VALID_ATTRIBUTE_CHARS =
-        "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345679-_";
+        "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_";
 
     /**
      * Holds the real data.
diff --git a/src/tests/antunit/taskdefs/manifest-test.xml b/src/tests/antunit/taskdefs/manifest-test.xml
new file mode 100644
index 000000000..ec1213f37
--- /dev/null
+++ b/src/tests/antunit/taskdefs/manifest-test.xml
@@ -0,0 +1,36 @@
+<?xml version="1.0"?>
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+<project default="antunit"
+         xmlns:au="antlib:org.apache.ant.antunit">
+
+  <import file="../antunit-base.xml" />
+
+  <property name="file" location="test.mf"/>
+
+  <target name="tearDown">
+    <delete file="${file}"/>
+  </target>
+
+  <target name="test8IsAllowed"
+          description="https://issues.apache.org/bugzilla/show_bug.cgi?id=45675"
+          >
+    <manifest file="${file}">
+      <attribute name="attrib8" value="test attribute"/>
+    </manifest>
+  </target>
+</project>