fix javadoc warnings

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@909962 13f79535-47bb-0310-9956-ffa450edef68

src/main/org/apache/tools/ant/ProjectHelper.java

@@ -213,7 +213,7 @@ public class ProjectHelper {
      * Get the first project helper found in the classpath
      * 
      * @return an project helper, never <code>null</code>
-     * @see #getHelpers()
+     * @see org.apache.tools.ant.ProjectHelperRepository#getHelpers()
      */
     public static ProjectHelper getProjectHelper() {
         return (ProjectHelper) ProjectHelperRepository.getInstance().getHelpers().next();

src/main/org/apache/tools/ant/filters/SuffixLines.java

@@ -126,8 +126,8 @@ public final class SuffixLines
      *               May be <code>null</code>, in which case no suffix
      *               is added.
      */
-    public void setSuffix(final String append) {
-        this.suffix = append;
+    public void setSuffix(final String suffix) {
+        this.suffix = suffix;
     }
 
     /**

src/main/org/apache/tools/ant/taskdefs/Jar.java

@@ -249,7 +249,8 @@ public class Jar extends Zip {
      * jars on Java 1.4 or earlier Ant will not include META-INF
      * unless explicitly asked to.</p>
      *
-     * @see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4408526
+     * @see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4408526">
+     * jar -i omits service providers in index.list</a>
      * @since Ant 1.8.0
      * @param flag a <code>boolean</code> value, defaults to false
      */

src/main/org/apache/tools/ant/taskdefs/condition/Http.java

@@ -70,7 +70,7 @@ public class Http extends ProjectComponent implements Condition {
      *               such as "GET", "HEAD", "TRACE", etc. The default
      *               if not specified is "GET".
      *
-     * @see java.net.HttpURLConnection#setRequestMethod()
+     * @see java.net.HttpURLConnection#setRequestMethod
      * @since Ant 1.8.0
      */
     public void setRequestMethod(String method) {

src/main/org/apache/tools/ant/taskdefs/optional/junit/FailureRecorder.java

@@ -79,7 +79,8 @@ public class FailureRecorder extends ProjectComponent implements JUnitResultForm
     public static final String MAGIC_PROPERTY_CLASS_LOCATION
         = "ant.junit.failureCollector";
 
-    /** Default location and name for the generated JUnit class file. {@value} */
+    /** Default location and name for the generated JUnit class file,
+     *  in the temp directory + FailedTests */
     public static final String DEFAULT_CLASS_LOCATION
         = System.getProperty("java.io.tmpdir") + "FailedTests";
 
@@ -366,7 +367,7 @@ public class FailureRecorder extends ProjectComponent implements JUnitResultForm
          * The SortedMap needs comparable elements.
          * @param other the object to compare to.
          * @return the result of the comparison.
-         * @see java.lang.Comparable#compareTo(T)
+         * @see java.lang.Comparable#compareTo
          * @see SortedSet#comparator()
          */
         public int compareTo(Object other) {

src/main/org/apache/tools/ant/types/PatternSet.java

@@ -100,7 +100,6 @@ public class PatternSet extends DataType implements Cloneable {
          * @param cond A property name or expression.  If the
          *             expression evaluates to true or a property of
          *             its value is present, the name is invalid.
-         * @param cond A property name or expression.
          * @since Ant 1.8.0
          */
         public void setUnless(Object cond) {

src/main/org/apache/tools/zip/UnrecognizedExtraField.java

@@ -140,7 +140,6 @@ public class UnrecognizedExtraField
      * @param data the array of bytes.
      * @param offset the source location in the data array.
      * @param length the number of bytes to use in the data array.
-     * @see ZipExtraField#parseFromCentralDirectoryData(byte[], int, int)
      */
     public void parseFromCentralDirectoryData(byte[] data, int offset,
                                               int length) {