From 77cba689ceb7e72931ba405bfab50150a21e3271 Mon Sep 17 00:00:00 2001 From: Antoine Levy-Lambert Date: Sun, 14 Feb 2010 02:18:35 +0000 Subject: [PATCH] fix javadoc warnings git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@909962 13f79535-47bb-0310-9956-ffa450edef68 --- src/main/org/apache/tools/ant/ProjectHelper.java | 2 +- src/main/org/apache/tools/ant/filters/SuffixLines.java | 4 ++-- src/main/org/apache/tools/ant/taskdefs/Jar.java | 3 ++- src/main/org/apache/tools/ant/taskdefs/condition/Http.java | 2 +- .../tools/ant/taskdefs/optional/junit/FailureRecorder.java | 5 +++-- src/main/org/apache/tools/ant/types/PatternSet.java | 1 - src/main/org/apache/tools/zip/UnrecognizedExtraField.java | 1 - 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/org/apache/tools/ant/ProjectHelper.java b/src/main/org/apache/tools/ant/ProjectHelper.java index c1fae2375..0ca476ef1 100644 --- a/src/main/org/apache/tools/ant/ProjectHelper.java +++ b/src/main/org/apache/tools/ant/ProjectHelper.java @@ -213,7 +213,7 @@ public class ProjectHelper { * Get the first project helper found in the classpath * * @return an project helper, never null - * @see #getHelpers() + * @see org.apache.tools.ant.ProjectHelperRepository#getHelpers() */ public static ProjectHelper getProjectHelper() { return (ProjectHelper) ProjectHelperRepository.getInstance().getHelpers().next(); diff --git a/src/main/org/apache/tools/ant/filters/SuffixLines.java b/src/main/org/apache/tools/ant/filters/SuffixLines.java index a4bdceea9..d2a211178 100644 --- a/src/main/org/apache/tools/ant/filters/SuffixLines.java +++ b/src/main/org/apache/tools/ant/filters/SuffixLines.java @@ -126,8 +126,8 @@ public final class SuffixLines * May be null, in which case no suffix * is added. */ - public void setSuffix(final String append) { - this.suffix = append; + public void setSuffix(final String suffix) { + this.suffix = suffix; } /** diff --git a/src/main/org/apache/tools/ant/taskdefs/Jar.java b/src/main/org/apache/tools/ant/taskdefs/Jar.java index 538e8407e..92f6672ef 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Jar.java +++ b/src/main/org/apache/tools/ant/taskdefs/Jar.java @@ -249,7 +249,8 @@ public class Jar extends Zip { * jars on Java 1.4 or earlier Ant will not include META-INF * unless explicitly asked to.

* - * @see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4408526 + * @see + * jar -i omits service providers in index.list * @since Ant 1.8.0 * @param flag a boolean value, defaults to false */ diff --git a/src/main/org/apache/tools/ant/taskdefs/condition/Http.java b/src/main/org/apache/tools/ant/taskdefs/condition/Http.java index f052720a5..6b545b5ab 100644 --- a/src/main/org/apache/tools/ant/taskdefs/condition/Http.java +++ b/src/main/org/apache/tools/ant/taskdefs/condition/Http.java @@ -70,7 +70,7 @@ public class Http extends ProjectComponent implements Condition { * such as "GET", "HEAD", "TRACE", etc. The default * if not specified is "GET". * - * @see java.net.HttpURLConnection#setRequestMethod() + * @see java.net.HttpURLConnection#setRequestMethod * @since Ant 1.8.0 */ public void setRequestMethod(String method) { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/FailureRecorder.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/FailureRecorder.java index 3156b1a17..5e62fb75f 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/FailureRecorder.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/FailureRecorder.java @@ -79,7 +79,8 @@ public class FailureRecorder extends ProjectComponent implements JUnitResultForm public static final String MAGIC_PROPERTY_CLASS_LOCATION = "ant.junit.failureCollector"; - /** Default location and name for the generated JUnit class file. {@value} */ + /** Default location and name for the generated JUnit class file, + * in the temp directory + FailedTests */ public static final String DEFAULT_CLASS_LOCATION = System.getProperty("java.io.tmpdir") + "FailedTests"; @@ -366,7 +367,7 @@ public class FailureRecorder extends ProjectComponent implements JUnitResultForm * The SortedMap needs comparable elements. * @param other the object to compare to. * @return the result of the comparison. - * @see java.lang.Comparable#compareTo(T) + * @see java.lang.Comparable#compareTo * @see SortedSet#comparator() */ public int compareTo(Object other) { diff --git a/src/main/org/apache/tools/ant/types/PatternSet.java b/src/main/org/apache/tools/ant/types/PatternSet.java index 603b5561f..62006b13c 100644 --- a/src/main/org/apache/tools/ant/types/PatternSet.java +++ b/src/main/org/apache/tools/ant/types/PatternSet.java @@ -100,7 +100,6 @@ public class PatternSet extends DataType implements Cloneable { * @param cond A property name or expression. If the * expression evaluates to true or a property of * its value is present, the name is invalid. - * @param cond A property name or expression. * @since Ant 1.8.0 */ public void setUnless(Object cond) { diff --git a/src/main/org/apache/tools/zip/UnrecognizedExtraField.java b/src/main/org/apache/tools/zip/UnrecognizedExtraField.java index e6311f008..3ae23d87b 100644 --- a/src/main/org/apache/tools/zip/UnrecognizedExtraField.java +++ b/src/main/org/apache/tools/zip/UnrecognizedExtraField.java @@ -140,7 +140,6 @@ public class UnrecognizedExtraField * @param data the array of bytes. * @param offset the source location in the data array. * @param length the number of bytes to use in the data array. - * @see ZipExtraField#parseFromCentralDirectoryData(byte[], int, int) */ public void parseFromCentralDirectoryData(byte[] data, int offset, int length) {