Browse Source

Fix for Bug 5637

NPE in JUnit XMLJunitResultFormatter if setUp() in TestSetup throws AssertionFailedError


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@270512 13f79535-47bb-0310-9956-ffa450edef68
master
Erik Hatcher 23 years ago
parent
commit
434ef8d608
1 changed files with 9 additions and 0 deletions
  1. +9
    -0
      src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java

+ 9
- 0
src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java View File

@@ -207,6 +207,15 @@ public class XMLJUnitResultFormatter implements JUnitResultFormatter, XMLConstan
*/ */
public void endTest(Test test) { public void endTest(Test test) {
Element currentTest = (Element) testElements.get(test); Element currentTest = (Element) testElements.get(test);
// Fix for bug #5637 - if a junit.extensions.TestSetup is
// used and throws an exception during setUp then startTest
// would never have been called
if (currentTest == null) {
startTest(test);
currentTest = (Element) testElements.get(test);
}
Long l = (Long) testStarts.get(test); Long l = (Long) testStarts.get(test);
currentTest.setAttribute(ATTR_TIME, currentTest.setAttribute(ATTR_TIME,
""+((System.currentTimeMillis()-l.longValue()) ""+((System.currentTimeMillis()-l.longValue())


Loading…
Cancel
Save