From 434ef8d60826411a8c025af4724097bd33f28747 Mon Sep 17 00:00:00 2001 From: Erik Hatcher Date: Sat, 5 Jan 2002 01:39:40 +0000 Subject: [PATCH] Fix for Bug 5637 NPE in JUnit XMLJunitResultFormatter if setUp() in TestSetup throws AssertionFailedError git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@270512 13f79535-47bb-0310-9956-ffa450edef68 --- .../taskdefs/optional/junit/XMLJUnitResultFormatter.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java index a50b368c1..84757cd0a 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java @@ -207,6 +207,15 @@ public class XMLJUnitResultFormatter implements JUnitResultFormatter, XMLConstan */ public void endTest(Test test) { Element currentTest = (Element) testElements.get(test); + + // Fix for bug #5637 - if a junit.extensions.TestSetup is + // used and throws an exception during setUp then startTest + // would never have been called + if (currentTest == null) { + startTest(test); + currentTest = (Element) testElements.get(test); + } + Long l = (Long) testStarts.get(test); currentTest.setAttribute(ATTR_TIME, ""+((System.currentTimeMillis()-l.longValue())