Philipp Oppermann
9cec8df1cc
Delay dropping of `DoraNode` in Python until all event data is freed
When dropping the `DoraNode`, it waits for the remaining drop tokens. This only works if all the dora events were already dropped before. With the Python GC, this is not guaranteed as some events might still be live on the heap (the user might even use them later). In such cases, we waited until we ran into a timeout, which resulted in very long exit times (see https://github.com/dora-rs/dora/issues/598 ).
This commit fixes this issue by adding a reference-counted copy of the `DoraNode` and `EventStream` to every event given to Python. This way, we can ensure that the underlying `DoraNode` is only dropped after the last event reference has been freed.
1 year ago
Eric Buehler
f722f1ac41
Merge pull request #585 from dora-rs/renovate/dependencies
Update dependencies
1 year ago
renovate[bot]
bd9706b958
Update dependencies
1 year ago
Philipp Oppermann
bdeade85d0
Merge pull request #584 from dora-rs/renovate/dependencies
Update dependencies
1 year ago
renovate[bot]
5ab2610e38
Update dependencies
1 year ago
Philipp Oppermann
6d3638e819
Merge pull request #580 from dora-rs/add_comment
add a comment on read_dora_input_id
1 year ago
Philipp Oppermann
8d63e81f1d
Merge pull request #583 from dora-rs/fix-575
Don't wait for non-started dynamic nodes on stop
1 year ago
Philipp Oppermann
508311ed9b
Don't wait for non-started dynamic nodes on stop
1 year ago
XxChang
2e426e5133
add safety
1 year ago
XxChang
8ee80cac6b
fix fmt
1 year ago
XxChang
e590b2e029
add a comment on read_dora_input_id
1 year ago
Eric Buehler
01c404710b
Merge pull request #579 from dora-rs/renovate/dependencies
Update dependencies
1 year ago
renovate[bot]
33d8745ad4
Update dependencies
1 year ago
Haixuan Xavier Tao
110ce99795
Merge pull request #566 from dora-rs/v0.3.5
V0.3.5
1 year ago
haixuanTao
85c7b03f43
Fix README and changelog
1 year ago
haixuanTao
b1672f772e
Bump to version 0.3.5
1 year ago
haixuanTao
4f9cf0532a
bumping to v0.3.5-rc1
1 year ago
Haixuan Xavier Tao
be1618a116
Merge pull request #568 from dora-rs/ignore-quicker-pending-drop-token
Ignore-quicker-pending-drop-token
1 year ago
Haixuan Xavier Tao
5c286917cb
Merge pull request #576 from dora-rs/increase-grace-duration
Increasing grace duration to 2 seconds so that drop token get well returned
1 year ago
haixuanTao
0a61082476
Increasing grace duration to 2 seconds so that drop token get well returned or ignored
1 year ago
Haixuan Xavier Tao
30de4ccc38
Merge pull request #573 from dora-rs/c_timestamp
C timestamp
1 year ago
Haixuan Xavier Tao
05e7bb1ac1
Merge pull request #571 from jdilla52/missing_types
add try from for floats
1 year ago
Philipp Oppermann
cd4aafae43
Merge pull request #574 from dora-rs/renovate/dependencies
Update Rust crate serde_json to v1.0.120
1 year ago
renovate[bot]
e8f846c4fc
Update Rust crate serde_json to v1.0.120
1 year ago
XxChang
ab2ea3e169
fix fmt
1 year ago
XxChang
ac65b0fc09
minor
1 year ago
XxChang
1f23470d8b
minor
1 year ago
XxChang
7904a3ee55
add a timestamp method to c-node-api
1 year ago
XxChang
fb362b7f27
add a timestamp method to c-node-api
1 year ago
XxChang
3f1185fd34
add a timestamp method to c-node-api
1 year ago
Philipp Oppermann
0f01afa8fb
Merge pull request #572 from dora-rs/renovate/dependencies
Update dependencies
1 year ago
renovate[bot]
156a821c7c
Update dependencies
1 year ago
jacques Perrault
52045f3af8
add try from for floats
1 year ago
Haixuan Xavier Tao
054ef593e3
Merge pull request #570 from dora-rs/derive-pyo3-special-method-for-node
1 year ago
haixuanTao
2b1299deba
Derive Node special method
1 year ago
haixuanTao
1f06034889
Increasing grace duration to 2 seconds so that drop token get well returned or ignored
1 year ago
haixuanTao
329844358a
Reduce timeout time and increase grace duration so that node exit gracefully within one second
1 year ago
haixuanTao
5b7a614c14
Reduce drop token time from 30s to 1s as most of the time the drop token is having a race condition with the GIL in python.
1 year ago
haixuanTao
320ef26da5
Update pip wheel to compile for musl
1 year ago
Philipp Oppermann
64f831ce02
Merge pull request #559 from dora-rs/error-logging
Add basic log forwarding from daemon to CLI
1 year ago
Haixuan Xavier Tao
04b845ad72
Merge pull request #547 from EricLBuehler/proc_macro_dir
Derive `__dir__`, `__str__`, `__repr__` with a proc macro crate
1 year ago
haixuanTao
3baabde73f
Add free Ubuntu disk space within the release job
1 year ago
haixuanTao
257c889a88
Bump dora version to 0.3.5-rc0
1 year ago
Philipp Oppermann
4e2d85e3b0
Fix or silence clippy warnings
1 year ago
Philipp Oppermann
a29189a040
Close log subscribers that cannot keep up
We need to avoid blocking the coordinator for too long.
1 year ago
Philipp Oppermann
1f32b29afe
Close log subscriber connection if send fails (instead of erroring)
1 year ago
Philipp Oppermann
b570cc314d
Remove some extra newlines in error message
1 year ago
Philipp Oppermann
2d0f0dcf5e
Merge branch 'main' into error-logging
1 year ago
Philipp Oppermann
1aaf5ef1a2
Improve log output
1 year ago
Philipp Oppermann
2680e61404
Change default log level to info and consider `RUST_LOG`
Allows to override the log level through the `RUST_LOG` env variable.
1 year ago