Stefan Bodewig
5f70336124
Merge branch '1.9.x' closes #46
8 years ago
Kui LIU
9ec11ae3b0
Remove the redundant nullcheck of value known to be non-null.
This statement contains a redundant check of a known non-null s against the constant null.
http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
8 years ago
Stefan Bodewig
20fe0ffaf6
properly handle factory configuration exception
based on patch by Kui Liu
8 years ago
Stefan Bodewig
99a7f5916b
createAndSet never returns null
based on pytch by Kui Liu
8 years ago
Stefan Bodewig
61811c2bc4
make code actually compile
8 years ago
Kui LIU
a4aec92684
Fix the inefficient use of keySet iterator with entrySet iterator.
The current source code accesses the key and value of a Hashtable entry, using a key that is retrieved from a keySet iterator.
It is more efficient to use an iterator on the entrySet of the Hashtable, to avoid the Map.get(key) lookup.
http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR
8 years ago
Kui LIU
3e101e28a9
Fix the inefficient use of keySet iterator with entrySet iterator.
The current source code accesses the key and value of a Hashtable entry, using a key that is retrieved from a keySet iterator.
It is more efficient to use an iterator on the entrySet of the Hashtable, to avoid the Map.get(key) lookup.
http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR
8 years ago
Stefan Bodewig
b2b058dcf7
Merge branch '1.9.x'
closes #42 closes #43
8 years ago
Kui LIU
013e9159e9
Fix the inefficient use of keySet iterator with entrySet iterator.
The current source code accesses the key and value of a Hashtable entry, using a key that is retrieved from a keySet iterator.
It is more efficient to use an iterator on the entrySet of the Hashtable, to avoid the Map.get(key) lookup.
8 years ago
Kui LIU
c141ef4009
Fix the problem of using '+=' operator to concatenate strings a in a loop.
The method is building a String using concatenation in a loop.
In each iteration, the String is converted to a StringBuilder, appended to, and converted back to a String.
This can lead to a cost quadratic in the number of iterations, as the growing string is recopied in each iteration.
Better performance can be obtained by using a StringBuilder explicitly.
http://findbugs.sourceforge.net/bugDescriptions.html#SBSC_USE_STRINGBUFFER_CONCATENATION
8 years ago
Stefan Bodewig
a8c086cdfa
Merge branch '1.9.x'
8 years ago
Stefan Bodewig
f8b5fda65a
credit Kui Liu for #41
8 years ago
Stefan Bodewig
8cf68cab65
Merge branch '1.9.x'
8 years ago
Stefan Bodewig
5bc6cc6eb3
forgot to credit George Bateman
8 years ago
Stefan Bodewig
9f4587ca62
Merge branch '1.9.x'
8 years ago
Kui LIU
bb975e67e1
Fix the problem of instanceof test always return true.
This instanceof test will always return true because DataType is the superclass of variable nested's class ResourceComparator. The variable nested is not initialized, it would be better to do a null test rather than an instanceof test.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF
8 years ago
Stefan Bodewig
e18de97c4f
Merge branch '1.9.x'
8 years ago
Stefan Bodewig
3a5bf997b7
line ends
8 years ago
Jaikiran Pai
7ccb903712
BZ-60644 Update release notes
8 years ago
Jaikiran Pai
20f9491557
BZ-60644 Skip copying files, to avoid corrupting source files, if the source file and dest file are symlinked to each other
8 years ago
Jaikiran Pai
3522f74357
Update release notes. This closes #37 pull request at github/apache/ant
8 years ago
Jaikiran Pai
07c54f0bb1
BZ-60644 Skip copying files, to avoid corrupting source files, if the source file and dest file are symlinked to each other
8 years ago
Stefan Bodewig
997fee1f5f
formally merge branch '1.9.x'
8 years ago
Stefan Bodewig
01613e0d82
record change, add @since tags, closes #36
8 years ago
George Bateman
2c5430b420
Fix zip-test
8 years ago
George Bateman
a0cb1fa843
Reverse dependancy of DateUtils on Touch
Also add test
8 years ago
George Bateman
9d4b432840
Allow faking of zip entry modification times.
Adds DateUtils.parseLenientDateTime.
8 years ago
Stefan Bodewig
49fd6018e6
record change, add @since tags, closes #36
8 years ago
George Bateman
1f15ad0db4
Fix zip-test
8 years ago
George Bateman
62963673f6
Reverse dependancy of DateUtils on Touch
Also add test
8 years ago
George Bateman
5d56df3e41
Allow faking of zip entry modification times.
Adds DateUtils.parseLenientDateTime.
8 years ago
Jaikiran Pai
f9ef22329a
Minor - Use generics, for params of the newly introduced constructor, to be consistent with the rest of the code
8 years ago
Jaikiran Pai
1012dd6e2a
Merge pull request #39 . This closes #39 pull request on github/apache/ant
8 years ago
Jaikiran Pai
7b09880b6f
BZ-58589 Preserve last modified time (if asked for) for files uploaded by SFTP
8 years ago
Stefan Bodewig
a8b4654899
update BCEL dependency to 6.0
https://bz.apache.org/bugzilla/show_bug.cgi?id=61196
8 years ago
Jaikiran Pai
c2a61ea21c
Merge 1.9.x branch
8 years ago
Jaikiran Pai
b9125733c4
BZ-43271 BZ-59648 Change permissions on the correct remote file (path) that was transferred, instead of accidentally changing the permissions of the directory containing the transferred file
8 years ago
Stefan Bodewig
c848ace1ed
Merge branch '1.9.x'
closes #33 by @niggemannmj
8 years ago
Stefan Bodewig
4e2e7d9614
add since markers, add Mark to contributors
8 years ago
Mark Niggemann
e93a598ad0
Update manual for ejbjar orion element.
8 years ago
Mark Niggemann
49d63a1196
Add Orion EJB deployment tool to EjbJar taskdef.
8 years ago
Mark Niggemann
c75d148f32
Add Orion EJB deployment tool to EjbJar taskdef.
8 years ago
Jan Matrne
7a7307bc99
add magic property that override's tstamp's idea of "now" in ISO-8601 format
https://bz.apache.org/bugzilla/show_bug.cgi?id=61079
8 years ago
Stefan Bodewig
966708a294
Merge branch '1.9.x'
8 years ago
Stefan Bodewig
7c6c749c95
add magic property that override's tstamp's idea of "now"
https://bz.apache.org/bugzilla/show_bug.cgi?id=61079
8 years ago
Stefan Bodewig
2ec41afdca
test for https://bz.apache.org/bugzilla/show_bug.cgi?id=61042
8 years ago
Stefan Bodewig
9b123a8360
whitespace
8 years ago
Dave Brosius
c5728b3120
allow for java.nio.file.Path based target attributes
8 years ago
Stefan Bodewig
cec95817bb
make bootstrap work on Windows
https://bz.apache.org/bugzilla/show_bug.cgi?id=61027
8 years ago
Stefan Bodewig
e293c7a29c
fix off by one error found by Matt Benson
8 years ago