Matthew Jason Benson
6ce76d1353
Javadoc, LOC
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277829 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
7808487f0a
Typos
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277828 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
0fb6ce69c2
Forgot to commit testcase for doubled EOF char on the new filter-delegated
FixCRLF task. Translated test assertions from Java to Ant.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277825 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
650c0ab0b1
Stop being so optimistic; move isDeeper() to 1.7
Add @return to contentsExcluded javadoc
Remove unnecessary File.separator from endsWith comparison in contentsExcluded
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277817 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
7ad3a99169
static final variables:
csScanOnly -> CS_SCAN_ONLY, csThenNonCs -> CS_THEN_NON_CS
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277816 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
a62c18b465
Reuse boolean[] instances for case-sensitivity iterations when scanning;
reverse logic for better clarity of intent with these arrays.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277815 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
9b1699347c
Move DirectoryScanner.getScannedDirs() to package-private access;
add DirectoryScannerTest to tests.and.ant.share.classloader tests.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277814 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Steve Loughran
45088ad68e
javadocs
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277813 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Steve Loughran
b1f75a400d
First fix the tests to fail when they should, then fix rmic to work as before, even on Java1.5, then add new tests to explicitly do version checks.
bug "rmic always compiles on Java1.5"
http://issues.apache.org/bugzilla/show_bug.cgi?id=33862
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277811 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Steve Loughran
34e8714938
deal with javac1.5 whinings
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277810 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Steve Loughran
7d0746c62f
Fixing apt with correct method name, some more javadocs.
http://issues.apache.org/bugzilla/show_bug.cgi?id=33853
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277805 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Peter Reilly
ab318cb447
yuck, tabs
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277801 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Peter Reilly
03c4f14818
add verbose attribute to <subant> task
PR: 33787
Obtained from: Craig Ryan, Frank Somers
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277799 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
dd7d6b246e
By popular demand: Do not scan directories if their contents are excluded.
Changed scannedDirs from a cache to a result and added a gettor method
with a warning in the Javadoc that it was a testing method only.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277795 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
2d1c5924e5
PR: 33770
Improved FTP task to not fail on hidden directories.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277793 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
ab08e2cd25
1. Remove unused private inner class.
2. Fix loop introduced by a seemingly innocent logic change :(
3. Fix bug that caused extra EOFs when input already contained EOF.
4. Make instances constructed with a Reader usable.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277792 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
7721d8606c
Various terseness like I tend to do;
More importantly, fixed Gump failure on Unix (see end of change list).
Dyslexia strikes!
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277789 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
542b708954
Remove empty default constructor;
create the filterchain Vector only once per Object.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277788 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
5061e731c3
1. Add Kevin Greiner's FixCrLfFilter (slightly modified)
2. Adapt FixCRLF the task to use the filter (single set of fixcrlf code)
3. Implement ChainableReader in FixCRLF so that the existing taskdef
will be recognized as a nested element in a filterchain.
PR: 33155
Submitted by: Kevin Greiner
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277787 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
0777fa853a
Eliminate possible NPE; note that previous change
addressed bug 33118 at least partially.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277786 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
015ec69fd1
Add preservelastmodified attribute to fixcrlf.
PR: 25770
Submitted by: Yuji Yamano
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277778 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
8eca06e6fc
updated cright
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277777 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
88b40e16d0
renamed parameters to avoid hiding,
reduced visibility of member methods of inner class
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277776 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
99903f49b5
reduced visibility of the members not defined in super class of a private inner class
removed unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277775 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
0ba9db2412
Renamed parameter to avoid hidden member variable
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277774 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
2584f8e894
Removed unused local variables (after verification for documented side effects)
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277773 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
f73df08f5b
added getColumnNumber as all other fields that are set can also be get, apart from the column.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277772 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
1f41dffdf2
Removed unused import
Documented empty block
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277771 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
6005d26265
Removed unecessary cast,
Removed caught Throwable while Exception was expected
Documented empty blocks
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277770 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
7411f2b4a4
Stop scanning directories where we match the directory but know based
on the pattern that we will never match any of its contents.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277767 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
81197f555a
Get with usetimestamp did not work when local timestamp roughly >= now.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277761 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
33f3479056
Simplify some file resolution code to rely on FileUtils.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277760 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
4c83562c6c
On DOS and Netware, filenames beginning with a drive letter
and followed by a colon but with no directory separator following
the colon are no longer (incorrectly) accepted as absolute pathnames
by FileUtils.normalize() and FileUtils.isAbsolutePath(). Netware
volumes can still be specified without an intervening separator.
UNC pathnames on Windows must include a server and share name, i.e.
"\\a\b" to be considered valid absolute paths.
FileUtils.resolveFile() promised to return absolute files but
did not always do so.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277759 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
172370143a
Disable test that can't run under Windows Java 1.2 . Should check 1.3 as well.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277757 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
650416f089
Looks like the right thing to do:
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277756 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
c61a7be25d
New diagnostics broke CaseTest.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277755 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
71f620bcdb
Clean up spacing, remove erroneously inserted "not".
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277754 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
86365f103e
Some space/punctuation cleanup. Like it, Steve.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277752 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
211ecc736e
Copyright police
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277751 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Steve Loughran
b0003afe36
complete rework of reporting when we cant instantiate an element
old: generic error message
new: step by step diagnostics with instructions.
The code treats ant tasks and ant optional tasks specially, based on package names.
Also: moved some constants into the appropriate places.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277750 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Steve Loughran
1296855c2f
update to java1.5 docs, to show we are still 100% correct.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277749 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Peter Reilly
ab3f805895
NPE when adding comment to zip file that is not there
PR: 33779
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277746 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
cbeaa439d9
renamed hidden variables
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277744 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Jacobus Martinus Kruithof
782bc21332
RedirectorElementTest stopped working on windows w/h cat on the path.
Now it passes the testcase if cat is not available.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277743 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
80d6afd555
Year
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277741 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Matthew Jason Benson
43cb5f9b25
get with usetimestamp did not work on Java 1.2 .
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277740 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Stefan Bodewig
fc96c7e44a
cleanup
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277738 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Stefan Bodewig
9c0047961d
I don't see the debug output in the Kaffe Gump run, try it unconditionally
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277737 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Steve Loughran
6c13bc7130
condition to check for parser features. Left to others to put into Ant's build.xml.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277735 13f79535-47bb-0310-9956-ffa450edef68
21 years ago
Stefan Bodewig
323c0a1252
fix name-hiding and style by Kev Jackson
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@277734 13f79535-47bb-0310-9956-ffa450edef68
21 years ago