From f8e0dcd65a5263ffe666a7446763c5caa8aa009b Mon Sep 17 00:00:00 2001
From: Steve Loughran <stevel@apache.org>
Date: Mon, 1 Mar 2010 16:33:47 +0000
Subject: [PATCH] Bug 48833 -  NPE in <get>

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@917574 13f79535-47bb-0310-9956-ffa450edef68
---
 WHATSNEW                                        | 3 +++
 src/main/org/apache/tools/ant/taskdefs/Get.java | 7 ++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/WHATSNEW b/WHATSNEW
index a95ba0122..1886d2210 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -44,6 +44,9 @@ Fixed bugs:
 *  If <concat>'s first resourcecollection child is a <resources>,
    any subsequently added child resourcecollection joins the first.
    Bugzilla Report 48816.        
+   
+*  <get> with an invalid URL could trigger an NPE in some JVMs.
+   Bugzilla Report 48833 
 
 Other changes:
 --------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/Get.java b/src/main/org/apache/tools/ant/taskdefs/Get.java
index fa3a8c87e..3906e88df 100644
--- a/src/main/org/apache/tools/ant/taskdefs/Get.java
+++ b/src/main/org/apache/tools/ant/taskdefs/Get.java
@@ -658,7 +658,12 @@ public class Get extends Task {
                         .setUseCaches(httpUseCaches);
             }
             // connect to the remote site (may take some time)
-            connection.connect();
+            try {
+                connection.connect();
+            } catch (NullPointerException e) {
+                //bad URLs can trigger NPEs in some JVMs
+                throw new BuildException("Failed to parse " + source.toString(), e);
+            }
 
             // First check on a 301 / 302 (moved) response (HTTP only)
             if (connection instanceof HttpURLConnection) {