Various cleanups

1) Nomenclature: nested elements, not nested properties
2) Run task instead of
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@267732 13f79535-47bb-0310-9956-ffa450edef68

src/main/org/apache/tools/ant/Project.java

@@ -430,12 +430,12 @@ public class Project {
         Vector sortedTargets = topoSort(targetName, targets);
 
         int curidx = 0;
-        String curtarget;
+        Target curtarget;
 
         do {
-            curtarget = (String) sortedTargets.elementAt(curidx++);
-            runTarget(curtarget, targets);
-        } while (!curtarget.equals(targetName));
+            curtarget = (Target) sortedTargets.elementAt(curidx++);
+            runTarget(curtarget);
+        } while (!curtarget.getName().equals(targetName));
     }
 
     public File resolveFile(String fileName) {
@@ -679,14 +679,10 @@ public class Project {
     // Given a string defining a target name, and a Hashtable
     // containing the "name to Target" mapping, pick out the
     // Target and execute it.
-    private final void runTarget(String target, Hashtable targets)
+    public void runTarget(Target target)
         throws BuildException {
 
-        currentTarget = (Target)targets.get(target);
-        if (currentTarget == null) {
-            throw new RuntimeException("Unexpected missing target `"+target+
-                                       "' in this project.");
-        }
+        currentTarget = target;
 
         try {
             fireTargetStarted();
@@ -803,7 +799,7 @@ public class Project {
             throw new RuntimeException("Unexpected internal error: expected to pop "+root+" but got "+p);
         }
         state.put(root, VISITED);
-        ret.addElement(root);
+        ret.addElement(target);
     }
 
     private static BuildException makeCircularException(String end, Stack stk) {

src/main/org/apache/tools/ant/ProjectHelper.java

@@ -327,9 +327,11 @@ public class ProjectHelper {
 
         public void init(String tag, AttributeList attrs) throws SAXParseException {
             task = project.createTask(tag);
+            project.currentTask = task;
             configure(task, attrs);
             task.setLocation(new Location(buildFile.toString(), locator.getLineNumber(), locator.getColumnNumber()));
             task.init();
+            project.currentTask = null;
 
             // Top level tasks don't have associated targets
             if (target != null) {
@@ -355,20 +357,20 @@ public class ProjectHelper {
         }
 
         public void startElement(String name, AttributeList attrs) throws SAXParseException {
-            new NestedPropertyHandler(this, task).init(name, attrs);
+            new NestedElementHandler(this, task).init(name, attrs);
         }
     }
 
     /**
      * Handler for all nested properties.
      */
-    private class NestedPropertyHandler extends AbstractHandler {
+    private class NestedElementHandler extends AbstractHandler {
         private DocumentHandler parentHandler;
 
         private Object target;
         private Object child;
 
-        public NestedPropertyHandler(DocumentHandler parentHandler, Object target) {
+        public NestedElementHandler(DocumentHandler parentHandler, Object target) {
             super(parentHandler);
 
             this.target = target;
@@ -393,7 +395,7 @@ public class ProjectHelper {
         }
 
         public void startElement(String name, AttributeList attrs) throws SAXParseException {
-            new NestedPropertyHandler(this, child).init(name, attrs);
+            new NestedElementHandler(this, child).init(name, attrs);
         }
     }