Browse Source

Merge branch '1.9.x'

master
Stefan Bodewig 7 years ago
parent
commit
f59ad6edc9
2 changed files with 4 additions and 7 deletions
  1. +1
    -5
      src/main/org/apache/tools/ant/taskdefs/VerifyJar.java
  2. +3
    -2
      src/tests/antunit/taskdefs/signjar-test.xml

+ 1
- 5
src/main/org/apache/tools/ant/taskdefs/VerifyJar.java View File

@@ -118,7 +118,7 @@ public class VerifyJar extends AbstractJarSignerTask {
// So if strict is true then we hide storepass from the base // So if strict is true then we hide storepass from the base
// implementation and instead add the -storepass command line // implementation and instead add the -storepass command line
// argument // argument
if (mustHideStorePass()) {
if (storepass != null) {
savedStorePass = storepass; savedStorePass = storepass;
setStorepass(null); setStorepass(null);
} }
@@ -193,10 +193,6 @@ public class VerifyJar extends AbstractJarSignerTask {
} }
} }


private boolean mustHideStorePass() {
return strict && storepass != null;
}

/** /**
* we are not thread safe here. Do not use on multiple threads at the same time. * we are not thread safe here. Do not use on multiple threads at the same time.
*/ */


+ 3
- 2
src/tests/antunit/taskdefs/signjar-test.xml View File

@@ -68,7 +68,7 @@
<sign /> <sign />
</target> </target>


<target name="basic-pkcs12" depends="jar" unless="jdk9+">
<target name="basic-pkcs12" depends="jar" unless="jdk9+" if="jdk1.7+">
<sign keystore="${testkeystore.pkcs12}" storetype="pkcs12" strict="true"/> <sign keystore="${testkeystore.pkcs12}" storetype="pkcs12" strict="true"/>
</target> </target>


@@ -244,7 +244,8 @@
<verify-base jar="${signtest.jar}" /> <verify-base jar="${signtest.jar}" />
</target> </target>


<target name="testVerifyJarPKCS12" depends="basic-pkcs12" unless="jdk9+">
<target name="testVerifyJarPKCS12" depends="basic-pkcs12"
unless="jdk9+" if="jdk1.7+">
<verify-base-pkcs12 jar="${signtest.jar}" /> <verify-base-pkcs12 jar="${signtest.jar}" />
</target> </target>




Loading…
Cancel
Save