From f15c3de41b09131e1a7967911c8f1088700b6578 Mon Sep 17 00:00:00 2001 From: Vladislav Bauer Date: Mon, 30 Nov 2015 03:06:21 +0600 Subject: [PATCH] Prevent string concatenations as argument to "StringBuffer.append()" --- src/main/org/apache/tools/ant/Main.java | 2 +- src/main/org/apache/tools/ant/Project.java | 2 +- .../ant/taskdefs/optional/depend/constantpool/ConstantPool.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/org/apache/tools/ant/Main.java b/src/main/org/apache/tools/ant/Main.java index a9c23a53a..85aaa28d7 100644 --- a/src/main/org/apache/tools/ant/Main.java +++ b/src/main/org/apache/tools/ant/Main.java @@ -1287,7 +1287,7 @@ public class Main implements AntMain { spaces += spaces; } final StringBuilder msg = new StringBuilder(); - msg.append(heading + lSep + lSep); + msg.append(heading).append(lSep).append(lSep); final int size = names.size(); for (int i = 0; i < size; i++) { msg.append(" "); diff --git a/src/main/org/apache/tools/ant/Project.java b/src/main/org/apache/tools/ant/Project.java index 3a0c4b824..e9160024f 100644 --- a/src/main/org/apache/tools/ant/Project.java +++ b/src/main/org/apache/tools/ant/Project.java @@ -1845,7 +1845,7 @@ public class Project implements ResourceFactory { for (int j = 0; j < root.length; j++) { buf.append((j == 0) ? " `" : ", `").append(root[j]).append('\''); } - buf.append(" is " + ret); + buf.append(" is ").append(ret); log(buf.toString(), MSG_VERBOSE); final Vector complete = (returnAll) ? ret : new Vector(ret); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPool.java b/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPool.java index 67d366b8f..9bec0ed32 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPool.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPool.java @@ -348,7 +348,7 @@ public class ConstantPool { final int size = entries.size(); for (int i = 0; i < size; ++i) { - sb.append("[" + i + "] = " + getEntry(i) + "\n"); + sb.append('[').append(i).append("] = ").append(getEntry(i)).append('\n'); } return sb.toString();