Browse Source

Bug #50866:

- the prefix was not propagated to imported resources within included resources.


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1079580 13f79535-47bb-0310-9956-ffa450edef68
master
Nicolas Lalevee 14 years ago
parent
commit
edaa68e6de
5 changed files with 37 additions and 1 deletions
  1. +4
    -0
      WHATSNEW
  2. +5
    -1
      src/main/org/apache/tools/ant/taskdefs/ImportTask.java
  3. +13
    -0
      src/tests/antunit/bugfixes/br50866/br50866-test.xml
  4. +8
    -0
      src/tests/antunit/bugfixes/br50866/common.xml
  5. +7
    -0
      src/tests/antunit/bugfixes/br50866/middle.xml

+ 4
- 0
WHATSNEW View File

@@ -25,6 +25,10 @@ Fixed bugs:
setting a proxy caused problems with other Java libraries.
Bugzilla Report 50888.

* Include task breaks dependencies or extension-points for multiple
files.
Bugzilla Report 50866.

Other changes:
--------------



+ 5
- 1
src/main/org/apache/tools/ant/taskdefs/ImportTask.java View File

@@ -206,10 +206,14 @@ public class ImportTask extends Task {
boolean oldIncludeMode = ProjectHelper.isInIncludeMode();
String oldSep = ProjectHelper.getCurrentPrefixSeparator();
try {
String prefix = targetPrefix;
String prefix;
if (isInIncludeMode() && oldPrefix != null
&& targetPrefix != null) {
prefix = oldPrefix + oldSep + targetPrefix;
} else if (targetPrefix != null) {
prefix = targetPrefix;
} else {
prefix = oldPrefix;
}
setProjectHelperProps(prefix, prefixSeparator,
isInIncludeMode());


+ 13
- 0
src/tests/antunit/bugfixes/br50866/br50866-test.xml View File

@@ -0,0 +1,13 @@
<project name="br50866" default="antunit" xmlns:au="antlib:org.apache.ant.antunit">

<import file="../../antunit-base.xml" />

<include file="middle.xml" />

<target name="testinclude" depends="middle.common,middle.middle">
<au:assertPropertyEquals name="prop-common-init" value="br50866"/>
<au:assertPropertyEquals name="prop-common" value="br50866"/>
<au:assertPropertyEquals name="prop-middle" value="br50866"/>
</target>

</project>

+ 8
- 0
src/tests/antunit/bugfixes/br50866/common.xml View File

@@ -0,0 +1,8 @@
<project name="common" default="default">
<target name="common-init">
<property name="prop-common-init" value="br50866" />
</target>
<target name="common" depends="common-init">
<property name="prop-common" value="br50866" />
</target>
</project>

+ 7
- 0
src/tests/antunit/bugfixes/br50866/middle.xml View File

@@ -0,0 +1,7 @@
<project name="middle" default="default">
<import file="common.xml" optional="true" />

<target name="middle" depends="common-init">
<property name="prop-middle" value="br50866" />
</target>
</project>

Loading…
Cancel
Save