diff --git a/WHATSNEW b/WHATSNEW index 42a2952f5..1d18d3d66 100644 --- a/WHATSNEW +++ b/WHATSNEW @@ -98,8 +98,6 @@ Changes that could break older environments: been modified to encode outgoing (InputStream) content as well as encoding incoming (OutputStream) content. -* now prefers evaluation result/return value over value property. - * with fork now returns gives -1 instead of 0 as result when failonerror is false and some exception (including timeout) occurs. Br 42377. diff --git a/src/main/org/apache/tools/ant/types/optional/AbstractScriptComponent.java b/src/main/org/apache/tools/ant/types/optional/AbstractScriptComponent.java index 3c9bd441d..025a57ea8 100644 --- a/src/main/org/apache/tools/ant/types/optional/AbstractScriptComponent.java +++ b/src/main/org/apache/tools/ant/types/optional/AbstractScriptComponent.java @@ -17,8 +17,6 @@ */ package org.apache.tools.ant.types.optional; -import java.io.File; - import org.apache.tools.ant.Project; import org.apache.tools.ant.ProjectComponent; import org.apache.tools.ant.types.Path; @@ -26,6 +24,9 @@ import org.apache.tools.ant.types.Reference; import org.apache.tools.ant.util.ScriptRunnerBase; import org.apache.tools.ant.util.ScriptRunnerHelper; + +import java.io.File; + /** * This is a {@link ProjectComponent} that has script support built in * Use it as a foundation for scriptable things. @@ -140,13 +141,4 @@ public abstract class AbstractScriptComponent extends ProjectComponent { protected void executeScript(String execName) { getRunner().executeScript(execName); } - - /** - * Evaluate a script. - * @param execName name of the script. - * @return the result of the evaluation. - */ - protected Object evaluateScript(String execName) { - return getRunner().evaluateScript(execName); - } } diff --git a/src/main/org/apache/tools/ant/types/optional/ScriptCondition.java b/src/main/org/apache/tools/ant/types/optional/ScriptCondition.java index d5d3ce7d8..e22cfa400 100644 --- a/src/main/org/apache/tools/ant/types/optional/ScriptCondition.java +++ b/src/main/org/apache/tools/ant/types/optional/ScriptCondition.java @@ -43,8 +43,8 @@ public class ScriptCondition extends AbstractScriptComponent implements Conditio */ public boolean eval() throws BuildException { initScriptRunner(); - Object result = evaluateScript("ant_condition"); - return result instanceof Boolean ? ((Boolean) result).booleanValue() : getValue(); + Object result = executeScript("ant_condition"); + return getValue(); } /** diff --git a/src/tests/antunit/types/scriptcondition-test.xml b/src/tests/antunit/types/scriptcondition-test.xml deleted file mode 100644 index 04578b5bf..000000000 --- a/src/tests/antunit/types/scriptcondition-test.xml +++ /dev/null @@ -1,181 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - self.setValue(true); - - - - - - - - - - - - - - - - - - - - - - self.setValue(true); - - - - - - - - self.setValue(false); - - - - - - - - return true; - - - - - - - - return false; - - - - - - - - self.setValue(true); - return false; - - - - - - - - return null; - - - - - - - - return 20; - - - - - - - - java.lang.Boolean.TRUE - - - - - - - - java.lang.Boolean.FALSE - - - - - - - - self.setValue(true); - false - - - - - - - - null - - - - - - - - new java.lang.Integer(20) - - - - -