Browse Source

Sonar falsely claims expressions to be constant

master
Stefan Bodewig 8 years ago
parent
commit
eaf3af0aea
5 changed files with 5 additions and 5 deletions
  1. +1
    -1
      src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java
  2. +1
    -1
      src/main/org/apache/tools/ant/taskdefs/StreamPumper.java
  3. +1
    -1
      src/main/org/apache/tools/ant/taskdefs/optional/net/RExecTask.java
  4. +1
    -1
      src/main/org/apache/tools/ant/taskdefs/optional/net/TelnetTask.java
  5. +1
    -1
      src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java

+ 1
- 1
src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java View File

@@ -84,7 +84,7 @@ public class ArgumentProcessorRegistry {
} }


InputStream systemResource = ClassLoader.getSystemResourceAsStream(SERVICE_ID); InputStream systemResource = ClassLoader.getSystemResourceAsStream(SERVICE_ID);
if (systemResource != null) {
if (systemResource != null) { //NOSONAR
ArgumentProcessor processor = getProcessorByService(systemResource); ArgumentProcessor processor = getProcessorByService(systemResource);
registerArgumentProcessor(processor); registerArgumentProcessor(processor);
} }


+ 1
- 1
src/main/org/apache/tools/ant/taskdefs/StreamPumper.java View File

@@ -137,7 +137,7 @@ public class StreamPumper implements Runnable {
if (autoflush) { if (autoflush) {
os.flush(); os.flush();
} }
if (finish) {
if (finish) { //NOSONAR
break; break;
} }
} }


+ 1
- 1
src/main/org/apache/tools/ant/taskdefs/optional/net/RExecTask.java View File

@@ -362,7 +362,7 @@ public class RExecTask extends Task {
} catch (IOException e) { } catch (IOException e) {
throw new BuildException("Can't connect to " + server); throw new BuildException("Can't connect to " + server);
} }
if (userid != null && password != null && command != null
if (userid != null && password != null && command != null //NOSONAR
&& rexecTasks.size() == 0) { && rexecTasks.size() == 0) {
// simple one-shot execution // simple one-shot execution
rexec.rexec(userid, password, command); rexec.rexec(userid, password, command);


+ 1
- 1
src/main/org/apache/tools/ant/taskdefs/optional/net/TelnetTask.java View File

@@ -107,7 +107,7 @@ public class TelnetTask extends Task {
throw new BuildException("Can't connect to " + server); throw new BuildException("Can't connect to " + server);
} }
/** Login if userid and password were specified */ /** Login if userid and password were specified */
if (userid != null && password != null) {
if (userid != null && password != null) { //NOSONAR
login(telnet); login(telnet);
} }
/** Process each sub command */ /** Process each sub command */


+ 1
- 1
src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java View File

@@ -267,7 +267,7 @@ public class Scp extends SSHBase {
} else { } else {
upload(fromUri, toUri); upload(fromUri, toUri);
} }
} else if (isFromRemote && isToRemote) {
} else if (isFromRemote && isToRemote) { //NOSONAR
throw new BuildException( throw new BuildException(
"Copying from a remote server to a remote server is not supported."); "Copying from a remote server to a remote server is not supported.");
} else { } else {


Loading…
Cancel
Save