From ea6cf7be53343f4b59c9fb8e794c58d83eb11315 Mon Sep 17 00:00:00 2001 From: Peter Reilly Date: Sat, 18 Nov 2006 18:11:27 +0000 Subject: [PATCH] checkstyle git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@476579 13f79535-47bb-0310-9956-ffa450edef68 --- .../ant/taskdefs/compilers/AptExternalCompilerAdapter.java | 2 ++ src/main/org/apache/tools/ant/taskdefs/compilers/Javac12.java | 1 - src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java | 3 ++- src/main/org/apache/tools/ant/taskdefs/compilers/Sj.java | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/main/org/apache/tools/ant/taskdefs/compilers/AptExternalCompilerAdapter.java b/src/main/org/apache/tools/ant/taskdefs/compilers/AptExternalCompilerAdapter.java index 2285993e8..dadb55ba9 100644 --- a/src/main/org/apache/tools/ant/taskdefs/compilers/AptExternalCompilerAdapter.java +++ b/src/main/org/apache/tools/ant/taskdefs/compilers/AptExternalCompilerAdapter.java @@ -43,6 +43,8 @@ public class AptExternalCompilerAdapter extends DefaultCompilerAdapter { /** * Performs a compile using the Javac externally. + * @return true the compilation was successful. + * @throws BuildException if there is a problem. */ public boolean execute() throws BuildException { attributes.log("Using external apt compiler", Project.MSG_VERBOSE); diff --git a/src/main/org/apache/tools/ant/taskdefs/compilers/Javac12.java b/src/main/org/apache/tools/ant/taskdefs/compilers/Javac12.java index 3c05e76dc..290fe709b 100644 --- a/src/main/org/apache/tools/ant/taskdefs/compilers/Javac12.java +++ b/src/main/org/apache/tools/ant/taskdefs/compilers/Javac12.java @@ -18,7 +18,6 @@ package org.apache.tools.ant.taskdefs.compilers; -import java.io.IOException; import java.io.OutputStream; import java.lang.reflect.Constructor; import java.lang.reflect.Method; diff --git a/src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java b/src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java index 17e23bc31..199fac565 100644 --- a/src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java +++ b/src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java @@ -166,7 +166,8 @@ public class Jikes extends DefaultCompilerAdapter { if (!Project.toBoolean(warningsProperty)) { cmd.createArgument().setValue("-nowarn"); } - } if (attributes.getNowarn()) { + } + if (attributes.getNowarn()) { cmd.createArgument().setValue("-nowarn"); } diff --git a/src/main/org/apache/tools/ant/taskdefs/compilers/Sj.java b/src/main/org/apache/tools/ant/taskdefs/compilers/Sj.java index b7c2a6eb1..0dcc0e4c5 100644 --- a/src/main/org/apache/tools/ant/taskdefs/compilers/Sj.java +++ b/src/main/org/apache/tools/ant/taskdefs/compilers/Sj.java @@ -51,7 +51,7 @@ public class Sj extends DefaultCompilerAdapter { /** * Returns null since sj either has -g for debug=true or no * argument at all. - * + * @return null. * @since Ant 1.6.3 */ protected String getNoDebugArgument() {