From e6d08dfeb295a0de6aa05a599fe5b0580e7f2df9 Mon Sep 17 00:00:00 2001
From: Stefan Bodewig <bodewig@apache.org>
Date: Mon, 7 Jan 2002 17:06:28 +0000
Subject: [PATCH] Skip SQLExecTest if the testcase and the <sql> implementation
 would be loaded by different classloaders.

package private access is only allowed if the classes belong to the
same "runtime package", which is the fully qualified package name plus
the defining classloader.  Enough reading of JLS and VMSPEC for me for
today 8-)

We probably could code around the problem by placing a subclass of
SQLExec into the same classloader as SQLExecTest and invoke methods on
this subclass.


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@270618 13f79535-47bb-0310-9956-ffa450edef68
---
 build.xml | 31 +++++++++++++++++++++++--------
 1 file changed, 23 insertions(+), 8 deletions(-)

diff --git a/build.xml b/build.xml
index 6a07d61a5..ed3b3c236 100644
--- a/build.xml
+++ b/build.xml
@@ -207,6 +207,13 @@
         <isset property="jdk1.2+" />
       </and>
     </condition>
+
+    <condition property="run.sqlexec.test">
+      <or>
+        <equals arg1="${junit.fork}" arg2="true" />
+        <equals arg1="${build.sysclasspath}" arg2="only" />
+      </or>
+    </condition>
   </target>
 
   <!--
@@ -885,16 +892,20 @@
           <exclude name="${optional.package}/sitraka/*.java" unless="jakarta.oro.present" />
           <exclude name="${optional.package}/ReplaceRegExpTest.java"
                    unless="some.regexp.support" />
-
-          <!-- it's an abstract class, not a test -->
-          <exclude name="org/apache/tools/ant/taskdefs/optional/AbstractXSLTLiaisonTest.java" />
-          <exclude name="org/apache/tools/ant/taskdefs/optional/XslpLiaisonTest.java" unless="xslp.present"/>
-          <exclude name="org/apache/tools/ant/taskdefs/optional/XalanLiaisonTest.java" unless="xalan.present"/>
+          <exclude name="org/apache/tools/ant/taskdefs/optional/XslpLiaisonTest.java" 
+                   unless="xslp.present"/>
+          <exclude name="org/apache/tools/ant/taskdefs/optional/XalanLiaisonTest.java" 
+                   unless="xalan.present"/>
 
           <exclude name="org/apache/tools/ant/taskdefs/optional/AdaptxLiaisonTest.java"
                    unless="adaptx.present"/>
           <exclude name="org/apache/tools/ant/taskdefs/optional/AdaptxLiaisonTest.java"
                    unless="xerces.present"/>
+          <exclude name="${optional.package}/perforce/*.java"
+                   unless="jakarta.oro.present" />
+
+          <!-- it's an abstract class, not a test -->
+          <exclude name="org/apache/tools/ant/taskdefs/optional/AbstractXSLTLiaisonTest.java" />
 
           <!-- ehm, this is not really a TraX test but rather a xalan2 test..-->
           <exclude name="org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java" unless="xalan2.present"/>
@@ -905,11 +916,15 @@
           <exclude name="${optional.package}/junit/JUnitTestRunnerTest.java"
                    unless="jdk1.2+" />
 
-          <exclude name="${optional.package}/perforce/*.java"
-                   unless="jakarta.oro.present" />
-
           <!-- interactive test -->
           <exclude name="org/apache/tools/ant/taskdefs/TestProcess.java" />
+
+          <!--  This test only passes if SQLExecTest and SQLExec have
+          been loaded by the same classloader - will throw
+          IllegalAccessExceptions otherwise.  -->
+          <exclude name="org/apache/tools/ant/taskdefs/SQLExecTest.java"
+                   unless="run.sqlexec.test" />
+
         </fileset>
       </batchtest>