No need to setup a Logger for Execute.

All logging will be routed via System.err or System.out as appropriate


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271261 13f79535-47bb-0310-9956-ffa450edef68

proposal/myrmidon/src/java/org/apache/antlib/cvslib/Cvs.java

@@ -150,7 +150,6 @@ public class Cvs
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         if( m_dest == null )
         {
             m_dest = getBaseDirectory();

proposal/myrmidon/src/java/org/apache/antlib/nativelib/Exec.java

@@ -174,7 +174,6 @@ public class Exec
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         exe.setTimeout( m_timeout );
         exe.setWorkingDirectory( m_dir );
         exe.setNewenvironment( m_newEnvironment );

proposal/myrmidon/src/java/org/apache/antlib/security/SignJar.java

@@ -297,7 +297,6 @@ public class SignJar
         final Commandline cmd = buildCommand( jarTarget, jarSource );
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         exe.setCommandline( cmd );
         try
         {

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Java.java

@@ -220,7 +220,6 @@ public class Java
     {
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
 
         if( m_dir == null )
         {

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java

@@ -363,7 +363,6 @@ public abstract class DefaultCompilerAdapter
             {
                 final ExecManager execManager = (ExecManager)m_attributes.getService( ExecManager.class );
                 final Execute2 exe = new Execute2( execManager );
-                setupLogger( exe );
                 exe.setWorkingDirectory( m_baseDir );
                 final String[] commandline = commandArray;
                 exe.setCommandline( new Commandline( commandline ) );

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc/Javadoc.java

@@ -816,7 +816,6 @@ public class Javadoc
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         exe.setExecOutputHandler( this );
 
         /*

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ANTLR.java

@@ -229,8 +229,6 @@ public class ANTLR extends Task
     {
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
-
         if( workingdir != null )
         {
             exe.setWorkingDirectory( workingdir );
@@ -257,7 +255,6 @@ public class ANTLR extends Task
         // if no output directory is specified, used the target's directory
         if( outputDirectory == null )
         {
-            String fileName = target.toString();
             setOutputdirectory( new File( target.getParent() ) );
         }
         if( !outputDirectory.isDirectory() )

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java

@@ -137,7 +137,6 @@ public class Cab
                 File listFile = createListFile( files );
                 final ExecManager execManager = (ExecManager)getService( ExecManager.class );
                 Execute2 exe = new Execute2( execManager );
-                setupLogger( exe );
                 exe.setWorkingDirectory( m_baseDir );
                 final Commandline cmd = createCommand( listFile );
                 exe.setCommandline( cmd );

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java

@@ -114,7 +114,6 @@ public abstract class Continuus
         {
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             if( null != handler )
             {
                 exe.setExecOutputHandler( handler );

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/ClearCase.java

@@ -110,7 +110,6 @@ public abstract class ClearCase extends Task
         {
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             exe.setWorkingDirectory( getBaseDirectory() );
             exe.setCommandline( cmd );
             return exe.execute();

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java

@@ -202,7 +202,6 @@ public class NetCommand
         File dir = _owner.getBaseDirectory();
         final ExecManager execManager = (ExecManager)_owner.getService( ExecManager.class );
         _exe = new Execute2( execManager );
-        setupLogger( _exe );
         _exe.setWorkingDirectory( dir );
     }
 }

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ejb/BorlandGenerateClient.java

@@ -163,7 +163,6 @@ public class BorlandGenerateClient extends Task
 
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             exe.setWorkingDirectory( new File( "." ) );
             exe.setCommandline( cmd );
             exe.execute();

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/javacc/JJTree.java

@@ -183,8 +183,6 @@ public class JJTree extends Task
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
-
         getLogger().debug( cmdl.toString() );
         exe.setCommandline( new Commandline( cmdl.getCommandline() ) );
 

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/javacc/JavaCC.java

@@ -244,7 +244,6 @@ public class JavaCC extends Task
             getLogger().debug( cmdline.toString() );
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             final String[] commandline = cmdline.getCommandline();
             exe.setCommandline( new Commandline( commandline ) );
             int retval = exe.execute();

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java

@@ -242,7 +242,6 @@ public class JDependTask
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
 
         final String[] commandline1 = commandline.getCommandline();
         exe.setCommandline( new Commandline( commandline1 ) );

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java

@@ -651,7 +651,6 @@ public class JUnitTask extends Task
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         exe.setCommandline( new Commandline( cmd.getCommandline() ) );
         if( dir != null )
         {

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/metamata/AbstractMetamataTask.java

@@ -281,7 +281,6 @@ public abstract class AbstractMetamataTask
     {
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         getLogger().debug( m_cmdl.toString() );
         final String[] commandline = m_cmdl.getCommandline();
         exe.setCommandline( new Commandline( commandline ) );

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/metamata/MParse.java

@@ -289,7 +289,6 @@ public class MParse
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         getLogger().debug( m_cmdl.toString() );
         final String[] commandline = m_cmdl.getCommandline();
         exe.setCommandline( new Commandline( commandline ) );

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java

@@ -193,7 +193,6 @@ public class Pvcs
         {
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             exe.setWorkingDirectory( getBaseDirectory() );
             exe.setCommandline( cmd );
             result = exe.execute();
@@ -275,7 +274,6 @@ public class Pvcs
 
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             exe.setExecOutputHandler( this );
             m_output = new FileOutputStream( tmp );
             exe.setWorkingDirectory( getBaseDirectory() );

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/sitraka/CovMerge.java

@@ -117,7 +117,6 @@ public class CovMerge extends Task
 
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             getLogger().debug( cmdl.toString() );
             exe.setCommandline( cmdl );
 

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/sitraka/CovReport.java

@@ -249,7 +249,6 @@ public class CovReport extends Task
             // use the custom handler for stdin issues
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             getLogger().debug( cmdl.toString() );
             exe.setCommandline( cmdl );
             int exitValue = exe.execute();

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/sitraka/Coverage.java

@@ -199,8 +199,6 @@ public class Coverage
 
     /**
      * the jvm arguments
-     *
-     * @return Description of the Returned Value
      */
     public void addJvmarg( final Argument argument )
     {
@@ -253,7 +251,6 @@ public class Coverage
             // use the custom handler for stdin issues
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             getLogger().debug( cmdl.toString() );
             exe.setCommandline( cmdl );
             int exitValue = exe.execute();

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java

@@ -207,7 +207,6 @@ public abstract class MSVSS extends Task
         {
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
 
             // If location of ss.ini is specified we need to set the
             // environment-variable SSDIR to this value

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/unix/Rpm.java

@@ -92,7 +92,6 @@ public class Rpm
         final Commandline cmd = createCommand();
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
 
         if( m_topDir == null )
         {

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Java.java

@@ -220,7 +220,6 @@ public class Java
     {
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
 
         if( m_dir == null )
         {

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java

@@ -363,7 +363,6 @@ public abstract class DefaultCompilerAdapter
             {
                 final ExecManager execManager = (ExecManager)m_attributes.getService( ExecManager.class );
                 final Execute2 exe = new Execute2( execManager );
-                setupLogger( exe );
                 exe.setWorkingDirectory( m_baseDir );
                 final String[] commandline = commandArray;
                 exe.setCommandline( new Commandline( commandline ) );

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc/Javadoc.java

@@ -816,7 +816,6 @@ public class Javadoc
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         exe.setExecOutputHandler( this );
 
         /*

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ANTLR.java

@@ -229,8 +229,6 @@ public class ANTLR extends Task
     {
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
-
         if( workingdir != null )
         {
             exe.setWorkingDirectory( workingdir );
@@ -257,7 +255,6 @@ public class ANTLR extends Task
         // if no output directory is specified, used the target's directory
         if( outputDirectory == null )
         {
-            String fileName = target.toString();
             setOutputdirectory( new File( target.getParent() ) );
         }
         if( !outputDirectory.isDirectory() )

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/Cab.java

@@ -137,7 +137,6 @@ public class Cab
                 File listFile = createListFile( files );
                 final ExecManager execManager = (ExecManager)getService( ExecManager.class );
                 Execute2 exe = new Execute2( execManager );
-                setupLogger( exe );
                 exe.setWorkingDirectory( m_baseDir );
                 final Commandline cmd = createCommand( listFile );
                 exe.setCommandline( cmd );

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java

@@ -114,7 +114,6 @@ public abstract class Continuus
         {
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             if( null != handler )
             {
                 exe.setExecOutputHandler( handler );

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/clearcase/ClearCase.java

@@ -110,7 +110,6 @@ public abstract class ClearCase extends Task
         {
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             exe.setWorkingDirectory( getBaseDirectory() );
             exe.setCommandline( cmd );
             return exe.execute();

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java

@@ -202,7 +202,6 @@ public class NetCommand
         File dir = _owner.getBaseDirectory();
         final ExecManager execManager = (ExecManager)_owner.getService( ExecManager.class );
         _exe = new Execute2( execManager );
-        setupLogger( _exe );
         _exe.setWorkingDirectory( dir );
     }
 }

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ejb/BorlandGenerateClient.java

@@ -163,7 +163,6 @@ public class BorlandGenerateClient extends Task
 
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             exe.setWorkingDirectory( new File( "." ) );
             exe.setCommandline( cmd );
             exe.execute();

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/javacc/JJTree.java

@@ -183,8 +183,6 @@ public class JJTree extends Task
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
-
         getLogger().debug( cmdl.toString() );
         exe.setCommandline( new Commandline( cmdl.getCommandline() ) );
 

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/javacc/JavaCC.java

@@ -244,7 +244,6 @@ public class JavaCC extends Task
             getLogger().debug( cmdline.toString() );
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             final String[] commandline = cmdline.getCommandline();
             exe.setCommandline( new Commandline( commandline ) );
             int retval = exe.execute();

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java

@@ -242,7 +242,6 @@ public class JDependTask
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
 
         final String[] commandline1 = commandline.getCommandline();
         exe.setCommandline( new Commandline( commandline1 ) );

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java

@@ -651,7 +651,6 @@ public class JUnitTask extends Task
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         exe.setCommandline( new Commandline( cmd.getCommandline() ) );
         if( dir != null )
         {

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/metamata/AbstractMetamataTask.java

@@ -281,7 +281,6 @@ public abstract class AbstractMetamataTask
     {
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         getLogger().debug( m_cmdl.toString() );
         final String[] commandline = m_cmdl.getCommandline();
         exe.setCommandline( new Commandline( commandline ) );

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/metamata/MParse.java

@@ -289,7 +289,6 @@ public class MParse
 
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
         getLogger().debug( m_cmdl.toString() );
         final String[] commandline = m_cmdl.getCommandline();
         exe.setCommandline( new Commandline( commandline ) );

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java

@@ -193,7 +193,6 @@ public class Pvcs
         {
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             exe.setWorkingDirectory( getBaseDirectory() );
             exe.setCommandline( cmd );
             result = exe.execute();
@@ -275,7 +274,6 @@ public class Pvcs
 
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             exe.setExecOutputHandler( this );
             m_output = new FileOutputStream( tmp );
             exe.setWorkingDirectory( getBaseDirectory() );

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/sitraka/CovMerge.java

@@ -117,7 +117,6 @@ public class CovMerge extends Task
 
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             getLogger().debug( cmdl.toString() );
             exe.setCommandline( cmdl );
 

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/sitraka/CovReport.java

@@ -249,7 +249,6 @@ public class CovReport extends Task
             // use the custom handler for stdin issues
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             getLogger().debug( cmdl.toString() );
             exe.setCommandline( cmdl );
             int exitValue = exe.execute();

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/sitraka/Coverage.java

@@ -199,8 +199,6 @@ public class Coverage
 
     /**
      * the jvm arguments
-     *
-     * @return Description of the Returned Value
      */
     public void addJvmarg( final Argument argument )
     {
@@ -253,7 +251,6 @@ public class Coverage
             // use the custom handler for stdin issues
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
             getLogger().debug( cmdl.toString() );
             exe.setCommandline( cmdl );
             int exitValue = exe.execute();

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java

@@ -207,7 +207,6 @@ public abstract class MSVSS extends Task
         {
             final ExecManager execManager = (ExecManager)getService( ExecManager.class );
             final Execute2 exe = new Execute2( execManager );
-            setupLogger( exe );
 
             // If location of ss.ini is specified we need to set the
             // environment-variable SSDIR to this value

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/unix/Rpm.java

@@ -92,7 +92,6 @@ public class Rpm
         final Commandline cmd = createCommand();
         final ExecManager execManager = (ExecManager)getService( ExecManager.class );
         final Execute2 exe = new Execute2( execManager );
-        setupLogger( exe );
 
         if( m_topDir == null )
         {