From ded098d5399315e5cb057bf09a72c2142ad82965 Mon Sep 17 00:00:00 2001 From: Peter Donald Date: Sat, 30 Mar 2002 23:51:33 +0000 Subject: [PATCH] Rename basedir to dir and make it default to basedir if not specified git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@272116 13f79535-47bb-0310-9956-ffa450edef68 --- docs/manual/CoreTasks/changelog.html | 4 ++-- .../ant/taskdefs/cvslib/ChangeLogTask.java | 17 ++++++++--------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/docs/manual/CoreTasks/changelog.html b/docs/manual/CoreTasks/changelog.html index fd4ad9660..fb767dd9d 100644 --- a/docs/manual/CoreTasks/changelog.html +++ b/docs/manual/CoreTasks/changelog.html @@ -19,9 +19,9 @@ Required - basedir + dir the directory from which to run "cvs log". - Yes + No, will default to projects basedir destfile diff --git a/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java b/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java index d9ac62ba2..d2bfe17be 100644 --- a/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java @@ -113,7 +113,7 @@ public class ChangeLogTask private Vector m_cvsUsers = new Vector(); /** Input dir */ - private File m_basedir; + private File m_dir; /** Output file */ private File m_destfile; @@ -138,9 +138,9 @@ public class ChangeLogTask /** * Set the base dir for cvs. */ - public void setBasedir( final File basedir ) + public void setDir( final File dir ) { - m_basedir = basedir; + m_dir = dir; } /** @@ -261,7 +261,7 @@ public class ChangeLogTask final RedirectingStreamHandler handler = new RedirectingStreamHandler( parser ); final Execute exe = new Execute( handler ); - exe.setWorkingDirectory( m_basedir ); + exe.setWorkingDirectory( m_dir ); exe.setCommandline( command.getCommandline() ); exe.setAntRun( getProject() ); try @@ -290,19 +290,18 @@ public class ChangeLogTask private void validate() throws BuildException { - if( null == m_basedir ) + if( null == m_dir ) { - final String message = "Basedir must be set."; - throw new BuildException( message ); + m_dir = getProject().getBaseDir(); } if( null == m_destfile ) { final String message = "Destfile must be set."; throw new BuildException( message ); } - if( !m_basedir.exists() ) + if( !m_dir.exists() ) { - final String message = "Cannot find base dir " + m_basedir.getAbsolutePath(); + final String message = "Cannot find base dir " + m_dir.getAbsolutePath(); throw new BuildException( message ); } if( null != m_usersFile && !m_usersFile.exists() )