From dd8442070314597038e789db03323dfc87b2bf6c Mon Sep 17 00:00:00 2001 From: Jacobus Martinus Kruithof Date: Sun, 8 Apr 2007 12:05:03 +0000 Subject: [PATCH] Changes after static code analysis. Code changed. git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@526541 13f79535-47bb-0310-9956-ffa450edef68 --- .../tools/ant/taskdefs/optional/jlink/jlink.java | 10 +++------- .../taskdefs/optional/junit/JUnitVersionHelper.java | 6 +++++- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java b/src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java index 966146859..1963fc2f9 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java @@ -22,6 +22,8 @@ */ package org.apache.tools.ant.taskdefs.optional.jlink; +import org.apache.tools.ant.util.FileUtils; + import java.io.BufferedInputStream; import java.io.File; import java.io.FileInputStream; @@ -180,13 +182,7 @@ public class jlink { addFile(output, f, "", compression); } } - if (output != null) { - try { - output.close(); - } catch (IOException ioe) { - //do nothing - } - } + FileUtils.close(output); } diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitVersionHelper.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitVersionHelper.java index 6f067717b..1f5d0432e 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitVersionHelper.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitVersionHelper.java @@ -58,7 +58,11 @@ public class JUnitVersionHelper { * @return the name of the test. */ public static String getTestCaseName(Test t) { - if (t != null && t.getClass().getName().equals("junit.framework.JUnit4TestCaseFacade")) { + if (t == null) + { + return "unknown"; + } + if (t.getClass().getName().equals("junit.framework.JUnit4TestCaseFacade")) { // Self-describing as of JUnit 4 (#38811). But trim "(ClassName)". String name = t.toString(); if (name.endsWith(")")) {