size comparator was vulnerable to integer overflows. PR 54623

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1452022 13f79535-47bb-0310-9956-ffa450edef68

WHATSNEW

@@ -77,6 +77,10 @@ Fixed bugs:
  * Base64Converter not properly handling bytes with MSB set (not masking byte to int conversion)
    Bugzilla Report 54460
 
+ * The size resource comparator would return wrong results if file
+   sizes differed by more than 2 GB.
+   Bugzilla Report 54623
+
 Other changes:
 --------------
 

src/main/org/apache/tools/ant/types/resources/comparators/Size.java

@@ -32,7 +32,8 @@ public class Size extends ResourceComparator {
      *         argument is less than, equal to, or greater than the second.
      */
     protected int resourceCompare(Resource foo, Resource bar) {
-        return (int) (foo.getSize() - bar.getSize());
+        long diff = foo.getSize() - bar.getSize();
+        return diff > 0 ? 1 : (diff == 0 ? 0 : -1);
     }
 
 }