diff --git a/proposal/embed/src/java/org/apache/tools/ant/PropertyHelper.java b/proposal/embed/src/java/org/apache/tools/ant/PropertyHelper.java index 244a661b5..6e0c0c90e 100644 --- a/proposal/embed/src/java/org/apache/tools/ant/PropertyHelper.java +++ b/proposal/embed/src/java/org/apache/tools/ant/PropertyHelper.java @@ -67,13 +67,12 @@ import org.xml.sax.helpers.AttributesImpl; /** * Deals with properties - substitution, dynamic properties, etc. * - * Eventually the static methods from ProjectHelper should be - * moved here ( with a wrapper for backward compat ). + * Important: the static methods from ProjectHelper belong here. They should + * be changed to wrap this. * - * Also the property store ( Hashtable ) and all property manipulation - * logic could be moved here. + * Also the property store ( Hashtable ) from Project and all property manipulation + * logic should be moved here ( and delegated to interceptors ). * - * @author Stefan Bodewig * @author Costin Manolache */ public class PropertyHelper { @@ -105,10 +104,6 @@ public class PropertyHelper { public void addPropertyInterceptor( PropertyInterceptor pi ) { propertyInterceptors.addElement( pi ); } - -// public Vector getPropertyInterceptors() { -// return propertyInterceptors; -// } /** Process an value, doing the replacements. */ @@ -168,7 +163,6 @@ public class PropertyHelper { Object processDynamic( Project project, String name ) { for(int i=0; i