diff --git a/src/etc/testcases/taskdefs/java.xml b/src/etc/testcases/taskdefs/java.xml index 6d8b20f44..a0c0450b6 100644 --- a/src/etc/testcases/taskdefs/java.xml +++ b/src/etc/testcases/taskdefs/java.xml @@ -17,13 +17,20 @@ --> + + + + + + + - - + + @@ -392,12 +399,6 @@ redirect.err="${redirect.err}" should be empty classpath="${tests-classpath.value}" failonerror="true" timeout="2000" /> - - - - - - diff --git a/src/etc/testcases/taskdefs/manifestclasspath.xml b/src/etc/testcases/taskdefs/manifestclasspath.xml index 9421bd7b9..f8a479511 100644 --- a/src/etc/testcases/taskdefs/manifestclasspath.xml +++ b/src/etc/testcases/taskdefs/manifestclasspath.xml @@ -17,44 +17,42 @@ --> - - - - + + + - - + + + + + - - - - - - - - - - - - - - + + + - - + + + + + + + + + + jarfile="${output}/classpath.jar"> - + @@ -62,7 +60,7 @@ + jarfile="${output}/classpath.jar"> @@ -75,56 +73,56 @@ + jarfile="${output}/classpath.jar" /> - + - + - + - + - + + jarfile="${output}/classpath.jar"> + jarfile="${output}/classpath.jar"> - + - + - + - + - + @@ -134,48 +132,48 @@ + jarfile="${output}/classes/classpath.jar"> - - - + + + - + + jarfile="${output}/classes/level2/classpath.jar"> - - - + + + - + + jarfile="${output}/classes/level2/classpath.jar"> - - - + + + - + + jarfile="${output}/classes/level2/classpath.jar"> - - - - + + + + @@ -191,22 +189,22 @@ - - - - + + + + + jarfile="${output}/beta.jar"> - - + + - - + + @@ -214,7 +212,7 @@ - + diff --git a/src/etc/testcases/taskdefs/mkdir.xml b/src/etc/testcases/taskdefs/mkdir.xml index 2ca4e2093..1ecc274da 100644 --- a/src/etc/testcases/taskdefs/mkdir.xml +++ b/src/etc/testcases/taskdefs/mkdir.xml @@ -18,6 +18,12 @@ + + + + + + @@ -27,7 +33,7 @@ - + diff --git a/src/etc/testcases/taskdefs/move.xml b/src/etc/testcases/taskdefs/move.xml index 911dff812..8b4a6c8ef 100644 --- a/src/etc/testcases/taskdefs/move.xml +++ b/src/etc/testcases/taskdefs/move.xml @@ -18,9 +18,15 @@ + + + + + + - - + + @@ -28,8 +34,8 @@ - - + + @@ -40,15 +46,15 @@ - - - - - - - - - + + + + + + + + + @@ -59,83 +65,83 @@ - - - - - + + + + + - - - - + + + + - - - + + + - + - - - + + + - + - + - + - - + + - + - + - + - + - + - + - + - + - + - + @@ -162,104 +168,96 @@ - - - - - - + + + + + + - + - + - - - - + + + + - - - - + + + + - - - - + + + + - + - + - + - - - - + + + + - - - - - + + + + + - - - - - + + + + + - - - - - - - - - - - - - - + + + + + + diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/JavaTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/JavaTest.java index 442a0f792..76669468f 100644 --- a/src/tests/junit/org/apache/tools/ant/taskdefs/JavaTest.java +++ b/src/tests/junit/org/apache/tools/ant/taskdefs/JavaTest.java @@ -60,6 +60,7 @@ public class JavaTest extends BuildFileTest { */ public void setUp() { configureProject("src/etc/testcases/taskdefs/java.xml"); + project.executeTarget("setUp"); //final String propname="tests-classpath.value"; //String testClasspath=System.getProperty(propname); @@ -69,11 +70,6 @@ public class JavaTest extends BuildFileTest { runFatalTests=true; } - public void tearDown() { - // remove log file from testSpawn - project.executeTarget("cleanup"); - } - public void testNoJarNoClassname(){ expectBuildExceptionContaining("testNoJarNoClassname", "parameter validation", @@ -180,7 +176,7 @@ public class JavaTest extends BuildFileTest { } public void testSpawn() { - File logFile = FILE_UTILS.createTempFile("spawn","log", project.getBaseDir(), false, false); + File logFile = FILE_UTILS.createTempFile("spawn","log", getOutputDir(), false, false); // this is guaranteed by FileUtils#createTempFile assertTrue("log file not existing", !logFile.exists()); project.setProperty("logFile", logFile.getAbsolutePath()); diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/MkdirTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/MkdirTest.java index d9a10784e..5d9b416ae 100644 --- a/src/tests/junit/org/apache/tools/ant/taskdefs/MkdirTest.java +++ b/src/tests/junit/org/apache/tools/ant/taskdefs/MkdirTest.java @@ -41,7 +41,7 @@ public class MkdirTest extends BuildFileTest { public void test3() { executeTarget("test3"); - java.io.File f = new java.io.File(getProjectDir(), "testdir.tmp"); + java.io.File f = new java.io.File(getOutputDir(), "testdir.tmp"); if (!f.exists() || !f.isDirectory()) { fail("mkdir failed"); } else { diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/MoveTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/MoveTest.java index ce5dc71cd..264e8298b 100644 --- a/src/tests/junit/org/apache/tools/ant/taskdefs/MoveTest.java +++ b/src/tests/junit/org/apache/tools/ant/taskdefs/MoveTest.java @@ -38,15 +38,12 @@ public class MoveTest extends BuildFileTest { public void setUp() { configureProject("src/etc/testcases/taskdefs/move.xml"); - } - - public void tearDown() { - executeTarget("cleanup"); + project.executeTarget("setUp"); } public void testFilterSet() throws IOException { executeTarget("testFilterSet"); - File tmp = new File(getProjectDir(), "move.filterset.tmp"); + File tmp = new File(getOutputDir(), "move.filterset.tmp"); File check = new File(getProjectDir(), "expected/copy.filterset.filtered"); assertTrue(tmp.exists()); assertTrue(FILE_UTILS.contentEquals(tmp, check)); @@ -54,7 +51,7 @@ public class MoveTest extends BuildFileTest { public void testFilterChain() throws IOException { executeTarget("testFilterChain"); - File tmp = new File(getProjectDir(), "move.filterchain.tmp"); + File tmp = new File(getOutputDir(), "move.filterchain.tmp"); File check = new File(getProjectDir(), "expected/copy.filterset.filtered"); assertTrue(tmp.exists()); assertTrue(FILE_UTILS.contentEquals(tmp, check)); @@ -63,23 +60,23 @@ public class MoveTest extends BuildFileTest { /** Bugzilla Report 11732 */ public void testDirectoryRemoval() throws IOException { executeTarget("testDirectoryRemoval"); - assertTrue(!getProject().resolveFile("E/B/1").exists()); - assertTrue(getProject().resolveFile("E/C/2").exists()); - assertTrue(getProject().resolveFile("E/D/3").exists()); - assertTrue(getProject().resolveFile("A/B/1").exists()); - assertTrue(!getProject().resolveFile("A/C/2").exists()); - assertTrue(!getProject().resolveFile("A/D/3").exists()); - assertTrue(!getProject().resolveFile("A/C").exists()); - assertTrue(!getProject().resolveFile("A/D").exists()); + assertTrue(!new File(getOutputDir(),"E/B/1").exists()); + assertTrue(new File(getOutputDir(),"E/C/2").exists()); + assertTrue(new File(getOutputDir(),"E/D/3").exists()); + assertTrue(new File(getOutputDir(),"A/B/1").exists()); + assertTrue(!new File(getOutputDir(),"A/C/2").exists()); + assertTrue(!new File(getOutputDir(),"A/D/3").exists()); + assertTrue(!new File(getOutputDir(),"A/C").exists()); + assertTrue(!new File(getOutputDir(),"A/D").exists()); } /** Bugzilla Report 18886 */ public void testDirectoryRetaining() throws IOException { executeTarget("testDirectoryRetaining"); - assertTrue(getProject().resolveFile("E").exists()); - assertTrue(getProject().resolveFile("E/1").exists()); - assertTrue(!getProject().resolveFile("A/1").exists()); - assertTrue(getProject().resolveFile("A").exists()); + assertTrue(new File(getOutputDir(),"E").exists()); + assertTrue(new File(getOutputDir(),"E/1").exists()); + assertTrue(!new File(getOutputDir(),"A/1").exists()); + assertTrue(new File(getOutputDir(),"A").exists()); } public void testCompleteDirectoryMove() throws IOException { @@ -92,19 +89,19 @@ public class MoveTest extends BuildFileTest { private void testCompleteDirectoryMove(String target) throws IOException { executeTarget(target); - assertTrue(getProject().resolveFile("E").exists()); - assertTrue(getProject().resolveFile("E/1").exists()); - assertTrue(!getProject().resolveFile("A/1").exists()); + assertTrue(new File(getOutputDir(),"E").exists()); + assertTrue(new File(getOutputDir(),"E/1").exists()); + assertTrue(!new File(getOutputDir(),"A/1").exists()); // swallows the basedir, it seems - //assertTrue(!getProject().resolveFile("A").exists()); + //assertTrue(!new File(getOutputDir(),"A").exists()); } public void testPathElementMove() throws IOException { executeTarget("testPathElementMove"); - assertTrue(getProject().resolveFile("E").exists()); - assertTrue(getProject().resolveFile("E/1").exists()); - assertTrue(!getProject().resolveFile("A/1").exists()); - assertTrue(getProject().resolveFile("A").exists()); + assertTrue(new File(getOutputDir(),"E").exists()); + assertTrue(new File(getOutputDir(),"E/1").exists()); + assertTrue(!new File(getOutputDir(),"A/1").exists()); + assertTrue(new File(getOutputDir(),"A").exists()); } public void testMoveFileAndFileset() {