diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/BriefJUnitResultFormatter.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/BriefJUnitResultFormatter.java index 62f7c1cf8..832f35f3a 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/BriefJUnitResultFormatter.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/BriefJUnitResultFormatter.java @@ -273,13 +273,12 @@ public class BriefJUnitResultFormatter implements JUnitResultFormatter, IgnoredT } - @Override public void testIgnored(Test test) { String message = null; if (test instanceof JUnit4TestCaseFacade) { JUnit4TestCaseFacade facade = (JUnit4TestCaseFacade) test; Ignore annotation = facade.getDescription().getAnnotation(Ignore.class); - if (annotation != null && annotation.value() != null && !annotation.value().isEmpty()) { + if (annotation != null && annotation.value().length() > 0) { message = annotation.value(); } } @@ -305,7 +304,6 @@ public class BriefJUnitResultFormatter implements JUnitResultFormatter, IgnoredT } - @Override public void testAssumptionFailure(Test test, Throwable cause) { formatSkip(test, cause.getMessage()); } diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/PlainJUnitResultFormatter.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/PlainJUnitResultFormatter.java index 559d09649..a6ed3ba0e 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/PlainJUnitResultFormatter.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/PlainJUnitResultFormatter.java @@ -263,13 +263,12 @@ public class PlainJUnitResultFormatter implements JUnitResultFormatter, IgnoredT } } - @Override public void testIgnored(Test test) { String message = null; if (test instanceof JUnit4TestCaseFacade) { JUnit4TestCaseFacade facade = (JUnit4TestCaseFacade) test; Ignore annotation = facade.getDescription().getAnnotation(Ignore.class); - if (annotation != null && annotation.value() != null && !annotation.value().isEmpty()) { + if (annotation != null && annotation.value().length() > 0) { message = annotation.value(); } } @@ -295,7 +294,6 @@ public class PlainJUnitResultFormatter implements JUnitResultFormatter, IgnoredT } - @Override public void testAssumptionFailure(Test test, Throwable throwable) { formatSkip(test, throwable.getMessage()); } diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/TestListenerWrapper.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/TestListenerWrapper.java index 0aaf63350..5f2f2d00b 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/TestListenerWrapper.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/TestListenerWrapper.java @@ -36,39 +36,32 @@ public class TestListenerWrapper implements TestListener, IgnoredTestListener { wrapped = listener; } - @Override public void addError(Test test, Throwable throwable) { wrapped.addError(test, throwable); } - @Override public void addFailure(Test test, AssertionFailedError assertionFailedError) { wrapped.addFailure(test, assertionFailedError); } - @Override public void endTest(Test test) { wrapped.endTest(test); } - @Override public void startTest(Test test) { wrapped.startTest(test); } - @Override public void testIgnored(Test test) { if (wrapped instanceof IgnoredTestListener) { ((IgnoredTestListener)wrapped).testIgnored(test); } } - @Override public void testAssumptionFailure(Test test, Throwable throwable) { if (wrapped instanceof IgnoredTestListener) { ((IgnoredTestListener)wrapped).testAssumptionFailure(test, throwable); } } - } diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java index bd4cd2c22..72f4b5ccc 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java @@ -322,7 +322,6 @@ public class XMLJUnitResultFormatter implements JUnitResultFormatter, XMLConstan nested.appendChild(doc.createCDATASection(output)); } - @Override public void testIgnored(Test test) { String message = null; if (test != null && test instanceof JUnit4TestCaseFacade) { @@ -336,7 +335,7 @@ public class XMLJUnitResultFormatter implements JUnitResultFormatter, XMLConstan Method testMethod = testClass.getMethod(JUnitVersionHelper.getTestCaseName(test)); Ignore annotation = testMethod.getAnnotation(Ignore.class); - if (annotation != null && annotation.value() != null && !annotation.value().isEmpty()) { + if (annotation != null && annotation.value().length() > 0) { message = annotation.value(); } } catch (NoSuchMethodException e) { @@ -374,7 +373,6 @@ public class XMLJUnitResultFormatter implements JUnitResultFormatter, XMLConstan } - @Override public void testAssumptionFailure(Test test, Throwable failure) { String message = failure.getMessage(); formatSkip(test, message);