Browse Source

1. Ensure javac does not report deprecation warnings.

2. Close fileoutputstream for every iteration.


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@269966 13f79535-47bb-0310-9956-ffa450edef68
master
Magesh Umasankar 23 years ago
parent
commit
b7cfa6d516
1 changed files with 10 additions and 8 deletions
  1. +10
    -8
      src/main/org/apache/tools/ant/taskdefs/Checksum.java

+ 10
- 8
src/main/org/apache/tools/ant/taskdefs/Checksum.java View File

@@ -53,10 +53,11 @@
*/
package org.apache.tools.ant.taskdefs;

import java.io.DataInputStream;
import java.io.BufferedReader;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.InputStreamReader;
import java.io.IOException;
import java.security.DigestInputStream;
import java.security.MessageDigest;
@@ -377,15 +378,14 @@ public class Checksum extends MatchingTask implements Condition {
if (existingFile.exists() &&
existingFile.length() == checksum.length()) {
fis = new FileInputStream(existingFile);
DataInputStream edis = new DataInputStream(fis);
String suppliedChecksum = "";
if (edis.available() > 0) {
suppliedChecksum = edis.readLine();
}
InputStreamReader isr = new InputStreamReader(fis);
BufferedReader br = new BufferedReader(isr);
String suppliedChecksum = br.readLine();
fis.close();
fis = null;
edis.close();
checksumMatches =
br.close();
isr.close();
checksumMatches =
checksum.equals(suppliedChecksum);
} else {
checksumMatches = false;
@@ -394,6 +394,8 @@ public class Checksum extends MatchingTask implements Condition {
File dest = (File) destination;
fos = new FileOutputStream(dest);
fos.write(checksum.getBytes());
fos.close();
fos = null;
}
}
}


Loading…
Cancel
Save