diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/ProjectComponent.java b/proposal/myrmidon/src/main/org/apache/tools/ant/ProjectComponent.java index b502af935..87d5f1e22 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/ProjectComponent.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/ProjectComponent.java @@ -46,6 +46,12 @@ public abstract class ProjectComponent return project; } + public void execute() + throws TaskException + { + //HACK: NOOP execute - should be deleted in the future! + } + protected File resolveFile( final String name ) throws TaskException { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/TaskContainer.java b/proposal/myrmidon/src/main/org/apache/tools/ant/TaskContainer.java index 0802b18c4..4b91c8e57 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/TaskContainer.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/TaskContainer.java @@ -7,6 +7,8 @@ */ package org.apache.tools.ant; +import org.apache.myrmidon.api.TaskException; + /** * Interface for objects which can contain tasks
* @@ -23,6 +25,7 @@ public interface TaskContainer * * @param task the task to be added to this container */ - void addTask( Task task ); + void addTask( Task task ) + throws TaskException; } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Chmod.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Chmod.java index 4d09e09c2..989dc3fa6 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Chmod.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Chmod.java @@ -32,6 +32,7 @@ public class Chmod extends ExecuteOn private boolean havePerm = false; public Chmod() + throws TaskException { super.setExecutable( "chmod" ); super.setParallel( true ); diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Ear.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Ear.java index 4c5b2bab6..260b49cb9 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Ear.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Ear.java @@ -34,6 +34,7 @@ public class Ear extends Jar } public void setAppxml( File descr ) + throws TaskException { deploymentDescriptor = descr; if( !deploymentDescriptor.exists() ) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Echo.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Echo.java index 87b5e280c..34659427c 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Echo.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Echo.java @@ -106,6 +106,7 @@ public class Echo extends Task * @param msg The feature to be added to the Text attribute */ public void addText( String msg ) + throws TaskException { message += project.replaceProperties( msg ); } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecuteOn.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecuteOn.java index a60733c6c..df23fa553 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecuteOn.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/ExecuteOn.java @@ -167,6 +167,7 @@ public class ExecuteOn extends ExecTask * @return The Commandline value */ protected String[] getCommandline( String[] srcFiles, File[] baseDirs ) + throws TaskException { Vector targets = new Vector(); if( targetFilePos != null ) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Exit.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Exit.java index 0f441a1e7..ca3013bc3 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Exit.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Exit.java @@ -41,6 +41,7 @@ public class Exit extends Task * @param msg The feature to be added to the Text attribute */ public void addText( String msg ) + throws TaskException { message += project.replaceProperties( msg ); } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Expand.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Expand.java index ac86f32ac..d1d5b7938 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Expand.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Expand.java @@ -151,6 +151,7 @@ public class Expand extends MatchingTask * This method is to be overridden by extending unarchival tasks. */ protected void expandFile( FileUtils fileUtils, File srcF, File dir ) + throws TaskException { ZipInputStream zis = null; try @@ -192,7 +193,7 @@ public class Expand extends MatchingTask InputStream compressedInputStream, String entryName, Date entryDate, boolean isDirectory ) - throws IOException + throws IOException, TaskException { if( patternsets != null && patternsets.size() > 0 ) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/FixCRLF.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/FixCRLF.java index 2a2288eb0..b84062cb7 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/FixCRLF.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/FixCRLF.java @@ -455,6 +455,7 @@ public class FixCRLF extends MatchingTask */ private void notInConstant( OneLiner.BufferLine bufline, int end, BufferedWriter outWriter ) + throws TaskException { // N.B. both column and string index are zero-based // Process a string not part of a constant; @@ -922,7 +923,14 @@ public class FixCRLF extends MatchingTask } BufferLine tmpLine = new BufferLine( line.toString(), eolStr.toString() ); - nextLine(); + try + { + nextLine(); + } + catch( TaskException e ) + { + throw new NoSuchElementException(); + } return tmpLine; } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Javac.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Javac.java index a25188526..d984edc35 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Javac.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Javac.java @@ -831,17 +831,6 @@ public class Javac extends MatchingTask "javac1.4".equals( compiler ); } - /** - * Recreate src - * - * @return a nested src element. - */ - protected Path recreateSrc() - { - src = null; - return createSrc(); - } - /** * Clear the list of files to be compiled and copied.. */ diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Javadoc.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Javadoc.java index d5a992bbd..a1fb74ec8 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Javadoc.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Javadoc.java @@ -116,11 +116,13 @@ public class Javadoc extends Task * @param r The new BootClasspathRef value */ public void setBootClasspathRef( Reference r ) + throws TaskException { createBootclasspath().setRefid( r ); } public void setBootclasspath( Path src ) + throws TaskException { if( bootclasspath == null ) { @@ -145,6 +147,7 @@ public class Javadoc extends Task } public void setClasspath( Path src ) + throws TaskException { if( classpath == null ) { @@ -162,6 +165,7 @@ public class Javadoc extends Task * @param r The new ClasspathRef value */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -209,6 +213,7 @@ public class Javadoc extends Task } public void setDocletPathRef( Reference r ) + throws TaskException { if( doclet == null ) { @@ -445,6 +450,7 @@ public class Javadoc extends Task } public void setSourcepath( Path src ) + throws TaskException { if( sourcePath == null ) { @@ -462,6 +468,7 @@ public class Javadoc extends Task * @param r The new SourcepathRef value */ public void setSourcepathRef( Reference r ) + throws TaskException { createSourcepath().setRefid( r ); } @@ -557,11 +564,13 @@ public class Javadoc extends Task } public void addSource( SourceFile sf ) + throws TaskException { sourceFiles.addElement( sf ); } public Path createBootclasspath() + throws TaskException { if( bootclasspath == null ) { @@ -571,6 +580,7 @@ public class Javadoc extends Task } public Path createClasspath() + throws TaskException { if( classpath == null ) { @@ -600,6 +610,7 @@ public class Javadoc extends Task } public Path createSourcepath() + throws TaskException { if( sourcePath == null ) { @@ -956,6 +967,7 @@ public class Javadoc extends Task * @return Description of the Returned Value */ protected String expand( String content ) + throws TaskException { return project.replaceProperties( content ); } @@ -1242,6 +1254,7 @@ public class Javadoc extends Task } public void setPath( Path path ) + throws TaskException { if( this.path == null ) { @@ -1259,6 +1272,7 @@ public class Javadoc extends Task * @param r The new PathRef value */ public void setPathRef( Reference r ) + throws TaskException { createPath().setRefid( r ); } @@ -1287,6 +1301,7 @@ public class Javadoc extends Task } public Path createPath() + throws TaskException { if( path == null ) { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Manifest.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Manifest.java index 947889912..49fbc9902 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Manifest.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Manifest.java @@ -109,7 +109,7 @@ public class Manifest extends Task * @throws IOException if the manifest cannot be read from the reader. */ public Manifest( Reader r ) - throws ManifestException, IOException + throws ManifestException, TaskException, IOException { BufferedReader reader = new BufferedReader( r ); // This should be the manifest version @@ -239,7 +239,7 @@ public class Manifest extends Task } public void addConfiguredAttribute( Attribute attribute ) - throws ManifestException + throws ManifestException, TaskException { mainSection.addConfiguredAttribute( attribute ); } @@ -417,7 +417,7 @@ public class Manifest extends Task { write( new PrintWriter( sw ) ); } - catch( IOException e ) + catch( Exception e ) { return null; } @@ -431,7 +431,7 @@ public class Manifest extends Task * @throws IOException if the manifest cannot be written */ public void write( PrintWriter writer ) - throws IOException + throws IOException, TaskException { writer.println( ATTRIBUTE_MANIFEST_VERSION + ": " + manifestVersion ); String signatureVersion = mainSection.getAttributeValue( ATTRIBUTE_SIGNATURE_VERSION ); @@ -862,7 +862,7 @@ public class Manifest extends Task * @throws IOException if the section cannot be read from the reader. */ public String read( BufferedReader reader ) - throws ManifestException, IOException + throws ManifestException, IOException, TaskException { Attribute attribute = null; while( true ) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Move.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Move.java index c71fa4c89..1a9268b6d 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Move.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Move.java @@ -47,6 +47,7 @@ public class Move extends Copy * @param d Description of Parameter */ protected void deleteDir( File d ) + throws TaskException { String[] list = d.list(); if( list == null ) @@ -77,6 +78,7 @@ public class Move extends Copy //************************************************************************ protected void doFileOperations() + throws TaskException { //Attempt complete directory renames, if any, first. if( completeDirMap.size() > 0 ) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Parallel.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Parallel.java index 5f8cf0938..ac911515d 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Parallel.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Parallel.java @@ -98,11 +98,13 @@ public class Parallel extends Task { firstException = t; } + /* if( t instanceof TaskException && firstLocation == Location.UNKNOWN_LOCATION ) { firstLocation = ( (TaskException)t ).getLocation(); } + */ exceptionMessage.append( lSep ); exceptionMessage.append( t.getMessage() ); } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Patch.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Patch.java index 4a6e9709d..e579756f5 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Patch.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Patch.java @@ -68,6 +68,7 @@ public class Patch extends Task * @param file The new Patchfile value */ public void setPatchfile( File file ) + throws TaskException { if( !file.exists() ) { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/PathConvert.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/PathConvert.java index d844183c7..58b4f5c8c 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/PathConvert.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/PathConvert.java @@ -77,6 +77,7 @@ public class PathConvert extends Task * @param r The new Refid value */ public void setRefid( Reference r ) + throws TaskException { if( path != null ) throw noChildrenAllowed(); @@ -90,8 +91,8 @@ public class PathConvert extends Task * @param target The new Targetos value */ public void setTargetos( String target ) + throws TaskException { - targetOS = target.toLowerCase(); if( !targetOS.equals( "windows" ) && !target.equals( "unix" ) && @@ -139,8 +140,8 @@ public class PathConvert extends Task * @return Description of the Returned Value */ public Path createPath() + throws TaskException { - if( isReference() ) throw noChildrenAllowed(); @@ -159,7 +160,6 @@ public class PathConvert extends Task public void execute() throws TaskException { - // If we are a reference, the create a Path from the reference if( isReference() ) { @@ -238,8 +238,8 @@ public class PathConvert extends Task * @return String Updated element */ private String mapElement( String elem ) + throws TaskException { - int size = prefixMap.size(); if( size != 0 ) @@ -365,6 +365,7 @@ public class PathConvert extends Task * @return String Updated path element after mapping */ public String apply( String elem ) + throws TaskException { if( from == null || to == null ) { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Property.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Property.java index 645da4af7..bb4129199 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Property.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Property.java @@ -54,6 +54,7 @@ public class Property extends Task } public void setClasspath( Path classpath ) + throws TaskException { if( this.classpath == null ) { @@ -66,6 +67,7 @@ public class Property extends Task } public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -136,6 +138,7 @@ public class Property extends Task } public Path createClasspath() + throws TaskException { if( this.classpath == null ) { @@ -192,6 +195,7 @@ public class Property extends Task } protected void addProperties( Properties props ) + throws TaskException { resolveAllProperties( props ); Enumeration e = props.keys(); diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Rmic.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Rmic.java index 908512e1b..bc55a828b 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Rmic.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Rmic.java @@ -682,7 +682,6 @@ public class Rmic extends MatchingTask { String msg = "Failed to copy " + oldFile + " to " + newFile + " due to " + ioe.getMessage(); - newFile + " due to " + ioe.getMessage(); throw new TaskException( msg, ioe ); } } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/SQLExec.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/SQLExec.java index 6f80e8dc9..e04a5aa9e 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/SQLExec.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/SQLExec.java @@ -171,6 +171,7 @@ public class SQLExec extends Task * @param classpath The new Classpath value */ public void setClasspath( Path classpath ) + throws TaskException { if( this.classpath == null ) { @@ -188,6 +189,7 @@ public class SQLExec extends Task * @param r The new ClasspathRef value */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -364,6 +366,7 @@ public class SQLExec extends Task * @return Description of the Returned Value */ public Path createClasspath() + throws TaskException { if( this.classpath == null ) { @@ -739,7 +742,7 @@ public class SQLExec extends Task } protected void runStatements( Reader reader, PrintStream out ) - throws SQLException, IOException + throws SQLException, IOException, TaskException { String sql = ""; String line = ""; @@ -845,7 +848,7 @@ public class SQLExec extends Task } private void runTransaction( PrintStream out ) - throws IOException, SQLException + throws IOException, SQLException, TaskException { if( tSqlCommand.length() != 0 ) { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Tar.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Tar.java index 53c7b21f6..0dd6816ae 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Tar.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Tar.java @@ -222,7 +222,7 @@ public class Tar extends MatchingTask protected void tarFile( File file, TarOutputStream tOut, String vPath, TarFileSet tarFileSet ) - throws IOException + throws IOException, TaskException { FileInputStream fIn = null; @@ -341,6 +341,7 @@ public class Tar extends MatchingTask * for the project. */ public String[] getFiles( Project p ) + throws TaskException { if( files == null ) { @@ -380,7 +381,6 @@ public class Tar extends MatchingTask */ public static class TarLongFileMode extends EnumeratedAttribute { - // permissable values for longfile attribute public final static String WARN = "warn"; public final static String FAIL = "fail"; @@ -391,6 +391,7 @@ public class Tar extends MatchingTask private final String[] validModes = {WARN, FAIL, TRUNCATE, GNU, OMIT}; public TarLongFileMode() + throws TaskException { super(); setValue( WARN ); diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Tstamp.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Tstamp.java index 655b4919e..6c8ce5f0f 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Tstamp.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Tstamp.java @@ -153,6 +153,7 @@ public class Tstamp extends Task } public void setLocale( String locale ) + throws TaskException { StringTokenizer st = new StringTokenizer( locale, " \t\n\r\f," ); try @@ -207,6 +208,7 @@ public class Tstamp extends Task } public void execute( Project project, Date date, Location location ) + throws TaskException { if( propertyName == null ) { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Untar.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Untar.java index 0f98af71b..72cda75b4 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Untar.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Untar.java @@ -26,6 +26,7 @@ public class Untar extends Expand { protected void expandFile( FileUtils fileUtils, File srcF, File dir ) + throws TaskException { TarInputStream tis = null; try diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/UpToDate.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/UpToDate.java index 308fd768f..c0c63b9c3 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/UpToDate.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/UpToDate.java @@ -107,6 +107,7 @@ public class UpToDate extends MatchingTask implements Condition * @return Description of the Returned Value */ public boolean eval() + throws TaskException { if( sourceFileSets.size() == 0 ) { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/War.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/War.java index 328cf7e00..9e00d12f1 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/War.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/War.java @@ -33,6 +33,7 @@ public class War extends Jar } public void setWebxml( File descr ) + throws TaskException { deploymentDescriptor = descr; if( !deploymentDescriptor.exists() ) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java index 18332d0ef..25da76d77 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java @@ -91,6 +91,7 @@ public class XSLTProcess extends MatchingTask implements XSLTLogger * @param classpath The new Classpath value */ public void setClasspath( Path classpath ) + throws TaskException { createClasspath().append( classpath ); } @@ -102,6 +103,7 @@ public class XSLTProcess extends MatchingTask implements XSLTLogger * @param r The new ClasspathRef value */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); }//-- setSourceDir @@ -191,6 +193,7 @@ public class XSLTProcess extends MatchingTask implements XSLTLogger * @return Description of the Returned Value */ public Path createClasspath() + throws TaskException { if( classpath == null ) { @@ -279,6 +282,7 @@ public class XSLTProcess extends MatchingTask implements XSLTLogger } protected XSLTLiaison getLiaison() + throws TaskException { // if processor wasn't specified, see if TraX is available. If not, // default it to xslp or xalan, depending on which is in the classpath diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java index 74fe6ef4c..ec8d66451 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java @@ -384,6 +384,7 @@ public abstract class DefaultCompilerAdapter implements CompilerAdapter * @return Description of the Returned Value */ protected int executeExternalCompile( String[] args, int firstFileName ) + throws TaskException { String[] commandArray = null; File tmpFile = null; diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/condition/Http.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/condition/Http.java index de3eaabd4..eaabf8685 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/condition/Http.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/condition/Http.java @@ -21,7 +21,9 @@ import org.apache.tools.ant.ProjectComponent; * * @author Denis Hennessy */ -public class Http extends ProjectComponent implements Condition +public class Http + extends ProjectComponent + implements Condition { String spec = null; diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/condition/Socket.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/condition/Socket.java index 3ecef0857..aa6aad3b9 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/condition/Socket.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/condition/Socket.java @@ -18,7 +18,9 @@ import org.apache.tools.ant.ProjectComponent; * * @author Denis Hennessy */ -public class Socket extends ProjectComponent implements Condition +public class Socket + extends ProjectComponent + implements Condition { String server = null; int port = 0; diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java index 0496befd0..c3ee51c8d 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java @@ -100,6 +100,7 @@ public class Rpm extends Task } public void setSpecFile( String sf ) + throws TaskException { if( ( sf == null ) || ( sf.trim().equals( "" ) ) ) { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java index e2f8835b3..6f675e502 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java @@ -109,8 +109,8 @@ public class XMLValidateTask extends Task * @param classpath The new Classpath value */ public void setClasspath( Path classpath ) + throws TaskException { - if( this.classpath == null ) { this.classpath = classpath; @@ -126,6 +126,7 @@ public class XMLValidateTask extends Task * @see #setClasspath */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -202,6 +203,7 @@ public class XMLValidateTask extends Task * @see #setClasspath */ public Path createClasspath() + throws TaskException { if( this.classpath == null ) { @@ -319,6 +321,7 @@ public class XMLValidateTask extends Task * parse the file */ private void doValidate( File afile ) + throws TaskException { try { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java index 0ec54a977..61ec4f7e5 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java @@ -119,7 +119,7 @@ public class CCMCreateTask extends Continuus implements ExecuteStreamHandler * @exception IOException Description of Exception */ public void setProcessOutputStream( InputStream is ) - throws IOException + throws TaskException, IOException { String buffer = ""; diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java index 654b19ad9..12320fe9b 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java @@ -107,6 +107,7 @@ public abstract class Continuus extends Task } protected int run( Commandline cmd, ExecuteStreamHandler handler ) + throws TaskException { try { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/ClearCase.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/ClearCase.java index 941519ab8..0be5d35cc 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/ClearCase.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/clearcase/ClearCase.java @@ -13,6 +13,7 @@ import org.apache.tools.ant.Task; import org.apache.tools.ant.taskdefs.Execute; import org.apache.tools.ant.taskdefs.LogStreamHandler; import org.apache.tools.ant.types.Commandline; +import java.io.IOException; /** * A base class for creating tasks for executing commands on ClearCase.
@@ -103,6 +104,7 @@ public abstract class ClearCase extends Task } protected int run( Commandline cmd ) + throws TaskException { try { @@ -113,7 +115,7 @@ public abstract class ClearCase extends Task exe.setCommandline( cmd.getCommandline() ); return exe.execute(); } - catch( java.io.IOException e ) + catch( IOException e ) { throw new TaskException( "Error", e ); } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java index 80632df63..bc56cfe38 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java @@ -105,6 +105,7 @@ public class Depend extends MatchingTask * @param classpath The new Classpath value */ public void setClasspath( Path classpath ) + throws TaskException { if( dependClasspath == null ) { @@ -122,6 +123,7 @@ public class Depend extends MatchingTask * @param r The new ClasspathRef value */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -178,6 +180,7 @@ public class Depend extends MatchingTask * @return Description of the Returned Value */ public Path createClasspath() + throws TaskException { if( dependClasspath == null ) { @@ -359,6 +362,7 @@ public class Depend extends MatchingTask * @return a vector containing the classes to analyse. */ private Vector getClassFiles( Path classLocations ) + throws TaskException { // break the classLocations into its components. String[] classLocationsList = classLocations.list(); diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/CSharp.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/CSharp.java index 305d521ab..e38dd7061 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/CSharp.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/CSharp.java @@ -280,6 +280,7 @@ public class CSharp */ public CSharp() + throws TaskException { Clear(); setIncludes( csc_file_pattern ); @@ -417,6 +418,7 @@ public class CSharp * @param path another path to append */ public void setReferenceFiles( Path path ) + throws TaskException { //demand create pathlist if( _referenceFiles == null ) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/Ilasm.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/Ilasm.java index 1625cd28d..51bc8f7bd 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/Ilasm.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/Ilasm.java @@ -119,6 +119,7 @@ public class Ilasm * constructor inits everything and set up the search pattern */ public Ilasm() + throws TaskException { Clear(); setIncludes( file_pattern ); diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java index 0cd68c4de..6ed419a83 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java @@ -76,6 +76,7 @@ public class NetCommand */ public NetCommand( Task owner, String title, String program ) + throws TaskException { _owner = owner; _title = title; @@ -196,6 +197,7 @@ public class NetCommand * set up the command sequence.. */ protected void prepareExecutor() + throws TaskException { // default directory to the project's base directory File dir = _owner.getProject().getBaseDir(); diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ejb/BorlandGenerateClient.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ejb/BorlandGenerateClient.java index 52abf8e41..93e40100c 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ejb/BorlandGenerateClient.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ejb/BorlandGenerateClient.java @@ -55,6 +55,7 @@ public class BorlandGenerateClient extends Task Path classpath; public void setClasspath( Path classpath ) + throws TaskException { if( this.classpath == null ) { @@ -67,6 +68,7 @@ public class BorlandGenerateClient extends Task } public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -92,6 +94,7 @@ public class BorlandGenerateClient extends Task } public Path createClasspath() + throws TaskException { if( this.classpath == null ) { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jlink/JlinkTask.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jlink/JlinkTask.java index 4261a067f..df831e709 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jlink/JlinkTask.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jlink/JlinkTask.java @@ -59,6 +59,7 @@ public class JlinkTask extends MatchingTask * @param addfiles The new Addfiles value */ public void setAddfiles( Path addfiles ) + throws TaskException { if( this.addfiles == null ) { @@ -86,6 +87,7 @@ public class JlinkTask extends MatchingTask * @param mergefiles The new Mergefiles value */ public void setMergefiles( Path mergefiles ) + throws TaskException { if( this.mergefiles == null ) { @@ -113,6 +115,7 @@ public class JlinkTask extends MatchingTask * @return Description of the Returned Value */ public Path createAddfiles() + throws TaskException { if( this.addfiles == null ) { @@ -128,6 +131,7 @@ public class JlinkTask extends MatchingTask * @return Description of the Returned Value */ public Path createMergefiles() + throws TaskException { if( this.mergefiles == null ) { @@ -179,11 +183,13 @@ public class JlinkTask extends MatchingTask } private boolean haveAddFiles() + throws TaskException { return haveEntries( addfiles ); } private boolean haveEntries( Path p ) + throws TaskException { if( p == null ) { @@ -197,9 +203,9 @@ public class JlinkTask extends MatchingTask } private boolean haveMergeFiles() + throws TaskException { return haveEntries( mergefiles ); } - } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jsp/JspC.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jsp/JspC.java index 3ed023fae..cd4b6c626 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jsp/JspC.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jsp/JspC.java @@ -101,6 +101,7 @@ public class JspC extends MatchingTask * @param cp The new Classpath value */ public void setClasspath( Path cp ) + throws TaskException { if( classpath == null ) classpath = cp; @@ -114,6 +115,7 @@ public class JspC extends MatchingTask * @param r The new ClasspathRef value */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -187,6 +189,7 @@ public class JspC extends MatchingTask * @param srcDir The new Srcdir value */ public void setSrcdir( Path srcDir ) + throws TaskException { if( src == null ) { @@ -309,6 +312,7 @@ public class JspC extends MatchingTask * @return Description of the Returned Value */ public Path createClasspath() + throws TaskException { if( classpath == null ) classpath = new Path( project ); diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java index 0a9a1b07b..305008c69 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java @@ -74,6 +74,7 @@ public class WLJspc extends MatchingTask * @param classpath The new Classpath value */ public void setClasspath( Path classpath ) + throws TaskException { if( compileClasspath == null ) { @@ -92,7 +93,6 @@ public class WLJspc extends MatchingTask */ public void setDest( File dirName ) { - destinationDirectory = dirName; } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java index 09d01e098..80aca86c7 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java @@ -319,7 +319,7 @@ public class Pvcs extends org.apache.tools.ant.Task * build... */ public void execute() - throws org.apache.tools.ant.TaskException + throws TaskException { Project aProj = getProject(); int result = 0; @@ -446,6 +446,7 @@ public class Pvcs extends org.apache.tools.ant.Task } protected int runCmd( Commandline cmd, ExecuteStreamHandler out ) + throws TaskException { try { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java index 7dfcfdf5e..2d4d1c37d 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java @@ -200,6 +200,7 @@ public abstract class MSVSS extends Task } protected int run( Commandline cmd ) + throws TaskException { try { diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSHISTORY.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSHISTORY.java index dfea9efc5..aed5c49f4 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSHISTORY.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSHISTORY.java @@ -141,6 +141,7 @@ public class MSVSSHISTORY extends MSVSS * @param attr The new Style value */ public void setStyle( BriefCodediffNofile attr ) + throws TaskException { String option = attr.getValue(); if( option.equals( "brief" ) ) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/rmic/DefaultRmicAdapter.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/rmic/DefaultRmicAdapter.java index 4ec600fbf..7c5691aa2 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/rmic/DefaultRmicAdapter.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/rmic/DefaultRmicAdapter.java @@ -10,6 +10,7 @@ package org.apache.tools.ant.taskdefs.rmic; import java.io.File; import java.util.Random; import java.util.Vector; +import org.apache.myrmidon.api.TaskException; import org.apache.tools.ant.Project; import org.apache.tools.ant.taskdefs.Rmic; import org.apache.tools.ant.types.Commandline; @@ -51,6 +52,7 @@ public abstract class DefaultRmicAdapter implements RmicAdapter * @return The Classpath value */ public Path getClasspath() + throws TaskException { return getCompileClasspath(); } @@ -77,6 +79,7 @@ public abstract class DefaultRmicAdapter implements RmicAdapter * @return Description of the Returned Value */ protected Commandline setupRmicCommand() + throws TaskException { return setupRmicCommand( null ); } @@ -88,6 +91,7 @@ public abstract class DefaultRmicAdapter implements RmicAdapter * @return Description of the Returned Value */ protected Commandline setupRmicCommand( String[] options ) + throws TaskException { Commandline cmd = new Commandline(); @@ -178,6 +182,7 @@ public abstract class DefaultRmicAdapter implements RmicAdapter * @return The CompileClasspath value */ protected Path getCompileClasspath() + throws TaskException { // add dest dir to classpath so that previously compiled and // untouched classes are on classpath diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/rmic/RmicAdapter.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/rmic/RmicAdapter.java index 0bfc26448..b5b97ba00 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/rmic/RmicAdapter.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/rmic/RmicAdapter.java @@ -57,5 +57,6 @@ public interface RmicAdapter * * @return The Classpath value */ - Path getClasspath(); + Path getClasspath() + throws TaskException; } diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/types/DataType.java b/proposal/myrmidon/src/main/org/apache/tools/ant/types/DataType.java index 494b1b940..19d4b421b 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/types/DataType.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/types/DataType.java @@ -92,12 +92,6 @@ public abstract class DataType return ref != null; } - public void execute() - throws TaskException - { - //HACK: NOOP execute - should be deleted in the future! - } - /** * Performs the check for circular references and returns the referenced * object. diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/util/FileNameMapper.java b/proposal/myrmidon/src/main/org/apache/tools/ant/util/FileNameMapper.java index 33ae65096..0c1d2b8bd 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/util/FileNameMapper.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/util/FileNameMapper.java @@ -7,6 +7,8 @@ */ package org.apache.tools.ant.util; +import org.apache.myrmidon.api.TaskException; + /** * Interface to be used by SourceFileScanner.
* @@ -27,7 +29,8 @@ public interface FileNameMapper * * @param from The new From value */ - void setFrom( String from ); + void setFrom( String from ) + throws TaskException; /** * Sets the to part of the transformation rule. diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/util/RegexpPatternMapper.java b/proposal/myrmidon/src/main/org/apache/tools/ant/util/RegexpPatternMapper.java index d2382c5a5..caf44ee4c 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/util/RegexpPatternMapper.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/util/RegexpPatternMapper.java @@ -69,9 +69,9 @@ public class RegexpPatternMapper implements FileNameMapper * @return Description of the Returned Value */ public String[] mapFileName( String sourceFileName ) + throws TaskException { - if( reg == null || to == null - || !reg.matches( sourceFileName ) ) + if( reg == null || to == null || !reg.matches( sourceFileName ) ) { return null; } @@ -86,6 +86,7 @@ public class RegexpPatternMapper implements FileNameMapper * @return Description of the Returned Value */ protected String replaceReferences( String source ) + throws TaskException { Vector v = reg.getGroups( source ); diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/ProjectComponent.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/ProjectComponent.java index b502af935..87d5f1e22 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/ProjectComponent.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/ProjectComponent.java @@ -46,6 +46,12 @@ public abstract class ProjectComponent return project; } + public void execute() + throws TaskException + { + //HACK: NOOP execute - should be deleted in the future! + } + protected File resolveFile( final String name ) throws TaskException { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/TaskContainer.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/TaskContainer.java index 0802b18c4..4b91c8e57 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/TaskContainer.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/TaskContainer.java @@ -7,6 +7,8 @@ */ package org.apache.tools.ant; +import org.apache.myrmidon.api.TaskException; + /** * Interface for objects which can contain tasks
* @@ -23,6 +25,7 @@ public interface TaskContainer * * @param task the task to be added to this container */ - void addTask( Task task ); + void addTask( Task task ) + throws TaskException; } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Chmod.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Chmod.java index 4d09e09c2..989dc3fa6 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Chmod.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Chmod.java @@ -32,6 +32,7 @@ public class Chmod extends ExecuteOn private boolean havePerm = false; public Chmod() + throws TaskException { super.setExecutable( "chmod" ); super.setParallel( true ); diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Ear.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Ear.java index 4c5b2bab6..260b49cb9 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Ear.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Ear.java @@ -34,6 +34,7 @@ public class Ear extends Jar } public void setAppxml( File descr ) + throws TaskException { deploymentDescriptor = descr; if( !deploymentDescriptor.exists() ) diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Echo.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Echo.java index 87b5e280c..34659427c 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Echo.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Echo.java @@ -106,6 +106,7 @@ public class Echo extends Task * @param msg The feature to be added to the Text attribute */ public void addText( String msg ) + throws TaskException { message += project.replaceProperties( msg ); } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecuteOn.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecuteOn.java index a60733c6c..df23fa553 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecuteOn.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/ExecuteOn.java @@ -167,6 +167,7 @@ public class ExecuteOn extends ExecTask * @return The Commandline value */ protected String[] getCommandline( String[] srcFiles, File[] baseDirs ) + throws TaskException { Vector targets = new Vector(); if( targetFilePos != null ) diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Exit.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Exit.java index 0f441a1e7..ca3013bc3 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Exit.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Exit.java @@ -41,6 +41,7 @@ public class Exit extends Task * @param msg The feature to be added to the Text attribute */ public void addText( String msg ) + throws TaskException { message += project.replaceProperties( msg ); } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Expand.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Expand.java index ac86f32ac..d1d5b7938 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Expand.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Expand.java @@ -151,6 +151,7 @@ public class Expand extends MatchingTask * This method is to be overridden by extending unarchival tasks. */ protected void expandFile( FileUtils fileUtils, File srcF, File dir ) + throws TaskException { ZipInputStream zis = null; try @@ -192,7 +193,7 @@ public class Expand extends MatchingTask InputStream compressedInputStream, String entryName, Date entryDate, boolean isDirectory ) - throws IOException + throws IOException, TaskException { if( patternsets != null && patternsets.size() > 0 ) diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/FixCRLF.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/FixCRLF.java index 2a2288eb0..b84062cb7 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/FixCRLF.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/FixCRLF.java @@ -455,6 +455,7 @@ public class FixCRLF extends MatchingTask */ private void notInConstant( OneLiner.BufferLine bufline, int end, BufferedWriter outWriter ) + throws TaskException { // N.B. both column and string index are zero-based // Process a string not part of a constant; @@ -922,7 +923,14 @@ public class FixCRLF extends MatchingTask } BufferLine tmpLine = new BufferLine( line.toString(), eolStr.toString() ); - nextLine(); + try + { + nextLine(); + } + catch( TaskException e ) + { + throw new NoSuchElementException(); + } return tmpLine; } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Javac.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Javac.java index a25188526..d984edc35 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Javac.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Javac.java @@ -831,17 +831,6 @@ public class Javac extends MatchingTask "javac1.4".equals( compiler ); } - /** - * Recreate src - * - * @return a nested src element. - */ - protected Path recreateSrc() - { - src = null; - return createSrc(); - } - /** * Clear the list of files to be compiled and copied.. */ diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Javadoc.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Javadoc.java index d5a992bbd..a1fb74ec8 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Javadoc.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Javadoc.java @@ -116,11 +116,13 @@ public class Javadoc extends Task * @param r The new BootClasspathRef value */ public void setBootClasspathRef( Reference r ) + throws TaskException { createBootclasspath().setRefid( r ); } public void setBootclasspath( Path src ) + throws TaskException { if( bootclasspath == null ) { @@ -145,6 +147,7 @@ public class Javadoc extends Task } public void setClasspath( Path src ) + throws TaskException { if( classpath == null ) { @@ -162,6 +165,7 @@ public class Javadoc extends Task * @param r The new ClasspathRef value */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -209,6 +213,7 @@ public class Javadoc extends Task } public void setDocletPathRef( Reference r ) + throws TaskException { if( doclet == null ) { @@ -445,6 +450,7 @@ public class Javadoc extends Task } public void setSourcepath( Path src ) + throws TaskException { if( sourcePath == null ) { @@ -462,6 +468,7 @@ public class Javadoc extends Task * @param r The new SourcepathRef value */ public void setSourcepathRef( Reference r ) + throws TaskException { createSourcepath().setRefid( r ); } @@ -557,11 +564,13 @@ public class Javadoc extends Task } public void addSource( SourceFile sf ) + throws TaskException { sourceFiles.addElement( sf ); } public Path createBootclasspath() + throws TaskException { if( bootclasspath == null ) { @@ -571,6 +580,7 @@ public class Javadoc extends Task } public Path createClasspath() + throws TaskException { if( classpath == null ) { @@ -600,6 +610,7 @@ public class Javadoc extends Task } public Path createSourcepath() + throws TaskException { if( sourcePath == null ) { @@ -956,6 +967,7 @@ public class Javadoc extends Task * @return Description of the Returned Value */ protected String expand( String content ) + throws TaskException { return project.replaceProperties( content ); } @@ -1242,6 +1254,7 @@ public class Javadoc extends Task } public void setPath( Path path ) + throws TaskException { if( this.path == null ) { @@ -1259,6 +1272,7 @@ public class Javadoc extends Task * @param r The new PathRef value */ public void setPathRef( Reference r ) + throws TaskException { createPath().setRefid( r ); } @@ -1287,6 +1301,7 @@ public class Javadoc extends Task } public Path createPath() + throws TaskException { if( path == null ) { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Manifest.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Manifest.java index 947889912..49fbc9902 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Manifest.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Manifest.java @@ -109,7 +109,7 @@ public class Manifest extends Task * @throws IOException if the manifest cannot be read from the reader. */ public Manifest( Reader r ) - throws ManifestException, IOException + throws ManifestException, TaskException, IOException { BufferedReader reader = new BufferedReader( r ); // This should be the manifest version @@ -239,7 +239,7 @@ public class Manifest extends Task } public void addConfiguredAttribute( Attribute attribute ) - throws ManifestException + throws ManifestException, TaskException { mainSection.addConfiguredAttribute( attribute ); } @@ -417,7 +417,7 @@ public class Manifest extends Task { write( new PrintWriter( sw ) ); } - catch( IOException e ) + catch( Exception e ) { return null; } @@ -431,7 +431,7 @@ public class Manifest extends Task * @throws IOException if the manifest cannot be written */ public void write( PrintWriter writer ) - throws IOException + throws IOException, TaskException { writer.println( ATTRIBUTE_MANIFEST_VERSION + ": " + manifestVersion ); String signatureVersion = mainSection.getAttributeValue( ATTRIBUTE_SIGNATURE_VERSION ); @@ -862,7 +862,7 @@ public class Manifest extends Task * @throws IOException if the section cannot be read from the reader. */ public String read( BufferedReader reader ) - throws ManifestException, IOException + throws ManifestException, IOException, TaskException { Attribute attribute = null; while( true ) diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Move.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Move.java index c71fa4c89..1a9268b6d 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Move.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Move.java @@ -47,6 +47,7 @@ public class Move extends Copy * @param d Description of Parameter */ protected void deleteDir( File d ) + throws TaskException { String[] list = d.list(); if( list == null ) @@ -77,6 +78,7 @@ public class Move extends Copy //************************************************************************ protected void doFileOperations() + throws TaskException { //Attempt complete directory renames, if any, first. if( completeDirMap.size() > 0 ) diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Parallel.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Parallel.java index 5f8cf0938..ac911515d 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Parallel.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Parallel.java @@ -98,11 +98,13 @@ public class Parallel extends Task { firstException = t; } + /* if( t instanceof TaskException && firstLocation == Location.UNKNOWN_LOCATION ) { firstLocation = ( (TaskException)t ).getLocation(); } + */ exceptionMessage.append( lSep ); exceptionMessage.append( t.getMessage() ); } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Patch.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Patch.java index 4a6e9709d..e579756f5 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Patch.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Patch.java @@ -68,6 +68,7 @@ public class Patch extends Task * @param file The new Patchfile value */ public void setPatchfile( File file ) + throws TaskException { if( !file.exists() ) { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/PathConvert.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/PathConvert.java index d844183c7..58b4f5c8c 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/PathConvert.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/PathConvert.java @@ -77,6 +77,7 @@ public class PathConvert extends Task * @param r The new Refid value */ public void setRefid( Reference r ) + throws TaskException { if( path != null ) throw noChildrenAllowed(); @@ -90,8 +91,8 @@ public class PathConvert extends Task * @param target The new Targetos value */ public void setTargetos( String target ) + throws TaskException { - targetOS = target.toLowerCase(); if( !targetOS.equals( "windows" ) && !target.equals( "unix" ) && @@ -139,8 +140,8 @@ public class PathConvert extends Task * @return Description of the Returned Value */ public Path createPath() + throws TaskException { - if( isReference() ) throw noChildrenAllowed(); @@ -159,7 +160,6 @@ public class PathConvert extends Task public void execute() throws TaskException { - // If we are a reference, the create a Path from the reference if( isReference() ) { @@ -238,8 +238,8 @@ public class PathConvert extends Task * @return String Updated element */ private String mapElement( String elem ) + throws TaskException { - int size = prefixMap.size(); if( size != 0 ) @@ -365,6 +365,7 @@ public class PathConvert extends Task * @return String Updated path element after mapping */ public String apply( String elem ) + throws TaskException { if( from == null || to == null ) { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Property.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Property.java index 645da4af7..bb4129199 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Property.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Property.java @@ -54,6 +54,7 @@ public class Property extends Task } public void setClasspath( Path classpath ) + throws TaskException { if( this.classpath == null ) { @@ -66,6 +67,7 @@ public class Property extends Task } public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -136,6 +138,7 @@ public class Property extends Task } public Path createClasspath() + throws TaskException { if( this.classpath == null ) { @@ -192,6 +195,7 @@ public class Property extends Task } protected void addProperties( Properties props ) + throws TaskException { resolveAllProperties( props ); Enumeration e = props.keys(); diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Rmic.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Rmic.java index 908512e1b..bc55a828b 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Rmic.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Rmic.java @@ -682,7 +682,6 @@ public class Rmic extends MatchingTask { String msg = "Failed to copy " + oldFile + " to " + newFile + " due to " + ioe.getMessage(); - newFile + " due to " + ioe.getMessage(); throw new TaskException( msg, ioe ); } } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/SQLExec.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/SQLExec.java index 6f80e8dc9..e04a5aa9e 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/SQLExec.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/SQLExec.java @@ -171,6 +171,7 @@ public class SQLExec extends Task * @param classpath The new Classpath value */ public void setClasspath( Path classpath ) + throws TaskException { if( this.classpath == null ) { @@ -188,6 +189,7 @@ public class SQLExec extends Task * @param r The new ClasspathRef value */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -364,6 +366,7 @@ public class SQLExec extends Task * @return Description of the Returned Value */ public Path createClasspath() + throws TaskException { if( this.classpath == null ) { @@ -739,7 +742,7 @@ public class SQLExec extends Task } protected void runStatements( Reader reader, PrintStream out ) - throws SQLException, IOException + throws SQLException, IOException, TaskException { String sql = ""; String line = ""; @@ -845,7 +848,7 @@ public class SQLExec extends Task } private void runTransaction( PrintStream out ) - throws IOException, SQLException + throws IOException, SQLException, TaskException { if( tSqlCommand.length() != 0 ) { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Tar.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Tar.java index 53c7b21f6..0dd6816ae 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Tar.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Tar.java @@ -222,7 +222,7 @@ public class Tar extends MatchingTask protected void tarFile( File file, TarOutputStream tOut, String vPath, TarFileSet tarFileSet ) - throws IOException + throws IOException, TaskException { FileInputStream fIn = null; @@ -341,6 +341,7 @@ public class Tar extends MatchingTask * for the project. */ public String[] getFiles( Project p ) + throws TaskException { if( files == null ) { @@ -380,7 +381,6 @@ public class Tar extends MatchingTask */ public static class TarLongFileMode extends EnumeratedAttribute { - // permissable values for longfile attribute public final static String WARN = "warn"; public final static String FAIL = "fail"; @@ -391,6 +391,7 @@ public class Tar extends MatchingTask private final String[] validModes = {WARN, FAIL, TRUNCATE, GNU, OMIT}; public TarLongFileMode() + throws TaskException { super(); setValue( WARN ); diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Tstamp.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Tstamp.java index 655b4919e..6c8ce5f0f 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Tstamp.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Tstamp.java @@ -153,6 +153,7 @@ public class Tstamp extends Task } public void setLocale( String locale ) + throws TaskException { StringTokenizer st = new StringTokenizer( locale, " \t\n\r\f," ); try @@ -207,6 +208,7 @@ public class Tstamp extends Task } public void execute( Project project, Date date, Location location ) + throws TaskException { if( propertyName == null ) { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Untar.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Untar.java index 0f98af71b..72cda75b4 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Untar.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Untar.java @@ -26,6 +26,7 @@ public class Untar extends Expand { protected void expandFile( FileUtils fileUtils, File srcF, File dir ) + throws TaskException { TarInputStream tis = null; try diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/UpToDate.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/UpToDate.java index 308fd768f..c0c63b9c3 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/UpToDate.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/UpToDate.java @@ -107,6 +107,7 @@ public class UpToDate extends MatchingTask implements Condition * @return Description of the Returned Value */ public boolean eval() + throws TaskException { if( sourceFileSets.size() == 0 ) { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/War.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/War.java index 328cf7e00..9e00d12f1 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/War.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/War.java @@ -33,6 +33,7 @@ public class War extends Jar } public void setWebxml( File descr ) + throws TaskException { deploymentDescriptor = descr; if( !deploymentDescriptor.exists() ) diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/XSLTProcess.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/XSLTProcess.java index 18332d0ef..25da76d77 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/XSLTProcess.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/XSLTProcess.java @@ -91,6 +91,7 @@ public class XSLTProcess extends MatchingTask implements XSLTLogger * @param classpath The new Classpath value */ public void setClasspath( Path classpath ) + throws TaskException { createClasspath().append( classpath ); } @@ -102,6 +103,7 @@ public class XSLTProcess extends MatchingTask implements XSLTLogger * @param r The new ClasspathRef value */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); }//-- setSourceDir @@ -191,6 +193,7 @@ public class XSLTProcess extends MatchingTask implements XSLTLogger * @return Description of the Returned Value */ public Path createClasspath() + throws TaskException { if( classpath == null ) { @@ -279,6 +282,7 @@ public class XSLTProcess extends MatchingTask implements XSLTLogger } protected XSLTLiaison getLiaison() + throws TaskException { // if processor wasn't specified, see if TraX is available. If not, // default it to xslp or xalan, depending on which is in the classpath diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java index 74fe6ef4c..ec8d66451 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java @@ -384,6 +384,7 @@ public abstract class DefaultCompilerAdapter implements CompilerAdapter * @return Description of the Returned Value */ protected int executeExternalCompile( String[] args, int firstFileName ) + throws TaskException { String[] commandArray = null; File tmpFile = null; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/condition/Http.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/condition/Http.java index de3eaabd4..eaabf8685 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/condition/Http.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/condition/Http.java @@ -21,7 +21,9 @@ import org.apache.tools.ant.ProjectComponent; * * @author Denis Hennessy */ -public class Http extends ProjectComponent implements Condition +public class Http + extends ProjectComponent + implements Condition { String spec = null; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/condition/Socket.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/condition/Socket.java index 3ecef0857..aa6aad3b9 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/condition/Socket.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/condition/Socket.java @@ -18,7 +18,9 @@ import org.apache.tools.ant.ProjectComponent; * * @author Denis Hennessy */ -public class Socket extends ProjectComponent implements Condition +public class Socket + extends ProjectComponent + implements Condition { String server = null; int port = 0; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/Rpm.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/Rpm.java index 0496befd0..c3ee51c8d 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/Rpm.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/Rpm.java @@ -100,6 +100,7 @@ public class Rpm extends Task } public void setSpecFile( String sf ) + throws TaskException { if( ( sf == null ) || ( sf.trim().equals( "" ) ) ) { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java index e2f8835b3..6f675e502 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java @@ -109,8 +109,8 @@ public class XMLValidateTask extends Task * @param classpath The new Classpath value */ public void setClasspath( Path classpath ) + throws TaskException { - if( this.classpath == null ) { this.classpath = classpath; @@ -126,6 +126,7 @@ public class XMLValidateTask extends Task * @see #setClasspath */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -202,6 +203,7 @@ public class XMLValidateTask extends Task * @see #setClasspath */ public Path createClasspath() + throws TaskException { if( this.classpath == null ) { @@ -319,6 +321,7 @@ public class XMLValidateTask extends Task * parse the file */ private void doValidate( File afile ) + throws TaskException { try { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java index 0ec54a977..61ec4f7e5 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java @@ -119,7 +119,7 @@ public class CCMCreateTask extends Continuus implements ExecuteStreamHandler * @exception IOException Description of Exception */ public void setProcessOutputStream( InputStream is ) - throws IOException + throws TaskException, IOException { String buffer = ""; diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java index 654b19ad9..12320fe9b 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java @@ -107,6 +107,7 @@ public abstract class Continuus extends Task } protected int run( Commandline cmd, ExecuteStreamHandler handler ) + throws TaskException { try { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/clearcase/ClearCase.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/clearcase/ClearCase.java index 941519ab8..0be5d35cc 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/clearcase/ClearCase.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/clearcase/ClearCase.java @@ -13,6 +13,7 @@ import org.apache.tools.ant.Task; import org.apache.tools.ant.taskdefs.Execute; import org.apache.tools.ant.taskdefs.LogStreamHandler; import org.apache.tools.ant.types.Commandline; +import java.io.IOException; /** * A base class for creating tasks for executing commands on ClearCase.
@@ -103,6 +104,7 @@ public abstract class ClearCase extends Task } protected int run( Commandline cmd ) + throws TaskException { try { @@ -113,7 +115,7 @@ public abstract class ClearCase extends Task exe.setCommandline( cmd.getCommandline() ); return exe.execute(); } - catch( java.io.IOException e ) + catch( IOException e ) { throw new TaskException( "Error", e ); } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/depend/Depend.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/depend/Depend.java index 80632df63..bc56cfe38 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/depend/Depend.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/depend/Depend.java @@ -105,6 +105,7 @@ public class Depend extends MatchingTask * @param classpath The new Classpath value */ public void setClasspath( Path classpath ) + throws TaskException { if( dependClasspath == null ) { @@ -122,6 +123,7 @@ public class Depend extends MatchingTask * @param r The new ClasspathRef value */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -178,6 +180,7 @@ public class Depend extends MatchingTask * @return Description of the Returned Value */ public Path createClasspath() + throws TaskException { if( dependClasspath == null ) { @@ -359,6 +362,7 @@ public class Depend extends MatchingTask * @return a vector containing the classes to analyse. */ private Vector getClassFiles( Path classLocations ) + throws TaskException { // break the classLocations into its components. String[] classLocationsList = classLocations.list(); diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/CSharp.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/CSharp.java index 305d521ab..e38dd7061 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/CSharp.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/CSharp.java @@ -280,6 +280,7 @@ public class CSharp */ public CSharp() + throws TaskException { Clear(); setIncludes( csc_file_pattern ); @@ -417,6 +418,7 @@ public class CSharp * @param path another path to append */ public void setReferenceFiles( Path path ) + throws TaskException { //demand create pathlist if( _referenceFiles == null ) diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/Ilasm.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/Ilasm.java index 1625cd28d..51bc8f7bd 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/Ilasm.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/Ilasm.java @@ -119,6 +119,7 @@ public class Ilasm * constructor inits everything and set up the search pattern */ public Ilasm() + throws TaskException { Clear(); setIncludes( file_pattern ); diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java index 0cd68c4de..6ed419a83 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java @@ -76,6 +76,7 @@ public class NetCommand */ public NetCommand( Task owner, String title, String program ) + throws TaskException { _owner = owner; _title = title; @@ -196,6 +197,7 @@ public class NetCommand * set up the command sequence.. */ protected void prepareExecutor() + throws TaskException { // default directory to the project's base directory File dir = _owner.getProject().getBaseDir(); diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ejb/BorlandGenerateClient.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ejb/BorlandGenerateClient.java index 52abf8e41..93e40100c 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ejb/BorlandGenerateClient.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ejb/BorlandGenerateClient.java @@ -55,6 +55,7 @@ public class BorlandGenerateClient extends Task Path classpath; public void setClasspath( Path classpath ) + throws TaskException { if( this.classpath == null ) { @@ -67,6 +68,7 @@ public class BorlandGenerateClient extends Task } public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -92,6 +94,7 @@ public class BorlandGenerateClient extends Task } public Path createClasspath() + throws TaskException { if( this.classpath == null ) { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jlink/JlinkTask.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jlink/JlinkTask.java index 4261a067f..df831e709 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jlink/JlinkTask.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jlink/JlinkTask.java @@ -59,6 +59,7 @@ public class JlinkTask extends MatchingTask * @param addfiles The new Addfiles value */ public void setAddfiles( Path addfiles ) + throws TaskException { if( this.addfiles == null ) { @@ -86,6 +87,7 @@ public class JlinkTask extends MatchingTask * @param mergefiles The new Mergefiles value */ public void setMergefiles( Path mergefiles ) + throws TaskException { if( this.mergefiles == null ) { @@ -113,6 +115,7 @@ public class JlinkTask extends MatchingTask * @return Description of the Returned Value */ public Path createAddfiles() + throws TaskException { if( this.addfiles == null ) { @@ -128,6 +131,7 @@ public class JlinkTask extends MatchingTask * @return Description of the Returned Value */ public Path createMergefiles() + throws TaskException { if( this.mergefiles == null ) { @@ -179,11 +183,13 @@ public class JlinkTask extends MatchingTask } private boolean haveAddFiles() + throws TaskException { return haveEntries( addfiles ); } private boolean haveEntries( Path p ) + throws TaskException { if( p == null ) { @@ -197,9 +203,9 @@ public class JlinkTask extends MatchingTask } private boolean haveMergeFiles() + throws TaskException { return haveEntries( mergefiles ); } - } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jsp/JspC.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jsp/JspC.java index 3ed023fae..cd4b6c626 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jsp/JspC.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jsp/JspC.java @@ -101,6 +101,7 @@ public class JspC extends MatchingTask * @param cp The new Classpath value */ public void setClasspath( Path cp ) + throws TaskException { if( classpath == null ) classpath = cp; @@ -114,6 +115,7 @@ public class JspC extends MatchingTask * @param r The new ClasspathRef value */ public void setClasspathRef( Reference r ) + throws TaskException { createClasspath().setRefid( r ); } @@ -187,6 +189,7 @@ public class JspC extends MatchingTask * @param srcDir The new Srcdir value */ public void setSrcdir( Path srcDir ) + throws TaskException { if( src == null ) { @@ -309,6 +312,7 @@ public class JspC extends MatchingTask * @return Description of the Returned Value */ public Path createClasspath() + throws TaskException { if( classpath == null ) classpath = new Path( project ); diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java index 0a9a1b07b..305008c69 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jsp/WLJspc.java @@ -74,6 +74,7 @@ public class WLJspc extends MatchingTask * @param classpath The new Classpath value */ public void setClasspath( Path classpath ) + throws TaskException { if( compileClasspath == null ) { @@ -92,7 +93,6 @@ public class WLJspc extends MatchingTask */ public void setDest( File dirName ) { - destinationDirectory = dirName; } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java index 09d01e098..80aca86c7 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java @@ -319,7 +319,7 @@ public class Pvcs extends org.apache.tools.ant.Task * build... */ public void execute() - throws org.apache.tools.ant.TaskException + throws TaskException { Project aProj = getProject(); int result = 0; @@ -446,6 +446,7 @@ public class Pvcs extends org.apache.tools.ant.Task } protected int runCmd( Commandline cmd, ExecuteStreamHandler out ) + throws TaskException { try { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java index 7dfcfdf5e..2d4d1c37d 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java @@ -200,6 +200,7 @@ public abstract class MSVSS extends Task } protected int run( Commandline cmd ) + throws TaskException { try { diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss/MSVSSHISTORY.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss/MSVSSHISTORY.java index dfea9efc5..aed5c49f4 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss/MSVSSHISTORY.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss/MSVSSHISTORY.java @@ -141,6 +141,7 @@ public class MSVSSHISTORY extends MSVSS * @param attr The new Style value */ public void setStyle( BriefCodediffNofile attr ) + throws TaskException { String option = attr.getValue(); if( option.equals( "brief" ) ) diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/rmic/DefaultRmicAdapter.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/rmic/DefaultRmicAdapter.java index 4ec600fbf..7c5691aa2 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/rmic/DefaultRmicAdapter.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/rmic/DefaultRmicAdapter.java @@ -10,6 +10,7 @@ package org.apache.tools.ant.taskdefs.rmic; import java.io.File; import java.util.Random; import java.util.Vector; +import org.apache.myrmidon.api.TaskException; import org.apache.tools.ant.Project; import org.apache.tools.ant.taskdefs.Rmic; import org.apache.tools.ant.types.Commandline; @@ -51,6 +52,7 @@ public abstract class DefaultRmicAdapter implements RmicAdapter * @return The Classpath value */ public Path getClasspath() + throws TaskException { return getCompileClasspath(); } @@ -77,6 +79,7 @@ public abstract class DefaultRmicAdapter implements RmicAdapter * @return Description of the Returned Value */ protected Commandline setupRmicCommand() + throws TaskException { return setupRmicCommand( null ); } @@ -88,6 +91,7 @@ public abstract class DefaultRmicAdapter implements RmicAdapter * @return Description of the Returned Value */ protected Commandline setupRmicCommand( String[] options ) + throws TaskException { Commandline cmd = new Commandline(); @@ -178,6 +182,7 @@ public abstract class DefaultRmicAdapter implements RmicAdapter * @return The CompileClasspath value */ protected Path getCompileClasspath() + throws TaskException { // add dest dir to classpath so that previously compiled and // untouched classes are on classpath diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/rmic/RmicAdapter.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/rmic/RmicAdapter.java index 0bfc26448..b5b97ba00 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/rmic/RmicAdapter.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/rmic/RmicAdapter.java @@ -57,5 +57,6 @@ public interface RmicAdapter * * @return The Classpath value */ - Path getClasspath(); + Path getClasspath() + throws TaskException; } diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/types/DataType.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/types/DataType.java index 494b1b940..19d4b421b 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/types/DataType.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/types/DataType.java @@ -92,12 +92,6 @@ public abstract class DataType return ref != null; } - public void execute() - throws TaskException - { - //HACK: NOOP execute - should be deleted in the future! - } - /** * Performs the check for circular references and returns the referenced * object. diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/util/FileNameMapper.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/util/FileNameMapper.java index 33ae65096..0c1d2b8bd 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/util/FileNameMapper.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/util/FileNameMapper.java @@ -7,6 +7,8 @@ */ package org.apache.tools.ant.util; +import org.apache.myrmidon.api.TaskException; + /** * Interface to be used by SourceFileScanner.
* @@ -27,7 +29,8 @@ public interface FileNameMapper * * @param from The new From value */ - void setFrom( String from ); + void setFrom( String from ) + throws TaskException; /** * Sets the to part of the transformation rule. diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/util/RegexpPatternMapper.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/util/RegexpPatternMapper.java index d2382c5a5..caf44ee4c 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/util/RegexpPatternMapper.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/util/RegexpPatternMapper.java @@ -69,9 +69,9 @@ public class RegexpPatternMapper implements FileNameMapper * @return Description of the Returned Value */ public String[] mapFileName( String sourceFileName ) + throws TaskException { - if( reg == null || to == null - || !reg.matches( sourceFileName ) ) + if( reg == null || to == null || !reg.matches( sourceFileName ) ) { return null; } @@ -86,6 +86,7 @@ public class RegexpPatternMapper implements FileNameMapper * @return Description of the Returned Value */ protected String replaceReferences( String source ) + throws TaskException { Vector v = reg.getGroups( source );