From b32ff5e9c451cb49b5b8c24b6cdda9c94bc9d1a2 Mon Sep 17 00:00:00 2001
From: Stefan Bodewig <bodewig@apache.org>
Date: Tue, 2 Apr 2002 14:59:43 +0000
Subject: [PATCH] only warn if override changes the value of a reference.

PR: 5161


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@272166 13f79535-47bb-0310-9956-ffa450edef68
---
 src/main/org/apache/tools/ant/Project.java | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/main/org/apache/tools/ant/Project.java b/src/main/org/apache/tools/ant/Project.java
index 22881f2f4..0274e8385 100644
--- a/src/main/org/apache/tools/ant/Project.java
+++ b/src/main/org/apache/tools/ant/Project.java
@@ -1639,7 +1639,12 @@ public class Project {
      * @param value The value of the reference. Must not be <code>null</code>.
      */
     public void addReference(String name, Object value) {
-        if (null != references.get(name)) {
+        Object old = references.get(name);
+        if (old == value) {
+            // no warning, this is not changing anything
+            return;
+        }
+        if (old != null) {
             log("Overriding previous definition of reference to " + name, 
                 MSG_WARN);
         }