From b0d9f8aa0137890a06875525db92bf44decfa512 Mon Sep 17 00:00:00 2001 From: Stefan Bodewig Date: Mon, 23 Aug 2010 11:57:37 +0000 Subject: [PATCH] NPE in Project.setDefault. PR 49803 git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@988095 13f79535-47bb-0310-9956-ffa450edef68 --- WHATSNEW | 4 ++++ src/main/org/apache/tools/ant/Project.java | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/WHATSNEW b/WHATSNEW index ebf7115a9..d865037bf 100644 --- a/WHATSNEW +++ b/WHATSNEW @@ -138,6 +138,10 @@ Fixed bugs: from a resource or string explicitly. Bugzilla Report 49587. + * Project#setDefault threw an excpetion when null was passed in as + argument, even though the javadoc says, null is a valid value. + Bugzilla Report 49803. + Other changes: -------------- diff --git a/src/main/org/apache/tools/ant/Project.java b/src/main/org/apache/tools/ant/Project.java index 843e81093..27f5f3289 100644 --- a/src/main/org/apache/tools/ant/Project.java +++ b/src/main/org/apache/tools/ant/Project.java @@ -729,7 +729,9 @@ public class Project implements ResourceFactory { * no default target. */ public void setDefault(String defaultTarget) { - setUserProperty(MagicNames.PROJECT_DEFAULT_TARGET, defaultTarget); + if (defaultTarget != null) { + setUserProperty(MagicNames.PROJECT_DEFAULT_TARGET, defaultTarget); + } this.defaultTarget = defaultTarget; }