From a7b64a73db2f1c58319894bdbbcfbc97384df4df Mon Sep 17 00:00:00 2001
From: Stefan Bodewig <bodewig@apache.org>
Date: Tue, 18 Aug 2009 15:44:32 +0000
Subject: [PATCH] the update attribute of the modified selector was ignored. 
 PR 32597

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@805463 13f79535-47bb-0310-9956-ffa450edef68
---
 WHATSNEW                                      |  3 +
 .../modifiedselector/ModifiedSelector.java    |  2 -
 .../antunit/types/selectors/modified-test.xml | 76 +++++++++++++++++++
 3 files changed, 79 insertions(+), 2 deletions(-)
 create mode 100644 src/tests/antunit/types/selectors/modified-test.xml

diff --git a/WHATSNEW b/WHATSNEW
index 48aa35a0e..c24d3aebd 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -436,6 +436,9 @@ Fixed bugs:
    separator other than "/".
    Bugzilla Report 35649.
 
+ * The update attribute of the modified selector was ignored.
+   Bugzilla Report 32597.
+
 Other changes:
 --------------
  * The get task now also follows redirects from http to https
diff --git a/src/main/org/apache/tools/ant/types/selectors/modifiedselector/ModifiedSelector.java b/src/main/org/apache/tools/ant/types/selectors/modifiedselector/ModifiedSelector.java
index 9fa8c6875..049e127e1 100644
--- a/src/main/org/apache/tools/ant/types/selectors/modifiedselector/ModifiedSelector.java
+++ b/src/main/org/apache/tools/ant/types/selectors/modifiedselector/ModifiedSelector.java
@@ -298,8 +298,6 @@ public class ModifiedSelector extends BaseExtendSelector
         Cache      defaultCache      = new PropertiesfileCache(cachefile);
         Algorithm  defaultAlgorithm  = new DigestAlgorithm();
         Comparator defaultComparator = new EqualComparator();
-        update = true;
-        selectDirectories = true;
 
         //
         // -----  Set the main attributes, pattern '*'  -----
diff --git a/src/tests/antunit/types/selectors/modified-test.xml b/src/tests/antunit/types/selectors/modified-test.xml
new file mode 100644
index 000000000..a4c43e043
--- /dev/null
+++ b/src/tests/antunit/types/selectors/modified-test.xml
@@ -0,0 +1,76 @@
+<?xml version="1.0"?>
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+<project xmlns:au="antlib:org.apache.ant.antunit" default="antunit">
+
+  <import file="../../antunit-base.xml" />
+
+  <target name="tearDown" depends="antunit-base.tearDown">
+    <delete file="cache.properties" quiet="true"/>
+  </target>
+
+  <target name="testUpdate"
+          description="https://issues.apache.org/bugzilla/show_bug.cgi?id=32597">
+    <mkdir dir="${input}"/>
+    <touch file="${input}/A"/>
+    <mkdir dir="${output}"/>
+    <pathconvert>
+      <fileset dir="${input}">
+        <modified/>
+      </fileset>
+    </pathconvert>
+    <au:assertFileExists file="cache.properties"/>
+    <copy todir="${output}" file="cache.properties"/>
+    <echo file="${input}/A">Hello</echo>
+    <pathconvert>
+      <fileset dir="${input}">
+        <modified update="false"/>
+      </fileset>
+    </pathconvert>
+    <au:assertFilesMatch
+       expected="${output}/cache.properties"
+       actual="cache.properties"/>
+    <pathconvert>
+      <fileset dir="${input}">
+        <modified>
+          <param name="update" value="false"/>
+        </modified>
+      </fileset>
+    </pathconvert>
+    <au:assertFilesMatch
+       expected="${output}/cache.properties"
+       actual="cache.properties"/>
+    <pathconvert>
+      <fileset dir="${input}">
+        <modified update="true"/>
+      </fileset>
+    </pathconvert>
+    <au:assertFilesDiffer
+       expected="${output}/cache.properties"
+       actual="cache.properties"/>
+    <copy todir="${output}" file="cache.properties"/>
+    <echo file="${input}/A">world</echo>
+    <pathconvert>
+      <fileset dir="${input}">
+        <modified update="true"/>
+      </fileset>
+    </pathconvert>
+    <au:assertFilesDiffer
+       expected="${output}/cache.properties"
+       actual="cache.properties"/>
+  </target>
+</project>