Browse Source

Fixed bug reported by Wolfgang Brodowski.

Bug report 39345.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@397303 13f79535-47bb-0310-9956-ffa450edef68
master
Jacobus Martinus Kruithof 19 years ago
parent
commit
a4e51d3b27
2 changed files with 11 additions and 3 deletions
  1. +1
    -0
      WHATSNEW
  2. +10
    -3
      src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java

+ 1
- 0
WHATSNEW View File

@@ -85,6 +85,7 @@ Changes that could break older environments:


Fixed bugs: Fixed bugs:
----------- -----------
* <rpm> now also correctly searches the first element of the path. Bug report 39345.


* ant.bat now handles classpath set to "". Bug report 38914. * ant.bat now handles classpath set to "". Bug report 38914.




+ 10
- 3
src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java View File

@@ -1,5 +1,5 @@
/* /*
* Copyright 2001-2005 The Apache Software Foundation
* Copyright 2001-20056 The Apache Software Foundation
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -43,6 +43,11 @@ import org.apache.tools.ant.types.Path;
*/ */
public class Rpm extends Task { public class Rpm extends Task {


private static final String PATH1 = "PATH=";
private static final String PATH2 = "Path=";
private static final String PATH3 = "path=";
private static final int PATH_LEN = PATH1.length();

/** /**
* the spec file * the spec file
*/ */
@@ -300,6 +305,8 @@ public class Rpm extends Task {
* the absolute path to it - falls back to <code>rpm</code> * the absolute path to it - falls back to <code>rpm</code>
* otherwise. * otherwise.
* *
* @return the command used to build RPM's
*
* @since 1.6 * @since 1.6
*/ */
protected String guessRpmBuildCommand() { protected String guessRpmBuildCommand() {
@@ -307,8 +314,8 @@ public class Rpm extends Task {
String path = null; String path = null;
for (Enumeration e = env.elements(); e.hasMoreElements();) { for (Enumeration e = env.elements(); e.hasMoreElements();) {
String var = (String) e.nextElement(); String var = (String) e.nextElement();
if (var.startsWith("PATH=") || var.startsWith("Path=")) {
path = var.substring(6 /* "PATH=".length() + 1 */);
if (var.startsWith(PATH1) || var.startsWith(PATH2) || var.startsWith(PATH3)) {
path = var.substring(PATH_LEN);
break; break;
} }
} }


Loading…
Cancel
Save