Browse Source

Cleaned up code and gradually moving towards myrmidon patterns

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@270365 13f79535-47bb-0310-9956-ffa450edef68
master
Peter Donald 23 years ago
parent
commit
96f9a81fa6
8 changed files with 436 additions and 710 deletions
  1. +2
    -1
      proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc/AccessType.java
  2. +5
    -6
      proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc/DocletInfo.java
  3. +2
    -2
      proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc/DocletParam.java
  4. +209
    -346
      proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc/Javadoc.java
  5. +2
    -1
      proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc/AccessType.java
  6. +5
    -6
      proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc/DocletInfo.java
  7. +2
    -2
      proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc/DocletParam.java
  8. +209
    -346
      proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc/Javadoc.java

+ 2
- 1
proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc/AccessType.java View File

@@ -9,7 +9,8 @@ package org.apache.tools.ant.taskdefs.javadoc;


import org.apache.tools.ant.types.EnumeratedAttribute; import org.apache.tools.ant.types.EnumeratedAttribute;


public class AccessType extends EnumeratedAttribute
public class AccessType
extends EnumeratedAttribute
{ {
public String[] getValues() public String[] getValues()
{ {


+ 5
- 6
proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc/DocletInfo.java View File

@@ -19,12 +19,12 @@ public class DocletInfo
private String m_name; private String m_name;
private Path m_path; private Path m_path;


public void setName( String name )
public void setName( final String name )
{ {
m_name = name; m_name = name;
} }


public void setPath( Path path )
public void setPath( final Path path )
throws TaskException throws TaskException
{ {
if( m_path == null ) if( m_path == null )
@@ -42,10 +42,10 @@ public class DocletInfo
* *
* @param r The new PathRef value * @param r The new PathRef value
*/ */
public void setPathRef( Reference r )
public void setPathRef( final Reference reference )
throws TaskException throws TaskException
{ {
createPath().setRefid( r );
createPath().setRefid( reference );
} }


public String getName() public String getName()
@@ -65,9 +65,8 @@ public class DocletInfo


public DocletParam createParam() public DocletParam createParam()
{ {
DocletParam param = new DocletParam();
final DocletParam param = new DocletParam();
m_params.add( param ); m_params.add( param );

return param; return param;
} }




+ 2
- 2
proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc/DocletParam.java View File

@@ -12,12 +12,12 @@ public class DocletParam
private String m_name; private String m_name;
private String m_value; private String m_value;


public void setName( String name )
public void setName( final String name )
{ {
this.m_name = name; this.m_name = name;
} }


public void setValue( String value )
public void setValue( final String value )
{ {
this.m_value = value; this.m_value = value;
} }


+ 209
- 346
proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc/Javadoc.java
File diff suppressed because it is too large
View File


+ 2
- 1
proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc/AccessType.java View File

@@ -9,7 +9,8 @@ package org.apache.tools.ant.taskdefs.javadoc;


import org.apache.tools.ant.types.EnumeratedAttribute; import org.apache.tools.ant.types.EnumeratedAttribute;


public class AccessType extends EnumeratedAttribute
public class AccessType
extends EnumeratedAttribute
{ {
public String[] getValues() public String[] getValues()
{ {


+ 5
- 6
proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc/DocletInfo.java View File

@@ -19,12 +19,12 @@ public class DocletInfo
private String m_name; private String m_name;
private Path m_path; private Path m_path;


public void setName( String name )
public void setName( final String name )
{ {
m_name = name; m_name = name;
} }


public void setPath( Path path )
public void setPath( final Path path )
throws TaskException throws TaskException
{ {
if( m_path == null ) if( m_path == null )
@@ -42,10 +42,10 @@ public class DocletInfo
* *
* @param r The new PathRef value * @param r The new PathRef value
*/ */
public void setPathRef( Reference r )
public void setPathRef( final Reference reference )
throws TaskException throws TaskException
{ {
createPath().setRefid( r );
createPath().setRefid( reference );
} }


public String getName() public String getName()
@@ -65,9 +65,8 @@ public class DocletInfo


public DocletParam createParam() public DocletParam createParam()
{ {
DocletParam param = new DocletParam();
final DocletParam param = new DocletParam();
m_params.add( param ); m_params.add( param );

return param; return param;
} }




+ 2
- 2
proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc/DocletParam.java View File

@@ -12,12 +12,12 @@ public class DocletParam
private String m_name; private String m_name;
private String m_value; private String m_value;


public void setName( String name )
public void setName( final String name )
{ {
this.m_name = name; this.m_name = name;
} }


public void setValue( String value )
public void setValue( final String value )
{ {
this.m_value = value; this.m_value = value;
} }


+ 209
- 346
proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc/Javadoc.java
File diff suppressed because it is too large
View File


Loading…
Cancel
Save