From 8a402eea3a2a040ac760a2638ab15b3f2baf81ef Mon Sep 17 00:00:00 2001 From: Arturo Bernal Date: Tue, 31 Aug 2021 20:50:31 +0200 Subject: [PATCH] Change StringBuffer in favor of StringBuilder. --- src/main/org/apache/tools/ant/filters/BaseFilterReader.java | 2 +- src/main/org/apache/tools/ant/filters/TokenFilter.java | 4 ++-- src/main/org/apache/tools/ant/taskdefs/KeySubst.java | 2 +- src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java | 2 +- src/main/org/apache/tools/ant/taskdefs/Redirector.java | 2 +- .../org/apache/tools/ant/taskdefs/optional/TraXLiaison.java | 2 +- .../org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java | 2 +- src/main/org/apache/tools/ant/util/FileUtils.java | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/org/apache/tools/ant/filters/BaseFilterReader.java b/src/main/org/apache/tools/ant/filters/BaseFilterReader.java index fdb64162c..bc97d1bbb 100644 --- a/src/main/org/apache/tools/ant/filters/BaseFilterReader.java +++ b/src/main/org/apache/tools/ant/filters/BaseFilterReader.java @@ -173,7 +173,7 @@ public abstract class BaseFilterReader extends FilterReader { return null; } - StringBuffer line = new StringBuffer(); + final StringBuilder line = new StringBuilder(); while (ch != -1) { line.append((char) ch); diff --git a/src/main/org/apache/tools/ant/filters/TokenFilter.java b/src/main/org/apache/tools/ant/filters/TokenFilter.java index 441cf9df2..67c9283df 100644 --- a/src/main/org/apache/tools/ant/filters/TokenFilter.java +++ b/src/main/org/apache/tools/ant/filters/TokenFilter.java @@ -370,7 +370,7 @@ public class TokenFilter extends BaseFilterReader if (from == null) { throw new BuildException("Missing from in stringreplace"); } - StringBuffer ret = new StringBuffer(); + final StringBuilder ret = new StringBuilder(); int start = 0; int found = line.indexOf(from); while (found >= 0) { @@ -620,7 +620,7 @@ public class TokenFilter extends BaseFilterReader * @return the converted string */ public String filter(String string) { - StringBuffer output = new StringBuffer(string.length()); + StringBuilder output = new StringBuilder(string.length()); for (int i = 0; i < string.length(); ++i) { char ch = string.charAt(i); if (!(isDeleteCharacter(ch))) { diff --git a/src/main/org/apache/tools/ant/taskdefs/KeySubst.java b/src/main/org/apache/tools/ant/taskdefs/KeySubst.java index 642486878..a6961bd40 100644 --- a/src/main/org/apache/tools/ant/taskdefs/KeySubst.java +++ b/src/main/org/apache/tools/ant/taskdefs/KeySubst.java @@ -167,7 +167,7 @@ public class KeySubst extends Task { */ public static String replace(String origString, Hashtable keys) throws BuildException { - StringBuffer finalString = new StringBuffer(); + final StringBuilder finalString = new StringBuilder(); int index = 0; int i = 0; String key = null; diff --git a/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java b/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java index 62237ef82..d6b3f6fbb 100644 --- a/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java +++ b/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java @@ -188,7 +188,7 @@ public class RecorderEntry implements BuildLogger, SubBuildListener { public void messageLogged(BuildEvent event) { log("--- MESSAGE LOGGED", Project.MSG_DEBUG); - StringBuffer buf = new StringBuffer(); + final StringBuilder buf = new StringBuilder(); if (event.getTask() != null) { String name = event.getTask().getTaskName(); diff --git a/src/main/org/apache/tools/ant/taskdefs/Redirector.java b/src/main/org/apache/tools/ant/taskdefs/Redirector.java index 9950e9a05..2ca7bd0fd 100644 --- a/src/main/org/apache/tools/ant/taskdefs/Redirector.java +++ b/src/main/org/apache/tools/ant/taskdefs/Redirector.java @@ -704,7 +704,7 @@ public class Redirector { } ((ConcatFileInputStream) inputStream).setManagingComponent(managingTask); } else if (inputString != null) { - final StringBuffer buf = new StringBuffer("Using input "); + final StringBuilder buf = new StringBuilder("Using input "); if (logInputString) { buf.append('"').append(inputString).append('"'); } else { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java b/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java index 5b71ae5cf..1be941ce7 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java @@ -550,7 +550,7 @@ public class TraXLiaison implements XSLTLiaison4, ErrorListener, XSLTLoggerAware return; } - final StringBuffer msg = new StringBuffer(); + final StringBuilder msg = new StringBuilder(); final SourceLocator locator = e.getLocator(); if (locator != null) { final String systemid = locator.getSystemId(); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java b/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java index c174b3453..64486047c 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java @@ -745,7 +745,7 @@ public abstract class MSVSS extends Task implements MSVSSConstants { * @return The command line as a string with out the password */ private String formatCommandLine(Commandline cmd) { - StringBuffer sBuff = new StringBuffer(cmd.toString()); + final StringBuilder sBuff = new StringBuilder(cmd.toString()); int indexUser = sBuff.substring(0).indexOf(FLAG_LOGIN); if (indexUser > 0) { int indexPass = sBuff.substring(0).indexOf(",", indexUser); diff --git a/src/main/org/apache/tools/ant/util/FileUtils.java b/src/main/org/apache/tools/ant/util/FileUtils.java index 52c662541..6a972e079 100644 --- a/src/main/org/apache/tools/ant/util/FileUtils.java +++ b/src/main/org/apache/tools/ant/util/FileUtils.java @@ -822,7 +822,7 @@ public class FileUtils { //remove the initial separator; the root has it. next = (ca[next] == sep) ? next + 1 : next; - StringBuffer sbPath = new StringBuffer(); + final StringBuilder sbPath = new StringBuilder(); // Eliminate consecutive slashes after the drive spec: for (int i = next; i < ca.length; i++) { if (ca[i] != sep || ca[i - 1] != sep) {