No need for tasks to know about their wrappers - thats a concern of the container.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@270180 13f79535-47bb-0310-9956-ffa450edef68

proposal/myrmidon/src/main/org/apache/tools/ant/RuntimeConfigurable.java

@@ -125,8 +125,6 @@ public class RuntimeConfigurable
             if( child.wrappedObject instanceof Task )
             {
                 Task childTask = (Task)child.wrappedObject;
-                childTask.setRuntimeConfigurableWrapper( child );
-                childTask.maybeConfigure();
             }
             else
             {

proposal/myrmidon/src/main/org/apache/tools/ant/Task.java

@@ -16,7 +16,6 @@ public abstract class Task
     protected Target target;
     protected String description;
     protected String taskType;
-    protected RuntimeConfigurable wrapper;
 
     /**
      * Sets a description of the current action. It will be usefull in
@@ -53,21 +52,6 @@ public abstract class Task
     {
         return target;
     }
-
-    /**
-     * Returns the wrapper class for runtime configuration.
-     *
-     * @return The RuntimeConfigurableWrapper value
-     */
-    public RuntimeConfigurable getRuntimeConfigurableWrapper()
-    {
-        if( wrapper == null )
-        {
-            wrapper = new RuntimeConfigurable( this, getName() );
-        }
-        return wrapper;
-    }
-
     /**
      * Perform this task
      */
@@ -146,15 +130,6 @@ public abstract class Task
     public void maybeConfigure()
         throws TaskException
     {
-        if( wrapper != null )
-        {
-            wrapper.maybeConfigure( project );
-        }
-    }
-
-    protected void setRuntimeConfigurableWrapper( RuntimeConfigurable wrapper )
-    {
-        this.wrapper = wrapper;
     }
 
     protected void handleErrorOutput( String line )

proposal/myrmidon/src/main/org/apache/tools/ant/UnknownElement.java

@@ -103,25 +103,6 @@ public class UnknownElement extends Task
     public void maybeConfigure()
         throws TaskException
     {
-        realThing = makeObject( this, wrapper );
-
-        wrapper.setProxy( realThing );
-        if( realThing instanceof Task )
-        {
-            ( (Task)realThing ).setRuntimeConfigurableWrapper( wrapper );
-        }
-
-        handleChildren( realThing, wrapper );
-
-        wrapper.maybeConfigure( project );
-        if( realThing instanceof Task )
-        {
-            target.replaceChild( this, realThing );
-        }
-        else
-        {
-            target.replaceChild( this, wrapper );
-        }
     }
 
     protected BuildException getNotFoundException( String what,
@@ -182,10 +163,6 @@ public class UnknownElement extends Task
             }
 
             childWrapper.setProxy( realChild );
-            if( parent instanceof TaskContainer )
-            {
-                ( (Task)realChild ).setRuntimeConfigurableWrapper( childWrapper );
-            }
 
             child.handleChildren( realChild, childWrapper );
 

proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Property.java

@@ -116,11 +116,6 @@ public class Property extends Task
         return file;
     }
 
-    public String getName()
-    {
-        return name;
-    }
-
     public Reference getRefid()
     {
         return ref;

proposal/myrmidon/src/todo/org/apache/tools/ant/RuntimeConfigurable.java

@@ -125,8 +125,6 @@ public class RuntimeConfigurable
             if( child.wrappedObject instanceof Task )
             {
                 Task childTask = (Task)child.wrappedObject;
-                childTask.setRuntimeConfigurableWrapper( child );
-                childTask.maybeConfigure();
             }
             else
             {

proposal/myrmidon/src/todo/org/apache/tools/ant/Task.java

@@ -16,7 +16,6 @@ public abstract class Task
     protected Target target;
     protected String description;
     protected String taskType;
-    protected RuntimeConfigurable wrapper;
 
     /**
      * Sets a description of the current action. It will be usefull in
@@ -53,21 +52,6 @@ public abstract class Task
     {
         return target;
     }
-
-    /**
-     * Returns the wrapper class for runtime configuration.
-     *
-     * @return The RuntimeConfigurableWrapper value
-     */
-    public RuntimeConfigurable getRuntimeConfigurableWrapper()
-    {
-        if( wrapper == null )
-        {
-            wrapper = new RuntimeConfigurable( this, getName() );
-        }
-        return wrapper;
-    }
-
     /**
      * Perform this task
      */
@@ -146,15 +130,6 @@ public abstract class Task
     public void maybeConfigure()
         throws TaskException
     {
-        if( wrapper != null )
-        {
-            wrapper.maybeConfigure( project );
-        }
-    }
-
-    protected void setRuntimeConfigurableWrapper( RuntimeConfigurable wrapper )
-    {
-        this.wrapper = wrapper;
     }
 
     protected void handleErrorOutput( String line )

proposal/myrmidon/src/todo/org/apache/tools/ant/UnknownElement.java

@@ -103,25 +103,6 @@ public class UnknownElement extends Task
     public void maybeConfigure()
         throws TaskException
     {
-        realThing = makeObject( this, wrapper );
-
-        wrapper.setProxy( realThing );
-        if( realThing instanceof Task )
-        {
-            ( (Task)realThing ).setRuntimeConfigurableWrapper( wrapper );
-        }
-
-        handleChildren( realThing, wrapper );
-
-        wrapper.maybeConfigure( project );
-        if( realThing instanceof Task )
-        {
-            target.replaceChild( this, realThing );
-        }
-        else
-        {
-            target.replaceChild( this, wrapper );
-        }
     }
 
     protected BuildException getNotFoundException( String what,
@@ -182,10 +163,6 @@ public class UnknownElement extends Task
             }
 
             childWrapper.setProxy( realChild );
-            if( parent instanceof TaskContainer )
-            {
-                ( (Task)realChild ).setRuntimeConfigurableWrapper( childWrapper );
-            }
 
             child.handleChildren( realChild, childWrapper );
 

proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/Property.java

@@ -116,11 +116,6 @@ public class Property extends Task
         return file;
     }
 
-    public String getName()
-    {
-        return name;
-    }
-
     public Reference getRefid()
     {
         return ref;