Browse Source

try-with-resources

master
Stefan Bodewig 8 years ago
parent
commit
851a0b2086
3 changed files with 4 additions and 14 deletions
  1. +2
    -6
      src/main/org/apache/tools/ant/taskdefs/optional/depend/DirectoryIterator.java
  2. +1
    -4
      src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java
  3. +1
    -4
      src/main/org/apache/tools/ant/types/resources/ResourceList.java

+ 2
- 6
src/main/org/apache/tools/ant/taskdefs/optional/depend/DirectoryIterator.java View File

@@ -130,10 +130,8 @@ public class DirectoryIterator implements ClassFileIterator {
} else { } else {


// we have a file. create a stream for it // we have a file. create a stream for it
FileInputStream inFileStream
= new FileInputStream(element);

try {
try (FileInputStream inFileStream
= new FileInputStream(element)) {
if (element.getName().endsWith(".class")) { if (element.getName().endsWith(".class")) {


// create a data input stream from the jar // create a data input stream from the jar
@@ -144,8 +142,6 @@ public class DirectoryIterator implements ClassFileIterator {


nextElement = javaClass; nextElement = javaClass;
} }
} finally {
inFileStream.close();
} }
} }
} else { } else {


+ 1
- 4
src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java View File

@@ -222,8 +222,7 @@ public class jlink {
if (!f.exists()) { if (!f.exists()) {
return; return;
} }
ZipFile zipf = new ZipFile(f);
try {
try (ZipFile zipf = new ZipFile(f)) {
Enumeration entries = zipf.entries(); Enumeration entries = zipf.entries();


while (entries.hasMoreElements()) { while (entries.hasMoreElements()) {
@@ -268,8 +267,6 @@ public class jlink {
output.closeEntry(); output.closeEntry();
} }
} }
} finally {
zipf.close();
} }
} }




+ 1
- 4
src/main/org/apache/tools/ant/types/resources/ResourceList.java View File

@@ -196,16 +196,13 @@ public class ResourceList extends DataType implements ResourceCollection {
crh.setFilterChains(filterChains); crh.setFilterChains(filterChains);
crh.setProject(getProject()); crh.setProject(getProject());
Union streamResources = new Union(); Union streamResources = new Union();
BufferedReader reader = new BufferedReader(crh.getAssembledReader());
try {
try (BufferedReader reader = new BufferedReader(crh.getAssembledReader())) {
streamResources.setCache(true); streamResources.setCache(true);


String line = null; String line = null;
while ((line = reader.readLine()) != null) { while ((line = reader.readLine()) != null) {
streamResources.add(parse(line)); streamResources.add(parse(line));
} }
} finally {
reader.close();
} }


return streamResources; return streamResources;


Loading…
Cancel
Save