From 843de6102d7ae66b3505cb5769938583bb42bd08 Mon Sep 17 00:00:00 2001
From: Stefan Bodewig <bodewig@apache.org>
Date: Fri, 6 Oct 2000 12:49:08 +0000
Subject: [PATCH] Make the system call a little bit more secure.

Submitted by:	Olivier Louchart-Fletcher <olivier.louchart@netregistry.au.com>


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@268070 13f79535-47bb-0310-9956-ffa450edef68
---
 src/bin/runant.pl | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/bin/runant.pl b/src/bin/runant.pl
index 3557254ee..2d0e5b7ff 100644
--- a/src/bin/runant.pl
+++ b/src/bin/runant.pl
@@ -102,20 +102,21 @@ else
 	}
 
 #jikes
-my $ANT_OPTS=$ENV{ANT_OPTS};
+my @ANT_OPTS=split $ENV{ANT_OPTS};
 if($ENV{JIKESPATH} ne "")
 	{
-	$ANT_OPTS.=" -Djikes.class.path=$ENV{JIKESPATH}";
+	push @ANT_OPTS, "-Djikes.class.path=$ENV{JIKESPATH}";
 	}
 
 #construct arguments to java
 
-my $METHOD = "org.apache.tools.ant.Main";
-my $ARGS = "@ARGV";
-my $JAVAPARAMS = "-classpath $localpath -Dant.home=$HOME ";
-my $COMMAND = "$JAVACMD $JAVAPARAMS $ANT_OPTS $METHOD $ARGS" ;
+my @ARGS;
+push @ARGS, "-classpath", "$localpath", "-Dant.home=$HOME";
+push @ARGS, @ANT_OPTS;
+push @ARGS, "org.apache.tools.ant.Main";
+push @ARGS, @ARGV;
 
-print "\n $COMMAND\n\n" if ($debug);
-system $COMMAND;
+print "\n $JAVACMD @ARGS\n\n" if ($debug);
+system $JAVACMD, @ARGS;