From 819831f11e97e6dc4e8de64b121b85f5fa2f452b Mon Sep 17 00:00:00 2001
From: Peter Donald <donaldp@apache.org>
Date: Sat, 2 Feb 2002 05:58:21 +0000
Subject: [PATCH] Move DefaultProject into builder directory as that is the
 only place it is used. This is cleaning up the interdependencies between
 container components..

Detected by JDepend


git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271059 13f79535-47bb-0310-9956-ffa450edef68
---
 .../{model => builder}/DefaultProject.java        |  2 +-
 .../components/builder/DefaultProjectBuilder.java | 15 +++++++++------
 .../components/builder/Resources.properties       |  3 +++
 .../components/model/Resources.properties         |  2 --
 4 files changed, 13 insertions(+), 9 deletions(-)
 rename proposal/myrmidon/src/java/org/apache/myrmidon/components/{model => builder}/DefaultProject.java (99%)
 delete mode 100644 proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Resources.properties

diff --git a/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/DefaultProject.java b/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProject.java
similarity index 99%
rename from proposal/myrmidon/src/java/org/apache/myrmidon/components/model/DefaultProject.java
rename to proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProject.java
index 709004ac5..710a33b8e 100644
--- a/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/DefaultProject.java
+++ b/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProject.java
@@ -5,7 +5,7 @@
  * version 1.1, a copy of which has been included with this distribution in
  * the LICENSE.txt file.
  */
-package org.apache.myrmidon.components.model;
+package org.apache.myrmidon.components.builder;
 
 import java.io.File;
 import java.util.ArrayList;
diff --git a/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProjectBuilder.java b/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProjectBuilder.java
index cdafc132e..b146b865d 100644
--- a/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProjectBuilder.java
+++ b/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProjectBuilder.java
@@ -17,13 +17,11 @@ import org.apache.avalon.excalibur.i18n.ResourceManager;
 import org.apache.avalon.excalibur.i18n.Resources;
 import org.apache.avalon.excalibur.util.StringUtil;
 import org.apache.avalon.framework.CascadingException;
-
 import org.apache.avalon.framework.Version;
 import org.apache.avalon.framework.configuration.Configuration;
 import org.apache.avalon.framework.configuration.ConfigurationException;
 import org.apache.avalon.framework.configuration.SAXConfigurationHandler;
 import org.apache.avalon.framework.logger.AbstractLogEnabled;
-import org.apache.myrmidon.components.model.DefaultProject;
 import org.apache.myrmidon.framework.Condition;
 import org.apache.myrmidon.interfaces.builder.ProjectBuilder;
 import org.apache.myrmidon.interfaces.model.Project;
@@ -263,9 +261,11 @@ public class DefaultProjectBuilder
                 }
             }
 
-            if( name.equals( "target" ) ) {
+            if( name.equals( "target" ) )
+            {
                 buildTarget( project, element );
-            } else
+            }
+            else
             {
                 final String message =
                     REZ.getString( "ant.unknown-toplevel-element.error", name, element.getLocation() );
@@ -456,9 +456,12 @@ public class DefaultProjectBuilder
 
     protected boolean validName( final String name )
     {
-        if( -1 != name.indexOf( "->" ) ) {
+        if( -1 != name.indexOf( "->" ) )
+        {
             return false;
-        } else {
+        }
+        else
+        {
             return true;
         }
     }
diff --git a/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/Resources.properties b/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/Resources.properties
index 63e387bed..9e980c08e 100644
--- a/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/Resources.properties
+++ b/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/Resources.properties
@@ -26,3 +26,6 @@ ant.target-bad-dependency.error=Discovered empty dependency in target {0} at {1}
 ant.malformed.version=Malformed version string "{0}" specified in version attribute of project.
 ant.version-missing.error=Missing version attribute from project.
 ant.bad-version.error=Incompatible build file version detected. Expected {0} but found {1}.
+
+duplicate-project.error=Can not have two projects referenced in a file with the name {0}.
+duplicate-target.error=Can not have two targets in a file with the name {0}.
diff --git a/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Resources.properties b/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Resources.properties
deleted file mode 100644
index 7f437b0e6..000000000
--- a/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Resources.properties
+++ /dev/null
@@ -1,2 +0,0 @@
-duplicate-project.error=Can not have two projects referenced in a file with the name {0}.
-duplicate-target.error=Can not have two targets in a file with the name {0}.