From 81882fe7435a245293fe377b6c6224400519d603 Mon Sep 17 00:00:00 2001 From: Stefan Bodewig Date: Mon, 12 Feb 2018 10:18:54 +0100 Subject: [PATCH] Java8 refactoring introdiced PrintWriter that we do not want to use PrintWriter's `println` method swallows exceptions and we really want to know when writing fails. --- .../org/apache/tools/ant/taskdefs/optional/Cab.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java b/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java index b94387d46..ebc46e287 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java @@ -23,7 +23,6 @@ import java.io.File; import java.io.FileWriter; import java.io.IOException; import java.io.OutputStream; -import java.io.PrintWriter; import java.util.Collections; import java.util.Vector; @@ -178,10 +177,13 @@ public class Cab extends MatchingTask { throws IOException { File listFile = FILE_UTILS.createTempFile("ant", "", null, true, true); - try (PrintWriter writer = - new PrintWriter(new BufferedWriter(new FileWriter(listFile)))) { - files.stream().map(f -> String.format("\"%s\"", f)) - .forEach(writer::println); + try (BufferedWriter writer = + new BufferedWriter(new FileWriter(listFile))) { + for (String f : files) { + String s = String.format("\"%s\"", f); + writer.write(s); + writer.newLine(); + } } return listFile; }