Browse Source

false positives for exceptions thrown from finally

master
Stefan Bodewig 8 years ago
parent
commit
7ffc0970d5
4 changed files with 6 additions and 6 deletions
  1. +1
    -1
      src/main/org/apache/tools/ant/Main.java
  2. +2
    -2
      src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java
  3. +2
    -2
      src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java
  4. +1
    -1
      src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java

+ 1
- 1
src/main/org/apache/tools/ant/Main.java View File

@@ -887,7 +887,7 @@ public class Main implements AntMain {
+ " that:");
error.printStackTrace();
}
throw new BuildException(t);
throw new BuildException(t); //NOSONAR
}
} else if (error != null) {
project.log(error.toString(), Project.MSG_ERR);


+ 2
- 2
src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java View File

@@ -747,7 +747,7 @@ public class FTP extends Task implements FTPTaskConfig {
try {
ftp.changeWorkingDirectory(directory);
} catch (IOException ioe) {
throw new BuildException(ioe, getLocation());
throw new BuildException(ioe, getLocation()); //NOSONAR
}
}
getProject().log("remote system is case sensitive : " + remoteSystemCaseSensitive,
@@ -1155,7 +1155,7 @@ public class FTP extends Task implements FTPTaskConfig {
Project.MSG_ERR);
} finally {
if (!comeback) {
throw new BuildException("could not cd back to " + dir
throw new BuildException("could not cd back to " + dir //NOSONAR
+ " while checking a symlink");
}
}


+ 2
- 2
src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java View File

@@ -648,7 +648,7 @@ public class FTPTaskMirrorImpl implements FTPTaskMirror {
try {
ftp.changeWorkingDirectory(directory);
} catch (IOException ioe) {
throw new BuildException(ioe, task.getLocation());
throw new BuildException(ioe, task.getLocation()); //NOSONAR
}
}
task.log("remote system is case sensitive : "
@@ -1061,7 +1061,7 @@ public class FTPTaskMirrorImpl implements FTPTaskMirror {
Project.MSG_ERR);
} finally {
if (!comeback) {
throw new BuildException("could not cd back to " + dir
throw new BuildException("could not cd back to " + dir //NOSONAR
+ " while checking a symlink");
}
}


+ 1
- 1
src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java View File

@@ -262,7 +262,7 @@ public class SplashTask extends Task {
// swallow if there was an error before so that
// original error will be passed up
if (success) {
throw new BuildException(ioe);
throw new BuildException(ioe); //NOSONAR
}
}
}


Loading…
Cancel
Save