From 7fe6d0a0fe890f6a59aa6a0bf3ca1e756b94dc93 Mon Sep 17 00:00:00 2001 From: Peter Reilly Date: Sun, 12 Nov 2006 22:35:26 +0000 Subject: [PATCH] checkstyle git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@474076 13f79535-47bb-0310-9956-ffa450edef68 --- .../ant/taskdefs/compilers/DefaultCompilerAdapter.java | 5 +++++ .../org/apache/tools/ant/taskdefs/email/Mailer.java | 10 +++++++--- .../tools/ant/taskdefs/rmic/RmicAdapterFactory.java | 1 - 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java b/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java index 0e7c41cf9..ac822873a 100644 --- a/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java +++ b/src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java @@ -45,6 +45,7 @@ import org.apache.tools.ant.taskdefs.condition.Os; * @since Ant 1.3 */ public abstract class DefaultCompilerAdapter implements CompilerAdapter { + // CheckStyle:VisibilityModifier OFF - bc private static final FileUtils FILE_UTILS = FileUtils.getFileUtils(); @@ -72,8 +73,12 @@ public abstract class DefaultCompilerAdapter implements CompilerAdapter { protected Javac attributes; //must keep for subclass BC, though unused: + // CheckStyle:ConstantNameCheck OFF - bc protected static final String lSep = StringUtils.LINE_SEP; + // CheckStyle:ConstantNameCheck ON + // CheckStyle:VisibilityModifier ON + /** * Set the Javac instance which contains the configured compilation * attributes. diff --git a/src/main/org/apache/tools/ant/taskdefs/email/Mailer.java b/src/main/org/apache/tools/ant/taskdefs/email/Mailer.java index 3503f4c77..b9a645648 100644 --- a/src/main/org/apache/tools/ant/taskdefs/email/Mailer.java +++ b/src/main/org/apache/tools/ant/taskdefs/email/Mailer.java @@ -28,11 +28,14 @@ import org.apache.tools.ant.util.DateUtils; * @since Ant 1.5 */ public abstract class Mailer { + // CheckStyle:VisibilityModifier OFF - bc protected String host = null; protected int port = -1; protected String user = null; protected String password = null; + // CheckStyle:MemberNameCheck OFF - bc protected boolean SSL = false; + // CheckStyle:MemberNameCheck ON protected Message message; protected EmailAddress from; protected Vector replyToList = null; @@ -44,6 +47,7 @@ public abstract class Mailer { protected Task task; protected boolean includeFileNames = false; protected Vector headers = null; + // CheckStyle:VisibilityModifier ON /** * Set the mail server. @@ -86,11 +90,11 @@ public abstract class Mailer { /** * Set whether to send the mail through SSL. * - * @param SSL if true use SSL transport. + * @param ssl if true use SSL transport. * @since Ant 1.6 */ - public void setSSL(boolean SSL) { - this.SSL = SSL; + public void setSSL(boolean ssl) { + this.SSL = ssl; } /** diff --git a/src/main/org/apache/tools/ant/taskdefs/rmic/RmicAdapterFactory.java b/src/main/org/apache/tools/ant/taskdefs/rmic/RmicAdapterFactory.java index 51a4b9b00..75b05de00 100644 --- a/src/main/org/apache/tools/ant/taskdefs/rmic/RmicAdapterFactory.java +++ b/src/main/org/apache/tools/ant/taskdefs/rmic/RmicAdapterFactory.java @@ -22,7 +22,6 @@ import org.apache.tools.ant.BuildException; import org.apache.tools.ant.Task; import org.apache.tools.ant.taskdefs.Rmic; import org.apache.tools.ant.util.ClasspathUtils; -import org.apache.tools.ant.util.JavaEnvUtils; import java.util.Locale;