diff --git a/WHATSNEW b/WHATSNEW index 66f1450fe..a1c36d1f9 100644 --- a/WHATSNEW +++ b/WHATSNEW @@ -16,6 +16,9 @@ Fixed bugs: Other changes: -------------- +* Warn user when a reference in the form "${refid}" cannot be resolved as this + is a sign they probably meant "refid" (misuse of property expansion syntax). + Changes from Ant 1.7.0Beta3 to Ant 1.7.0RC1 =========================================== diff --git a/src/main/org/apache/tools/ant/Project.java b/src/main/org/apache/tools/ant/Project.java index 29db2af93..f86b8ae6c 100644 --- a/src/main/org/apache/tools/ant/Project.java +++ b/src/main/org/apache/tools/ant/Project.java @@ -1911,7 +1911,18 @@ public class Project implements ResourceFactory { return ret; } // Check for old id behaviour - return resolveIdReference(key, this); + ret = resolveIdReference(key, this); + if (ret == null && !key.equals(MagicNames.REFID_PROPERTY_HELPER)) { + Vector p = new Vector(); + PropertyHelper.getPropertyHelper(this).parsePropertyString( + key, new Vector(), p); + if (p.size() == 1) { + log("Unresolvable reference " + key + + " might be a misuse of property expansion syntax.", + MSG_WARN); + } + } + return ret; } /** diff --git a/src/tests/antunit/core/ref-psyntax-hint.xml b/src/tests/antunit/core/ref-psyntax-hint.xml new file mode 100644 index 000000000..061e5044a --- /dev/null +++ b/src/tests/antunit/core/ref-psyntax-hint.xml @@ -0,0 +1,9 @@ + + + + + + + +