From 7d82c966657d24ff761589a1e28c3b6e82c08708 Mon Sep 17 00:00:00 2001 From: Peter Donald Date: Sun, 30 Dec 2001 01:16:50 +0000 Subject: [PATCH] Remove those magic proeprties git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@270443 13f79535-47bb-0310-9956-ffa450edef68 --- .../tools/ant/taskdefs/compilers/Jikes.java | 35 ------------------- .../tools/ant/taskdefs/compilers/Jikes.java | 35 ------------------- 2 files changed, 70 deletions(-) diff --git a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java index 4e762faf1..d30ba7eb2 100644 --- a/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java +++ b/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java @@ -116,22 +116,6 @@ public class Jikes { cmd.createArgument().setValue( "-depend" ); } - /** - * XXX Perhaps we shouldn't use properties for these three options - * (emacs mode, warnings and pedantic), but include it in the javac - * directive? - */ - - /** - * Jikes has the nice feature to print error messages in a form readable - * by emacs, so that emacs can directly set the cursor to the place, - * where the error occured. - */ - String emacsProperty = m_project.getProperty( "build.compiler.emacs" ); - if( emacsProperty != null && Project.toBoolean( emacsProperty ) ) - { - cmd.createArgument().setValue( "+E" ); - } if( m_attributes.getNowarn() ) { @@ -144,25 +128,6 @@ public class Jikes cmd.createArgument().setValue( "-nowarn" ); } - /** - * Jikes can issue pedantic warnings. - */ - String pedanticProperty = m_project.getProperty( "build.compiler.pedantic" ); - if( pedanticProperty != null && Project.toBoolean( pedanticProperty ) ) - { - cmd.createArgument().setValue( "+P" ); - } - - /** - * Jikes supports something it calls "full dependency checking", see the - * jikes documentation for differences between -depend and +F. - */ - String fullDependProperty = m_project.getProperty( "build.compiler.fulldepend" ); - if( fullDependProperty != null && Project.toBoolean( fullDependProperty ) ) - { - cmd.createArgument().setValue( "+F" ); - } - addCurrentCompilerArgs( cmd ); int firstFileName = cmd.size(); diff --git a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers/Jikes.java b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers/Jikes.java index 4e762faf1..d30ba7eb2 100644 --- a/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers/Jikes.java +++ b/proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers/Jikes.java @@ -116,22 +116,6 @@ public class Jikes { cmd.createArgument().setValue( "-depend" ); } - /** - * XXX Perhaps we shouldn't use properties for these three options - * (emacs mode, warnings and pedantic), but include it in the javac - * directive? - */ - - /** - * Jikes has the nice feature to print error messages in a form readable - * by emacs, so that emacs can directly set the cursor to the place, - * where the error occured. - */ - String emacsProperty = m_project.getProperty( "build.compiler.emacs" ); - if( emacsProperty != null && Project.toBoolean( emacsProperty ) ) - { - cmd.createArgument().setValue( "+E" ); - } if( m_attributes.getNowarn() ) { @@ -144,25 +128,6 @@ public class Jikes cmd.createArgument().setValue( "-nowarn" ); } - /** - * Jikes can issue pedantic warnings. - */ - String pedanticProperty = m_project.getProperty( "build.compiler.pedantic" ); - if( pedanticProperty != null && Project.toBoolean( pedanticProperty ) ) - { - cmd.createArgument().setValue( "+P" ); - } - - /** - * Jikes supports something it calls "full dependency checking", see the - * jikes documentation for differences between -depend and +F. - */ - String fullDependProperty = m_project.getProperty( "build.compiler.fulldepend" ); - if( fullDependProperty != null && Project.toBoolean( fullDependProperty ) ) - { - cmd.createArgument().setValue( "+F" ); - } - addCurrentCompilerArgs( cmd ); int firstFileName = cmd.size();