diff --git a/proposal/myrmidon/src/java/org/apache/ant/modules/basic/Pattern.java b/proposal/myrmidon/src/java/org/apache/ant/modules/basic/Pattern.java index b96cb0ab3..e5b053ec1 100644 --- a/proposal/myrmidon/src/java/org/apache/ant/modules/basic/Pattern.java +++ b/proposal/myrmidon/src/java/org/apache/ant/modules/basic/Pattern.java @@ -7,20 +7,20 @@ */ package org.apache.ant.modules.basic; -import org.apache.myrmidon.api.TaskException; import org.apache.ant.tasklet.DataType; -import org.apache.ant.util.Condition; +import org.apache.myrmidon.api.TaskException; +import org.apache.myrmidon.components.model.Condition; /** * Basic data type for holding patterns. - * + * * @author Peter Donald */ public class Pattern implements DataType { - protected String m_name; - protected Condition m_condition; + private String m_name; + private Condition m_condition; /** * Retrieve name (aka value) of pattern. @@ -31,7 +31,7 @@ public class Pattern { return m_name; } - + /** * Get condition associated with pattern if any. * @@ -41,7 +41,7 @@ public class Pattern { return m_condition; } - + /** * Setter method for name/value of pattern. * Conforms to ant setter patterns @@ -85,7 +85,7 @@ public class Pattern * * @exception TaskException if an error occurs */ - protected void verifyConditionNull() + private void verifyConditionNull() throws TaskException { if( null != m_condition ) diff --git a/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProjectBuilder.java b/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProjectBuilder.java index cb6ecad20..d48dcdd01 100644 --- a/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProjectBuilder.java +++ b/proposal/myrmidon/src/java/org/apache/myrmidon/components/builder/DefaultProjectBuilder.java @@ -9,7 +9,6 @@ package org.apache.myrmidon.components.builder; import java.io.File; import java.io.IOException; -import org.apache.ant.util.Condition; import org.apache.avalon.framework.ExceptionUtil; import org.apache.avalon.framework.configuration.Configuration; import org.apache.avalon.framework.configuration.ConfigurationException; @@ -17,6 +16,7 @@ import org.apache.avalon.framework.configuration.DefaultConfigurationBuilder; import org.apache.avalon.framework.logger.AbstractLoggable; import org.apache.log.Logger; import org.apache.myrmidon.api.TaskContext; +import org.apache.myrmidon.components.model.Condition; import org.apache.myrmidon.components.model.DefaultProject; import org.apache.myrmidon.components.model.DefaultTarget; import org.apache.myrmidon.components.model.Project; diff --git a/proposal/myrmidon/src/java/org/apache/myrmidon/components/manager/DefaultProjectManager.java b/proposal/myrmidon/src/java/org/apache/myrmidon/components/manager/DefaultProjectManager.java index a2786dc7c..5cc38452f 100644 --- a/proposal/myrmidon/src/java/org/apache/myrmidon/components/manager/DefaultProjectManager.java +++ b/proposal/myrmidon/src/java/org/apache/myrmidon/components/manager/DefaultProjectManager.java @@ -8,7 +8,6 @@ package org.apache.myrmidon.components.manager; import java.util.ArrayList; -import org.apache.ant.util.Condition; import org.apache.avalon.framework.activity.Disposable; import org.apache.avalon.framework.activity.Initializable; import org.apache.avalon.framework.component.ComponentException; @@ -23,6 +22,7 @@ import org.apache.myrmidon.api.DefaultTaskContext; import org.apache.myrmidon.api.TaskContext; import org.apache.myrmidon.api.TaskException; import org.apache.myrmidon.components.executor.Executor; +import org.apache.myrmidon.components.model.Condition; import org.apache.myrmidon.components.model.Project; import org.apache.myrmidon.components.model.Target; import org.apache.myrmidon.listeners.ProjectListener; diff --git a/proposal/myrmidon/src/java/org/apache/ant/util/Condition.java b/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Condition.java similarity index 93% rename from proposal/myrmidon/src/java/org/apache/ant/util/Condition.java rename to proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Condition.java index 11ae0157d..dc2790e41 100644 --- a/proposal/myrmidon/src/java/org/apache/ant/util/Condition.java +++ b/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Condition.java @@ -5,14 +5,14 @@ * version 1.1, a copy of which has been included with this distribution in * the LICENSE file. */ -package org.apache.ant.util; +package org.apache.myrmidon.components.model; -import org.apache.myrmidon.api.TaskException; +import org.apache.avalon.excalibur.property.PropertyException; +import org.apache.avalon.excalibur.property.PropertyUtil; import org.apache.avalon.framework.component.Component; import org.apache.avalon.framework.context.Context; import org.apache.avalon.framework.context.ContextException; -import org.apache.avalon.excalibur.property.PropertyException; -import org.apache.avalon.excalibur.property.PropertyUtil; +import org.apache.myrmidon.api.TaskException; /** * Class representing a condition. @@ -40,7 +40,7 @@ public class Condition { return m_isIfCondition; } - + public boolean evaluate( final Context context ) throws TaskException { @@ -48,14 +48,14 @@ public class Condition try { - final Object resolved = - PropertyUtil.resolveProperty( getCondition(), context, false ); + final Object resolved = + PropertyUtil.resolveProperty( getCondition(), context, false ); - if( null != resolved ) + if( null != resolved ) { final Object object = context.get( resolved ); //TODO: Do more than just check for presence???????????? - + //true as object present result = true; } diff --git a/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/DefaultTarget.java b/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/DefaultTarget.java index 8f2662a9b..af7563848 100644 --- a/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/DefaultTarget.java +++ b/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/DefaultTarget.java @@ -8,7 +8,6 @@ package org.apache.myrmidon.components.model; import java.util.ArrayList; -import org.apache.ant.util.Condition; import org.apache.avalon.framework.configuration.Configuration; /** diff --git a/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Target.java b/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Target.java index aaebb5ba7..6681a4ff9 100644 --- a/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Target.java +++ b/proposal/myrmidon/src/java/org/apache/myrmidon/components/model/Target.java @@ -7,7 +7,6 @@ */ package org.apache.myrmidon.components.model; -import org.apache.ant.util.Condition; import org.apache.avalon.framework.component.Component; import org.apache.avalon.framework.configuration.Configuration;