From 7ac5356019aca23d3d4deef18ce09bf05dfc0577 Mon Sep 17 00:00:00 2001
From: Stefan Bodewig <bodewig@apache.org>
Date: Tue, 29 Nov 2005 04:52:33 +0000
Subject: [PATCH] performance enhancement, without this
 getNonFilesetResourcesToAdd might get invoked twice if the manifest changes

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@349646 13f79535-47bb-0310-9956-ffa450edef68
---
 src/main/org/apache/tools/ant/taskdefs/Jar.java | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/main/org/apache/tools/ant/taskdefs/Jar.java b/src/main/org/apache/tools/ant/taskdefs/Jar.java
index 27c17c4b3..959519106 100644
--- a/src/main/org/apache/tools/ant/taskdefs/Jar.java
+++ b/src/main/org/apache/tools/ant/taskdefs/Jar.java
@@ -46,6 +46,7 @@ import org.apache.tools.ant.Project;
 import org.apache.tools.ant.types.EnumeratedAttribute;
 import org.apache.tools.ant.types.FileSet;
 import org.apache.tools.ant.types.Path;
+import org.apache.tools.ant.types.ResourceCollection;
 import org.apache.tools.ant.types.ZipFileSet;
 import org.apache.tools.zip.JarMarker;
 import org.apache.tools.zip.ZipExtraField;
@@ -633,7 +634,7 @@ public class Jar extends Zip {
      * third arg if they already know that the archive is
      * out-of-date.</p>
      *
-     * @param filesets The filesets to grab resources from
+     * @param rcs The resource collections to grab resources from
      * @param zipFile intended archive file (may or may not exist)
      * @param needsUpdate whether we already know that the archive is
      * out-of-date.  Subclasses overriding this method are supposed to
@@ -644,7 +645,7 @@ public class Jar extends Zip {
      *
      * @exception BuildException if it likes
      */
-    protected ArchiveState getResourcesToAdd(FileSet[] filesets,
+    protected ArchiveState getResourcesToAdd(ResourceCollection[] rcs,
                                              File zipFile,
                                              boolean needsUpdate)
         throws BuildException {
@@ -680,7 +681,7 @@ public class Jar extends Zip {
         }
 
         createEmpty = needsUpdate;
-        return super.getResourcesToAdd(filesets, zipFile, needsUpdate);
+        return super.getResourcesToAdd(rcs, zipFile, needsUpdate);
     }
 
     /**