From 767fc342370175a0fdea645b604eb4cc7abd6454 Mon Sep 17 00:00:00 2001 From: Gintas Grigelionis Date: Tue, 10 Apr 2018 15:52:59 +0200 Subject: [PATCH] Replace incorrect foreach loop with a stream --- src/main/org/apache/tools/ant/Project.java | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/main/org/apache/tools/ant/Project.java b/src/main/org/apache/tools/ant/Project.java index 3c20e3868..8d59ba020 100644 --- a/src/main/org/apache/tools/ant/Project.java +++ b/src/main/org/apache/tools/ant/Project.java @@ -23,6 +23,7 @@ import java.io.IOException; import java.io.InputStream; import java.lang.reflect.Method; import java.lang.reflect.Modifier; +import java.util.Arrays; import java.util.Collections; import java.util.Enumeration; import java.util.HashMap; @@ -34,6 +35,7 @@ import java.util.Set; import java.util.Stack; import java.util.Vector; import java.util.WeakHashMap; +import java.util.stream.Collectors; import org.apache.tools.ant.helper.DefaultExecutor; import org.apache.tools.ant.input.DefaultInputHandler; @@ -1828,13 +1830,10 @@ public class Project implements ResourceFactory { + root); } } - final StringBuilder buf = new StringBuilder(); - for (String root : roots) { - buf.append((buf.length() > 0) ? ", `" : "Build sequence for target(s) `") - .append(root).append('\''); - } - buf.append(" is ").append(ret); - log(buf.toString(), MSG_VERBOSE); + log("Build sequence for target(s)" + + Arrays.stream(roots).map(root -> String.format(" `%s'", root)) + .collect(Collectors.joining(",")) + + " is " + ret, MSG_VERBOSE); final Vector complete = (returnAll) ? ret : new Vector<>(ret); for (final Enumeration en = targetTable.keys(); en.hasMoreElements();) {