diff --git a/src/main/org/apache/tools/ant/util/DOMElementWriter.java b/src/main/org/apache/tools/ant/util/DOMElementWriter.java index cc8e68b0e..7ea329bef 100644 --- a/src/main/org/apache/tools/ant/util/DOMElementWriter.java +++ b/src/main/org/apache/tools/ant/util/DOMElementWriter.java @@ -43,6 +43,8 @@ import org.w3c.dom.Text; */ public class DOMElementWriter { + private static final int HEX = 16; + /** prefix for generated prefixes */ private static final String NS = "ns"; @@ -497,7 +499,7 @@ public class DOMElementWriter { if (ent.charAt(1) == '#') { if (ent.charAt(2) == 'x') { try { - Integer.parseInt(ent.substring(3, ent.length() - 1), 16); + Integer.parseInt(ent.substring(3, ent.length() - 1), HEX); return true; } catch (NumberFormatException nfe) { return false; diff --git a/src/main/org/apache/tools/ant/util/RegexpPatternMapper.java b/src/main/org/apache/tools/ant/util/RegexpPatternMapper.java index 53e128b3c..51ad6e652 100644 --- a/src/main/org/apache/tools/ant/util/RegexpPatternMapper.java +++ b/src/main/org/apache/tools/ant/util/RegexpPatternMapper.java @@ -29,6 +29,9 @@ import org.apache.tools.ant.util.regexp.RegexpMatcherFactory; * */ public class RegexpPatternMapper implements FileNameMapper { + + private static final int DECIMAL = 10; + // CheckStyle:VisibilityModifier OFF - bc protected RegexpMatcher reg = null; protected char[] to = null; @@ -130,7 +133,7 @@ public class RegexpPatternMapper implements FileNameMapper { for (int i = 0; i < to.length; i++) { if (to[i] == '\\') { if (++i < to.length) { - int value = Character.digit(to[i], 10); + int value = Character.digit(to[i], DECIMAL); if (value > -1) { result.append((String) v.elementAt(value)); } else { diff --git a/src/main/org/apache/tools/ant/util/depend/bcel/DependencyVisitor.java b/src/main/org/apache/tools/ant/util/depend/bcel/DependencyVisitor.java index 4bade96f8..8fff470ca 100644 --- a/src/main/org/apache/tools/ant/util/depend/bcel/DependencyVisitor.java +++ b/src/main/org/apache/tools/ant/util/depend/bcel/DependencyVisitor.java @@ -102,6 +102,7 @@ public class DependencyVisitor extends EmptyVisitor { start = classname.charAt(0); } // Check to see if it's an inner class 'com.company.Class$Inner' + // CheckStyle:MagicNumber OFF if ((start > 0x40) && (start < 0x5B)) { // first letter of the previous segment of the class name 'Class' // is upper case ascii. so according to the spec it's an inner class @@ -112,6 +113,7 @@ public class DependencyVisitor extends EmptyVisitor { // Add the class in dotted notation 'com.company.Class' addClass(classname); } + // CheckStyle:MagicNumber ON } else { // Add a class with no package 'Class' addClass(classname); diff --git a/src/main/org/apache/tools/ant/util/regexp/JakartaOroRegexp.java b/src/main/org/apache/tools/ant/util/regexp/JakartaOroRegexp.java index 91c378d03..45d00e448 100644 --- a/src/main/org/apache/tools/ant/util/regexp/JakartaOroRegexp.java +++ b/src/main/org/apache/tools/ant/util/regexp/JakartaOroRegexp.java @@ -27,6 +27,8 @@ import org.apache.tools.ant.BuildException; */ public class JakartaOroRegexp extends JakartaOroMatcher implements Regexp { + private static final int DECIMAL = 10; + /** Constructor for JakartaOroRegexp */ public JakartaOroRegexp() { super(); @@ -52,7 +54,7 @@ public class JakartaOroRegexp extends JakartaOroMatcher implements Regexp { } else if (c == '\\') { if (++i < argument.length()) { c = argument.charAt(i); - int value = Character.digit(c, 10); + int value = Character.digit(c, DECIMAL); if (value > -1) { subst.append("$").append(value); } else { diff --git a/src/main/org/apache/tools/ant/util/regexp/JakartaRegexpRegexp.java b/src/main/org/apache/tools/ant/util/regexp/JakartaRegexpRegexp.java index 08011d1a2..5868fefa9 100644 --- a/src/main/org/apache/tools/ant/util/regexp/JakartaRegexpRegexp.java +++ b/src/main/org/apache/tools/ant/util/regexp/JakartaRegexpRegexp.java @@ -27,6 +27,8 @@ import org.apache.tools.ant.BuildException; public class JakartaRegexpRegexp extends JakartaRegexpMatcher implements Regexp { + private static final int DECIMAL = 10; + /** Constructor for JakartaRegexpRegexp */ public JakartaRegexpRegexp() { super(); @@ -65,7 +67,7 @@ public class JakartaRegexpRegexp extends JakartaRegexpMatcher if (c == '\\') { if (++i < argument.length()) { c = argument.charAt(i); - int value = Character.digit(c, 10); + int value = Character.digit(c, DECIMAL); if (value > -1) { result.append((String) v.elementAt(value)); } else { diff --git a/src/main/org/apache/tools/ant/util/regexp/Jdk14RegexpRegexp.java b/src/main/org/apache/tools/ant/util/regexp/Jdk14RegexpRegexp.java index ee7fdb98c..bd0faa86c 100644 --- a/src/main/org/apache/tools/ant/util/regexp/Jdk14RegexpRegexp.java +++ b/src/main/org/apache/tools/ant/util/regexp/Jdk14RegexpRegexp.java @@ -26,6 +26,8 @@ import org.apache.tools.ant.BuildException; */ public class Jdk14RegexpRegexp extends Jdk14RegexpMatcher implements Regexp { + private static final int DECIMAL = 10; + /** Constructor for Jdk14RegexpRegexp */ public Jdk14RegexpRegexp() { super(); @@ -65,7 +67,7 @@ public class Jdk14RegexpRegexp extends Jdk14RegexpMatcher implements Regexp { } else if (c == '\\') { if (++i < argument.length()) { c = argument.charAt(i); - int value = Character.digit(c, 10); + int value = Character.digit(c, DECIMAL); if (value > -1) { subst.append("$").append(value); } else {