From 71220c5b2f30a94fa10644b4a6e028c33f07dcca Mon Sep 17 00:00:00 2001
From: Jan Materne <jhm@apache.org>
Date: Fri, 2 Mar 2007 11:31:53 +0000
Subject: [PATCH] <antversion>-TASK evaluates now atLeast and exactly
 attributes.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@513710 13f79535-47bb-0310-9956-ffa450edef68
---
 .../ant/taskdefs/condition/AntVersion.java    | 10 ++++++++-
 .../taskdefs/condition/antversion-test.xml    | 21 ++++++++++++++++++-
 2 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/src/main/org/apache/tools/ant/taskdefs/condition/AntVersion.java b/src/main/org/apache/tools/ant/taskdefs/condition/AntVersion.java
index 5c8ee6f4c..017813588 100644
--- a/src/main/org/apache/tools/ant/taskdefs/condition/AntVersion.java
+++ b/src/main/org/apache/tools/ant/taskdefs/condition/AntVersion.java
@@ -41,7 +41,15 @@ public class AntVersion extends Task implements Condition {
         if (propertyname == null) {
             throw new BuildException("'property' must be set.");
         }
-        getProject().setNewProperty(propertyname, getVersion().toString());
+        if (atLeast!=null || exactly!=null) {
+            // If condition values are set, evaluate the condition
+            if (eval()) {
+                getProject().setNewProperty(propertyname, getVersion().toString());
+            }
+        } else {
+            // Raw task
+            getProject().setNewProperty(propertyname, getVersion().toString());
+        }
     }
 
     /**
diff --git a/src/tests/antunit/taskdefs/condition/antversion-test.xml b/src/tests/antunit/taskdefs/condition/antversion-test.xml
index 4be5b1b98..c5fe5aea3 100644
--- a/src/tests/antunit/taskdefs/condition/antversion-test.xml
+++ b/src/tests/antunit/taskdefs/condition/antversion-test.xml
@@ -23,8 +23,27 @@
     
   <target name="test-task">
     <antversion property="antversion"/>
-    <au:assertPropertyEquals name="antversion" value="1.7.1"/>
+    <au:assertPropertySet name="antversion" message="Property 'antversion' should be set."/>
+    <echo>AntVersion=${antversion}</echo>  
   </target>    
+    
+  <target name="test-property-conditional1">
+    <antversion property="antversion" atleast="2.0.0"/>
+    <au:assertTrue message="Property 'antversion' should not be set because this is not Ant 2.0.0+.">
+      <not>
+        <isset property="antversion"/>  
+      </not>  
+    </au:assertTrue>  
+  </target>
+    
+  <target name="test-property-conditional2">
+    <antversion property="antversion" atleast="1.7.0"/>
+    <au:assertTrue message="Property 'antversion' should be set because we should have Ant 1.7.0+ (${ant.version}).">
+      <isset property="antversion"/>  
+    </au:assertTrue>  
+  </target>
+    
+      
 
   <target name="all">
     <au:antunit>